Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use pana's License.path, use 'license' label instead. #7846

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jul 3, 2024

Context: for a long while now, we only accept the LICENSE file as the source of the package license(s). pana will remove the path field in an upcoming release, we should not use it anymore: dart-lang/pana#1385

@isoos isoos requested review from jonasfj and sigurdm July 3, 2024 12:21
@sigurdm
Copy link
Contributor

sigurdm commented Jul 5, 2024

Are there not old packages that follow the old convention, and need this?

@isoos
Copy link
Collaborator Author

isoos commented Jul 5, 2024

Are there not old packages that follow the old convention, and need this?

Short answer: we don't need it. Couple of details:

  • This is used only for the label.
  • We no longer extract license content from anything else except LICENSE.
  • We store the extracted license text in the datastore, and pana analysis will not affect it much. (Which may be a good or a bad thing, depending on how I look at it).

@isoos isoos merged commit d7d3c60 into dart-lang:master Jul 5, 2024
31 checks passed
@isoos isoos deleted the license-path branch July 5, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants