Skip to content

Commit

Permalink
[io] Move new Windows dependency to libdart_builtin targets
Browse files Browse the repository at this point in the history
The new library dependency added to File io on Windows should be
added to the libdart_builtin targets, not the downstream
executables, so that Flutter builds that use libdart_builtin
will inherit the dependency.

Follow-up to https://dart-review.googlesource.com/c/sdk/+/335940

TEST=monorepo_build,dart_ci,flutter_engine_ci

Bug: #45981
Bug: #53848
Change-Id: I90407a0d702683cadb4f2d2c57bb6c598b6e052d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353680
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
  • Loading branch information
whesse authored and Commit Queue committed Feb 22, 2024
1 parent c70591b commit a8b8948
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions runtime/bin/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ template("build_libdart_builtin") {
public_deps = [ "//sdk/lib/fdio" ]
}
}
if (is_win) {
libs = [ "Pathcch.lib" ]
}
include_dirs = [ ".." ]
sources = builtin_impl_sources
}
Expand Down Expand Up @@ -228,7 +231,6 @@ template("build_gen_snapshot") {
libs = [
"iphlpapi.lib",
"ws2_32.lib",
"Pathcch.lib",
"Rpcrt4.lib",
"shlwapi.lib",
"winmm.lib",
Expand Down Expand Up @@ -815,7 +817,6 @@ template("dart_executable") {
# CoTaskMemAlloc up with `DynamicLibrary.process()`.
"ole32.lib",
"iphlpapi.lib",
"Pathcch.lib",
"psapi.lib",
"ws2_32.lib",
"Rpcrt4.lib",
Expand Down Expand Up @@ -1034,7 +1035,6 @@ executable("run_vm_tests") {
# CoTaskMemAlloc up with `DynamicLibrary.process()`.
"ole32.lib",
"iphlpapi.lib",
"Pathcch.lib",
"psapi.lib",
"ws2_32.lib",
"Rpcrt4.lib",
Expand Down

0 comments on commit a8b8948

Please sign in to comment.