Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

co19/LibTest/io/Link/createSync_A06_t0{1,3} Pass -> RuntimeError on vm win bots #53848

Closed
aam opened this issue Oct 24, 2023 · 8 comments
Closed

co19/LibTest/io/Link/createSync_A06_t0{1,3} Pass -> RuntimeError on vm win bots #53848

aam opened this issue Oct 24, 2023 · 8 comments
Assignees
@brianquinlan
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening library-io os-windows P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team

Comments

@aam
Copy link
Contributor

aam commented Oct 24, 2023

https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-win-debug-x64/2517/overview

--- Command "vm" (took 03.000845s):
set DART_CONFIGURATION=DebugX64 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64\crashpad_handler.exe & out\DebugX64\dart.exe --sound-null-safety -Dtest_runner.configuration=vm-win-debug-x64 --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:\b\s\w\ir\tests\co19\src\LibTest\io\Link\createSync_A06_t01.dart

exit code:
255

stderr:
Unhandled exception:
Expect.equals(expected: <directory>, actual: <link>) fails.
#0      _fail (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect.dart:18:5)
#1      Expect.equals (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect_common.dart:15:7)
#2      _main (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/Link/createSync_A06_t01.dart:54:10)
#3      inSandbox (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/file_utils.dart:23:22)
#4      main (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/Link/createSync_A06_t01.dart:42:3)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:19)
#6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

--- Re-run this test:
python3 tools/test.py -n vm-win-debug-x64 co19/LibTest/io/Link/createSync_A06_t01

--- Command "vm" (took 03.000996s):
set DART_CONFIGURATION=DebugX64 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64\crashpad_handler.exe & out\DebugX64\dart.exe --sound-null-safety -Dtest_runner.configuration=vm-win-debug-x64 --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:\b\s\w\ir\tests\co19\src\LibTest\io\Link\createSync_A06_t03.dart

exit code:
255

stderr:
Unhandled exception:
Expect.equals(expected: <directory>, actual: <link>) fails.
#0      _fail (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect.dart:18:5)
#1      Expect.equals (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect_common.dart:15:7)
#2      _main (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/Link/createSync_A06_t03.dart:54:10)
#3      inSandbox (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/file_utils.dart:23:22)
#4      main (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/Link/createSync_A06_t03.dart:42:3)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:19)
#6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

--- Re-run this test:
python3 tools/test.py -n vm-win-debug-x64 co19/LibTest/io/Link/createSync_A06_t03

cc @sgrekhov @brianquinlan

Started with https://dart.googlesource.com/sdk/+/5315b1dc6b0518e99e458a59e1ef084767fb2b39
@aam aam added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. os-windows gardening labels Oct 24, 2023
@sgrekhov
Copy link
Contributor

This issue was reported as #53689
Something is wrong with relative links to directories on Windows

@brianquinlan brianquinlan self-assigned this Oct 26, 2023
@brianquinlan brianquinlan added library-io P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team labels Oct 26, 2023
@mkustermann
Copy link
Member

There's more tests like this that are failing, possibly due to same root cause, e.g. this flaky failure see log

--- Command "vm_compile_to_kernel" (took 03.000344s):
set DART_CONFIGURATION=DebugX64C & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64C\crashpad_handler.exe & C:\b\s\w\ir\pkg\vm\tool\gen_kernel.bat --aot --platform=out/DebugX64C/vm_platform_strong.dill -o C:\b\s\w\ir\out\DebugX64C\generated_compilations\vm-aot-win-debug-x64c\tests_co19_src_LibTest_io_Link_createSync_A06_t06\out.dill C:\b\s\w\ir\tests\co19\src\LibTest\io\Link\createSync_A06_t06.dart -Dtest_runner.configuration=vm-aot-win-debug-x64c --packages=C:\b\s\w\ir\.dart_tool\package_config.json -Ddart.vm.product=false --sound-null-safety

exit code:
0

--- Command "precompiler" (took 21.000153s):
set DART_CONFIGURATION=DebugX64C & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64C\crashpad_handler.exe & out\DebugX64C\gen_snapshot --snapshot-kind=app-aot-elf --elf=C:/b/s/w/ir/out/DebugX64C/generated_compilations/vm-aot-win-debug-x64c/tests_co19_src_LibTest_io_Link_createSync_A06_t06/out.aotsnapshot --loading-unit-manifest=C:/b/s/w/ir/out/DebugX64C/generated_compilations/vm-aot-win-debug-x64c/tests_co19_src_LibTest_io_Link_createSync_A06_t06/ignored.json --sound-null-safety -Dtest_runner.configuration=vm-aot-win-debug-x64c --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:\b\s\w\ir\out\DebugX64C\generated_compilations\vm-aot-win-debug-x64c\tests_co19_src_LibTest_io_Link_createSync_A06_t06\out.dill

exit code:
0

--- Command "remove_kernel_file" (took 50ms):
set DART_CONFIGURATION=DebugX64C & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64C\crashpad_handler.exe & cmd.exe /c del C:\b\s\w\ir\out\DebugX64C\generated_compilations\vm-aot-win-debug-x64c\tests_co19_src_LibTest_io_Link_createSync_A06_t06\out.dill

exit code:
0

--- Command "vm" (took 264ms):
set DART_CONFIGURATION=DebugX64C & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64C\crashpad_handler.exe & set TEST_COMPILATION_DIR=C:/b/s/w/ir/out/DebugX64C/generated_compilations/vm-aot-win-debug-x64c/tests_co19_src_LibTest_io_Link_createSync_A06_t06 & out\DebugX64C\dart_precompiled_runtime.exe --sound-null-safety -Dtest_runner.configuration=vm-aot-win-debug-x64c --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:/b/s/w/ir/out/DebugX64C/generated_compilations/vm-aot-win-debug-x64c/tests_co19_src_LibTest_io_Link_createSync_A06_t06/out.aotsnapshot

exit code:
255

stderr:
Unhandled exception:
Expect.equals(expected: <notFound>, actual: <link>) fails.
#0      _fail (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect.dart:18)
#1      Expect.equals (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect_common.dart:15)
#2      _main (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/Link/createSync_A06_t06.dart:66)
#3      inSandbox (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/file_utils.dart:23)
#4      main (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/Link/createSync_A06_t06.dart:41)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297)
#6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184)

--- Re-run this test:
python3 tools/test.py -n vm-aot-win-debug-x64c co19/LibTest/io/Link/createSync_A06_t06

@sgrekhov
Copy link
Contributor

sgrekhov commented Nov 3, 2023 •
edited
Loading

Seems that the failure above was reported as #53911

@dcharkes
Copy link
Contributor

The test is flaking, but now mentions directory instead of notFound:

--- Command "vm" (took 03.000840s):
set DART_CONFIGURATION=DebugX64C & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64C\crashpad_handler.exe & out\DebugX64C\dart.exe --sound-null-safety -Dtest_runner.configuration=vm-win-debug-x64c --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:\b\s\w\ir\tests\co19\src\LibTest\io\Link\createSync_A06_t01.dart

exit code:
255

stdout:
unittest-suite-wait-for-done
unittest-suite-success

stderr:
Unhandled exception:
Expect.equals(expected: <directory>, actual: <link>) fails.
#0      _fail (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect.dart:18:5)
#1      Expect.equals (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect_common.dart:15:7)
#2      _main (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/Link/createSync_A06_t01.dart:54:10)
#3      inSandbox (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/file_utils.dart:24:22)
#4      main (file:///C:/b/s/w/ir/tests/co19/src/LibTest/io/Link/createSync_A06_t01.dart:42:3)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:19)
#6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

--- Re-run this test:
python3 tools/test.py -n vm-win-debug-x64c co19/LibTest/io/Link/createSync_A06_t01

It's failing on all windows configurations: https://dart-current-results.web.app/#/filter=co19/LibTest/io/Link/createSync_A06_t01&showAll

@dcharkes
Copy link
Contributor

Same error on co19/LibTest/io/Link/create_A06_t01

https://dart-ci.appspot.com/log/vm-aot-win-debug-x64c/vm-aot-win-debug-x64c/256/co19/LibTest/io/Link/create_A06_t01

@sgrekhov
Copy link
Contributor

Both of the failures above are #53911

@a-siva
Copy link
Contributor

a-siva commented Jan 11, 2024

@brianquinlan any updates on this issue ?

@brianquinlan
Copy link
Contributor

I think that this is implementable now that we can drop Windows 7 support. I have a PR in progress.

copybara-service bot pushed a commit that referenced this issue Feb 21, 2024
@brianquinlan
[io] Fix a bug where relative symlinks to directories did not work on…
b457490 
… Windows.

Also modified `File::GetType` on Windows to correctly report the type of broken links as notFound.

Windows fixes:
co19/LibTest/io/Link/createSync_A04_t08
co19/LibTest/io/Link/createSync_A04_t10
co19/LibTest/io/Link/createSync_A04_t12
co19/LibTest/io/Link/createSync_A04_t14
co19/LibTest/io/Link/createSync_A04_t16
co19/LibTest/io/Link/createSync_A06_t01
co19/LibTest/io/Link/createSync_A06_t03
co19/LibTest/io/Link/createSync_A06_t06
co19/LibTest/io/Link/createSync_A06_t08
co19/LibTest/io/Link/create_A04_t08
co19/LibTest/io/Link/create_A04_t10
co19/LibTest/io/Link/create_A04_t12
co19/LibTest/io/Link/create_A04_t14
co19/LibTest/io/Link/create_A04_t16
co19/LibTest/io/Link/create_A06_t01
co19/LibTest/io/Link/create_A06_t03
co19/LibTest/io/Link/create_A06_t06
co19/LibTest/io/Link/create_A06_t08
co19/LibTest/io/Link/resolveSymbolicLinksSync_A01_t01
co19/LibTest/io/Link/resolveSymbolicLinks_A01_t01


Bug:#53848
Bug:#45981
Change-Id: I3d156f38540089d8adb12dbb79d0477330d9eb07
Tested: updated unit tests plus fixes existing tests
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335940
Commit-Queue: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 22, 2024
@whesse
[io] Move new Windows dependency to libdart_builtin targets
a8b8948 
The new library dependency added to File io on Windows should be
added to the libdart_builtin targets, not the downstream
executables, so that Flutter builds that use libdart_builtin
will inherit the dependency.

Follow-up to https://dart-review.googlesource.com/c/sdk/+/335940

TEST=monorepo_build,dart_ci,flutter_engine_ci

Bug: #45981
Bug: #53848
Change-Id: I90407a0d702683cadb4f2d2c57bb6c598b6e052d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353680
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianquinlan brianquinlan

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening library-io os-windows P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@aam @dcharkes @sgrekhov @mkustermann @a-siva @brianquinlan