-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't block when launching Dartium #2021
Comments
Currently, we need to wait for the results of the static analysis. Given a selected dart file, we need to know what library it is in, and which html files can be used to run that library. In addition, we need to know the type of the library - whether it is a server or web application. All this information is only available after the static analysis has run. We're not generating JavaScript for a Dartium launch - so we're not waiting for that to happen - but we still need to bt of information back form the analysis engine. |
The resolution is that we do need some static analysis to run before we can launch an app in Dartium. Added WontFix label. |
New in this update: ``` git log --oneline --no-decorate 9f00679ef47bc79cadc18e143720ade6c06c0100..980fc947db32bca6ae7d07fbb4ad0fcdba0050ec 980fc947 Add support for global activating package from a custom pub URL (#2041) 605cafb1 "features" is not a completely implemented or documented – hide flags (#2045) 73b66cd3 Merge pull request #2035 from sigurdm/logout_command 2b03587d dartfmt again ea805dfb Fix help-expectation 6f759c1f gitfmt 90079421 deps: move package_resolver to a dev dependency 297f017a enable and fix a number of lints f70ee39b Update to latest dependencies, require dart 2.1, fix lints 3446fb0d Add logout command 283471e7 Merge pull request #2016 from RedBrogdon/changelog 4c00f413 Update/add www.dartlang.org URLs (#2021) f7b147f9 Correcting nerfed changelog test. b9308223 Edited warning messages, addressed review issues. 9e9c8ed7 Fixed race conditions in test case. (#2020) ec972168 Removed references to gitsubmodules (#2019) ac8ad792 Copyright dates. f9d35d34 Formatted via dartfmt. a3351369 Adding ChangelogValidator to the list of validators. a826b121 Adds changelog validator and its tests. 2233e3d5 Update the required pkg:http (#1996) 75d8453a Update all of the obvious dependencies d07dafa5 Fix unnecessary `this` lints 43a91d12 Update to latest build_runner (#1966) b3a2cfb7 Add check for a scheme on PUB_HOSTED_URL (#1972) 6626bda3 Update tests for SDK constraint validation (#1968) ``` Change-Id: Ib7c5ec86e5a6d67094b8e70a32ff41efe571c074 Reviewed-on: https://dart-review.googlesource.com/c/94380 Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) matcher (https://github.com/dart-lang/matcher/compare/c1a0704..985e4ef): 985e4ef 2023-03-10 Sigurd Meldgaard Improve mismatch description of `contains` (#206) 5bc765d 2023-03-09 Nate Bosch Copy expect and async matchers from test package (#210) shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) test (https://github.com/dart-lang/test/compare/3ba78f1..0e5c028): 0e5c028d 2023-03-10 Nate Bosch Only use environment variable for chrome (#1970) 0b08d704 2023-03-08 Nate Bosch Add a hooks_testing library (#1952) aacee2c7 2023-03-08 Nate Bosch Retry filesystem deletes (#1965) webdev (https://github.com/dart-lang/webdev/compare/cfe9753..49013b8): 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) Change-Id: Idc785347448e6a56e26d9d46b3666440d59c22de Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288801 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
…edit" This reverts commit fcb8f80. Reason for revert: google3 roll failure Original change's description: > [deps] rev dartdoc, http, matcher, shelf, test, webdev, yaml_edit > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): > 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) > > http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): > 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) > ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) > 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) > > matcher (https://github.com/dart-lang/matcher/compare/c1a0704..985e4ef): > 985e4ef 2023-03-10 Sigurd Meldgaard Improve mismatch description of `contains` (#206) > 5bc765d 2023-03-09 Nate Bosch Copy expect and async matchers from test package (#210) > > shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): > 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) > c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) > > test (https://github.com/dart-lang/test/compare/3ba78f1..0e5c028): > 0e5c028d 2023-03-10 Nate Bosch Only use environment variable for chrome (#1970) > 0b08d704 2023-03-08 Nate Bosch Add a hooks_testing library (#1952) > aacee2c7 2023-03-08 Nate Bosch Retry filesystem deletes (#1965) > > webdev (https://github.com/dart-lang/webdev/compare/cfe9753..49013b8): > 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) > c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) > 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) > > yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): > fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints > c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) > > Change-Id: Idc785347448e6a56e26d9d46b3666440d59c22de > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288801 > Auto-Submit: Devon Carew <devoncarew@google.com> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com> > Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Change-Id: If7dd2027f4b6ead777eaf1b3cf7561d4dced4095 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288802 Auto-Submit: Devon Carew <devoncarew@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
…dev, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0): 7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a): 725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85) csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4): d32bdd4 2023-03-14 Devon Carew refactor the package example (#170) dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0): a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032) 05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029) 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
…elf, webdev, yaml_edit" This reverts commit aab39d3. Reason for revert: Failing some internal builds with the following error http_client_conformance_tests: #wrong_required_libs #wrong_conditional_srcs "required_libs" is currently [] but the code imports ["isolate"]. Original change's description: > [deps] rev args, benchmark_harness, csslib, dartdoc, http, shelf, webdev, yaml_edit > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0): > 7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237) > > benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a): > 725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85) > > csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4): > d32bdd4 2023-03-14 Devon Carew refactor the package example (#170) > > dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): > 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) > > http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): > 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) > ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) > 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) > > shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): > 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) > c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) > > webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0): > a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032) > 05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029) > 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) > c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) > 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) > > yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): > fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints > c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) > > Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023 > Reviewed-by: Konstantin Shcheglov <scheglov@google.com> > Commit-Queue: Konstantin Shcheglov <scheglov@google.com> > Auto-Submit: Devon Carew <devoncarew@google.com> Change-Id: I07b1e6041babc92df359da89eb18c1daf2634d88 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289024 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Siva Annamalai <asiva@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
… shelf, tools, vector_math, webdev, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0): 7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a): 725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85) clock (https://github.com/dart-lang/clock/compare/5abb481..984642e): 984642e 2023-03-15 Kevin Moore Require Dart 2.19, use and fix recommended lints (#46) csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4): d32bdd4 2023-03-14 Devon Carew refactor the package example (#170) dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) protobuf (https://github.com/dart-lang/protobuf/compare/75bc380..b90a4c4): b90a4c4 2023-03-16 Mahdi K. Fard Sort message constructors first. (#807) 00fd975 2023-03-15 Kevin Moore Fix formatting with latest SDK (#808) a67bbb3 2023-03-15 dependabot[bot] Bump actions/cache from 3.2.4 to 3.2.6 (#804) shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) tools (https://github.com/dart-lang/tools/compare/e5353aa..8d18d01): 8d18d01 2023-03-15 Elias Yishak Implement fake ga client (#37) vector_math (https://github.com/google/vector_math.dart/compare/1e4d000..7dec984): 7dec984 2023-03-16 eoineoineoin Add operator== to Quaternion (#288) webdev (https://github.com/dart-lang/webdev/compare/cfe9753..c2c8b17): c2c8b17 2023-03-16 Elliott Brooks (she/her) Prepare Webdev version `3.0.2` for release (#2037) d124fa5 2023-03-16 Elliott Brooks (she/her) Prepare extension for release (#2036) aef715d 2023-03-15 Elliott Brooks (she/her) Prepare DWDS 18.0.1 for release (#2035) a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032) 05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029) 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) Change-Id: Icf15fc0ffd3ee36e0380751d18fd491de071040e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289881 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
…buf, shelf, test, tools, vector_math, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/59dc475..1d94484): 1d94484c 2023-05-29 dependabot[bot] Bump github/codeql-action from 2.3.3 to 2.3.5 (#3422) 0edc1a71 2023-05-28 dependabot[bot] Bump http from 0.13.6 to 1.0.0 (#3421) http (https://github.com/dart-lang/http/compare/dfec389..8a4a4a6): 8a4a4a6 2023-05-25 Brian Quinlan Add a better toString to _ClientSocketException (#948) 5c1f1ad 2023-05-25 Devon Carew regenerate with the latest mono_repo (#947) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/9c6e9b3..7f2cab3): 7f2cab3 2023-05-26 Polina Cherkasova Nicely format retaining path. (#68) lints (https://github.com/dart-lang/lints/compare/72f107a..4236c43): 4236c43 2023-05-26 Parker Lougheed Remove pedantic from README (#124) 4ac79d8 2023-05-24 Parker Lougheed Update example for latest lints version (#123) mockito (https://github.com/dart-lang/mockito/compare/153c145..40fe2ca): 40fe2ca 2023-05-25 Nate Bosch Expand constraint on package:http native (https://github.com/dart-lang/native/compare/45e16dc..76bc55e): 76bc55e 2023-05-30 Daco Harkes [c_compiler] Target ios_x64 (#53) protobuf (https://github.com/dart-lang/protobuf/compare/7d2d293..346a72d): 346a72d 2023-05-30 Ömer Sinan Ağacan Fix generated ignore_for_file directives (#833) 35ea45f 2023-05-26 Kevin Moore Latest mono_repo (#834) shelf (https://github.com/dart-lang/shelf/compare/56919a1..a404b6a): a404b6a 2023-05-25 Devon Carew re-generate w/ the latest monorepo (#362) test (https://github.com/dart-lang/test/compare/309596e..3276921): 32769215 2023-05-25 dependabot[bot] Bump github/codeql-action from 2.3.2 to 2.3.5 (#2023) f74e85c8 2023-05-25 dependabot[bot] Bump dart-lang/setup-dart from 1.3.0 to 1.5.0 (#2022) 4b2bd272 2023-05-25 Devon Carew update the mono_repo and dependabot configs (#2021) tools (https://github.com/dart-lang/tools/compare/81ff996..b90a7e8): b90a7e8 2023-05-26 Devon Carew blast_repo fixes (#106) vector_math (https://github.com/google/vector_math.dart/compare/e3de8da..cd87f57): cd87f57 2023-05-30 JKris95 Axis calculation of quaternions from small angles (#272) 3762b25 2023-05-30 Lukas Klingsbo Removes the `new` keyword from readme (#284) df5877f 2023-05-30 Lukas Klingsbo Use named constructors in Vector2 and some general optimizations (#289) webdev (https://github.com/dart-lang/webdev/compare/d74fadd..4b69f1d): 4b69f1dd 2023-05-26 Anna Gringauze fix format breaking tests (#2124) b75f8e62 2023-05-25 Devon Carew re-generate w/ the latest monorepo (#2121) Change-Id: Ide9b7781102b654db15114d01cd4fbca40478906 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306304 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
When launching a sample via Dartium, there is no need to block the launch until editor a finishes analyzing the sample and its libraries.
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 4577
////////////////////////////////////////////////////////////////////////////////////
OS: Linux - amd64 (2.6.38.8-gg705)
experimental/projectsview = false
experimental/filesview = false
SDK installed = true
Dartium installed = true
////////////////////////////////////////////////////////////////////////////////////
log unavailable: /home/danrubel/Downloads/dart/workspace/.metadata/.log (No such file or directory)
The text was updated successfully, but these errors were encountered: