-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top-level folder rename should rename folder on disk #2067
Comments
Set owner to @scheglov. |
Konstantin: does rename do this? |
https://chromiumcodereview.appspot.com/10495004 Added Started label. |
https://code.google.com/p/dart/source/detail?r=8219 Added Fixed label. |
dart-bot
pushed a commit
that referenced
this issue
Mar 28, 2019
git log --oneline --no-decorate 3c060aae47985e9a248b850f1d0450304a5c97e3..8c363fe26f059c3063f1129adbb3c4e22a8ce954 8c363fe2 Restore default server for uploader command (#2102) 154a1419 Fix #28 -- escaping arguments as mentioned in TODO (#2093) bb2b8b28 Remove validation for library file paths (#2067) Change-Id: I795a8d58144003129b36e481b2693656035b2057 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97638 Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Apr 10, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`. tools (https://github.com/dart-lang/tools/compare/cd799be..58d9147): 58d9147 2023-04-07 Christopher Fujino [unified_analytics] Add NoOpAnalytics (#77) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/40eb236..b28bae6): b28bae6 2023-04-07 Rexios Allow passing through custom http client in IO socket connect (#259) 1064b47 2023-04-07 Nate Bosch Fix deprecated_new_in_comment_reference (#262) webdev (https://github.com/dart-lang/webdev/compare/22b34e3..7546291): 75462913 2023-04-07 Elliott Brooks Run mono_repo generate (#2081) 9964ebab 2023-04-07 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.3 (#2067) 3dee56b5 2023-04-07 Anna Gringauze Remove eval error message on async frames (#2073) d6b3e9ce 2023-04-07 Elliott Brooks Dart Code Metrics follow-up (#2072) 48e3211a 2023-04-07 Elliott Brooks Update the release script to take into account `pubspec_overrides.yaml` (#2080) fd75f511 2023-04-06 Elliott Brooks Reset Webdev to 3.0.5-dev (#2077) Change-Id: Iac863f7c4822fe6b9585e80e95d69467e8d60b6d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294364 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Devon Carew <devoncarew@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Jul 20, 2023
…string_scanner, test, test_descriptor, vector_math Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/06d7288..a04ac3e): a04ac3e8 2023-07-19 Sam Rawlins Format testing and fix static-type-parameter issue (#3465) a44ecebc 2023-07-19 Sam Rawlins Move validation-related tasks to package:args (#3463) 392812e4 2023-07-17 dependabot[bot] Bump analyzer from 5.13.0 to 6.0.0 (#3458) 642e8d8b 2023-07-17 Sam Rawlins Convert 'p' prefixes to 'path' in test/ (#3462) ecosystem (https://github.com/dart-lang/ecosystem/compare/2052a4c..27ff3e9): 27ff3e9 2023-07-19 Moritz Add debug message (#142) 02703ce 2023-07-18 Moritz Split commenting into new workflow (#141) a52ac63 2023-07-18 Moritz Finish renaming `coverage_web` (#140) ffa1ecb 2023-07-17 Moritz Health workflow updates (#134) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/515612e..098bafc): 098bafc 2023-07-20 fzyzcjy Update pubspec.yaml (#75) 7606fd1 2023-07-19 Polina Cherkasova Improve performance. (#98) e6778b3 2023-07-18 Polina Cherkasova Explain case when static object causes leaks. (#96) cca1d77 2023-07-18 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#86) markdown (https://github.com/dart-lang/markdown/compare/ee4e1b3..faabb1a): faabb1a 2023-07-17 Kevin Moore Bump pkg:http (dev) dependency (#551) mime (https://github.com/dart-lang/mime/compare/bdb66bd..799b398): 799b398 2023-07-18 Kevin Moore update lints, require Dart 3 (#101) d17e3ed 2023-07-18 Kevin Moore blast_repo fixes (#100) native (https://github.com/dart-lang/native/compare/7c474e1..2598ac6): 2598ac6 2023-07-20 Daco Harkes Package name spacing (#101) 3d73b4a 2023-07-19 Daco Harkes [native_assets_builder] Builder `out/` folder (#99) 6308330 2023-07-19 Daco Harkes Remove compiled files (#92) string_scanner (https://github.com/dart-lang/string_scanner/compare/35657e2..413b57a): 413b57a 2023-07-18 Kevin Moore Require Dart 3, update lints (#61) 53690da 2023-07-18 Kevin Moore blast_repo fixes (#60) test (https://github.com/dart-lang/test/compare/a92b5bb..37e54e3): 37e54e32 2023-07-19 Nate Bosch Handle initial message entirely within conditional (#2067) e76bffe8 2023-07-19 Nate Bosch Expand dom interop to cover more uses (#2066) 8bc188f7 2023-07-18 Lukas Klingsbo docs: Fix grammar and typos in Checks readme (#2058) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/54a4c59..36d8617): 36d8617 2023-07-18 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#53) vector_math (https://github.com/google/vector_math.dart/compare/c147038..048777a): 048777a 2023-07-19 moritzblume Fix rotation around Y axis (#262) 47a08ea 2023-07-17 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#293) Change-Id: Id8010082c818c995aa7968327f98f347ff45761d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315221 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The rub is that eclipse special cases project containers. When you rename a top-level folder, errr project, only the project metadata (in .project) gets updated. In the model where its folders all the way down this is surprising.
The text was updated successfully, but these errors were encountered: