Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frog generates invalid JS with an assert() as the else clause #2072

Closed
munificent opened this issue Mar 9, 2012 · 2 comments
Closed

Frog generates invalid JS with an assert() as the else clause #2072

munificent opened this issue Mar 9, 2012 · 2 comments
Assignees
@kasperl
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js

Comments

@munificent
Copy link
Member

Compile this code with frog:

main() {
  if (true) print('ok'); else assert('unreachable');
}

And it generates:

function main() {
  if (true) print$("ok");
  else // :(
}
@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, FromAreaFrog labels.

@kasperl
Copy link

kasperl commented Jun 12, 2012

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Apr 10, 2023
@devoncarew
[deps] rev tools, web_socket_channel, webdev
b603d4c 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

tools (https://github.com/dart-lang/tools/compare/cd799be..58d9147):
  58d9147  2023-04-07  Christopher Fujino  [unified_analytics] Add NoOpAnalytics (#77)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/40eb236..b28bae6):
  b28bae6  2023-04-07  Rexios  Allow passing through custom http client in IO socket connect (#259)
  1064b47  2023-04-07  Nate Bosch  Fix deprecated_new_in_comment_reference (#262)

webdev (https://github.com/dart-lang/webdev/compare/22b34e3..7546291):
  75462913  2023-04-07  Elliott Brooks  Run mono_repo generate (#2081)
  9964ebab  2023-04-07  dependabot[bot]  Bump actions/labeler from 4.0.2 to 4.0.3 (#2067)
  3dee56b5  2023-04-07  Anna Gringauze  Remove eval error message on async frames (#2073)
  d6b3e9ce  2023-04-07  Elliott Brooks  Dart Code Metrics follow-up (#2072)
  48e3211a  2023-04-07  Elliott Brooks  Update the release script to take into account `pubspec_overrides.yaml` (#2080)
  fd75f511  2023-04-06  Elliott Brooks  Reset Webdev to 3.0.5-dev (#2077)

Change-Id: Iac863f7c4822fe6b9585e80e95d69467e8d60b6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294364
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Aug 11, 2023
@devoncarew
[deps] rev dartdoc, ffi, http, test, tools
accf5a5 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/e8d00c0..5cfb1f3):
  5cfb1f36  2023-08-07  Sam Rawlins  Bump to analyzer 6.1.0 (#3474)

ffi (https://github.com/dart-lang/ffi/compare/f01dfca..e2c01a9):
  e2c01a9  2023-08-08  Slava Egorov  Expose pointer to free from allocators (#203)

http (https://github.com/dart-lang/http/compare/7e9ed12..9f167a7):
  9f167a7  2023-08-08  Alex James  Remove example test from java_http (#1001)

test (https://github.com/dart-lang/test/compare/5d571d6..9b1828f):
  9b1828f4  2023-08-09  Nate Bosch  Send a MessagePort to host on frame startup (#2072)
  ae2ab1ee  2023-08-08  Jacob MacDonald  publish test_core v0.5.6 (#2076)
  2e9bba21  2023-08-08  Jacob MacDonald  fix failing casts when talking to minified apps from the host (#2075)

tools (https://github.com/dart-lang/tools/compare/f14bf2e..295ff92):
  295ff92  2023-08-10  Elias Yishak  Fix empty string for `CLIENT_ID` from being sent when user decides to opt in (#144)
  bc6c9f0  2023-08-09  Elias Yishak  Clean up on dart docs across all dart files under lib (#142)

Change-Id: I75147259ce51f240c1dc359896ec7709bada288f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319783
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasperl kasperl

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @munificent @kasperl @anders-sandholm