Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frog and frogsh wrongly give a compile time error #2134

Closed
crelier opened this issue Mar 13, 2012 · 5 comments
Closed

Frog and frogsh wrongly give a compile time error #2134

crelier opened this issue Mar 13, 2012 · 5 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js

Comments

@crelier
Copy link
Contributor

crelier commented Mar 13, 2012

Frog and frogsh give a compile time error, although the malformed type is not used in a type test, since the assigned value is null.

FAILED: frog release_ia32 language/WrongNumberTypeArgumentsTest/00
Expected: pass
Actual: fail

stdout:
out/Release_ia32/generated_tests/language/WrongNumberTypeArgumentsTest_00.dart:7:1: error: wrong number of type arguments
Map<String> foo; /// 00: static type warning
^^^^^^^^^^^
compilation failed with 1 errors
Compilation failed

Command line: out/Release_ia32/frog/bin/frog --ignore-unrecognized-flags --enable_asserts --enable_type_checks out/Release_ia32/generated_tests/language/WrongNumberTypeArgumentsTest_00.dart
@crelier
Copy link
Contributor Author

crelier commented Mar 13, 2012

TypeVariableBoundsTest/00 and TypeVariableBoundsTest/10 also fail because of this issue.

@madsager
Copy link
Contributor

Added Triaged label.

@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, OldAreaFrog labels.

@anders-sandholm
Copy link
Contributor

Removed OldAreaFrog label.
Added FromAreaFrog label.

@kasperl
Copy link

kasperl commented Jun 12, 2012

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 9, 2023
@devoncarew
[deps] rev protobuf, test, webdev
ca2adbc 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

protobuf (https://github.com/dart-lang/protobuf/compare/da6953c..edf8e92):
  edf8e92  2023-06-09  Ömer Sinan Ağacan  Fix parsing negative JSON values for uint32 fields (#839)
  2931b2e  2023-06-09  Ömer Sinan Ağacan  Add PR links to recent CHANGELOG entries (#838)

test (https://github.com/dart-lang/test/compare/7a6c98d..e7ae613):
  e7ae6139  2023-06-08  Nate Bosch  Remove redundant type checks (#2031)

webdev (https://github.com/dart-lang/webdev/compare/3d7f546..a6d761d):
  a6d761d8  2023-06-08  Elliott Brooks  Remove tabs permission (#2136)
  b02b344e  2023-06-08  Elliott Brooks  Catch `WipError` on calls to resume and map to appropriate RPC error code (#2134)

Change-Id: I58b111a433cef76a501c959f33db4e5463a34c60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308380
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @kasperl @madsager @anders-sandholm @crelier