Static type warnings from analyzing VM core libraries

[DartBot]

This issue was originally filed by zundel@google.com

---

I'm running 'dartc' over the VM specific runtime libraries and here are the errors that come out.

---

Attachment:
static-type-warnings-orig.txt (32.07 KB)

[iposva-google]

Carl, can you please rerun the static checker on the current set of core libraries and see what parts still apply?

---

Set owner to @lexprfuncall.
Added this to the Later milestone.
Added Accepted label.

[lexprfuncall]

Eric,

How can I reproduce this?

Carl

---

Added NeedsInfo label.

[DartBot]

This comment was originally written by zundel@google.com

---

If your build environment is setup from all.deps and you are building the command line with:

 ./tools/build.py -m release

you should have the analyzer command line tool under out/ReleaseIA32/analyzer/bin/dart_analzyer

Here is a retelling of issue #2142 brought up to date:

How to reproduce:
create a small dart file that includes all the libraries you want to test:
===
$ cat > /tmp/alllibs.dart <<EOT

#import("dart:core");
#import("dart:coreimpl");
#import("dart:json");
#import("dart:isolate", prefix: 'isolate');
#import("dart:uri");
#import("dart:utf");
EOT

===
To run analysis:
out/ReleaseIA32/analyzer/bin/dart_analyzer --show-sdk-warnings --platform "vm" /tmp/alllibs.dart

The different configurations for the 'platform' argument come from lib/config/import_
*.config

---

Added Accepted label.

[lexprfuncall]

I uploaded a change to fix many of the warnings coming from byte_array.dart.

http://codereview.chromium.org/10653002/

However, some warnings remain and we believe those warnings are incorrect. I have filed issue #3803 and once that is resolved I can scrub byte_array.dart of the remaining warnings.

As for the warnings in other classes, many are still present, 54 in total. Some warnings are reported in error, such as those related to shadowing. Here are the files affected

core/runtime/error.dart
coreimpl/runtime/double.dart
coreimpl/runtime/integers.dart
coreimpl/runtime/math.dart
coreimpl/runtime/regexp.dart
coreimpl/runtime/string.dart

---

Attachment:
darta-warnings.txt (9.65 KB)

---

Marked this as being blocked by #3803.

[lexprfuncall]

Set owner to @iposva-google.

[iposva-google]

Removed Priority-Medium label.
Added Priority-Unassigned label.

[iposva-google]

Added AssumedStale label.