Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartdoc: add libraries by their real filename #2230

Closed
DartBot opened this issue Mar 20, 2012 · 7 comments
Closed

dartdoc: add libraries by their real filename #2230

DartBot opened this issue Mar 20, 2012 · 7 comments

Comments

@DartBot
Copy link

DartBot commented Mar 20, 2012

This issue was originally filed by michael.haubenwa...@gmail.com


This came up with dartdoc.dart (bleeding_edge, r 5635)

In dartdoc the docIndex method creates a listing of the processed libraries (stored in _sortedLibraries). Currently the 'uri' entry is displayed twice.

The problem is in lang/world.dart > getOrAddLibrary(filename), where processing of filenames 'dart:uri' and '../../lib/uri/uri.dart' leads to 2 entries in the libraries array.

Using the attached patch i first sort of normalize the filename and then process the file.


Attachment:
world.dart.patch (637 Bytes)

@DartBot
Copy link
Author

DartBot commented Mar 20, 2012

This comment was originally written by michael.haubenwa...@gmail.com


typo: lang/world.dart should be frog/world.dart

@iposva-google
Copy link
Contributor

Added Area-Frog, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Mar 26, 2012

This comment was originally written by michael.haubenwa...@gmail.com


add a screenshot


Attachment:
[Screenshot-Dart Documentation - Google Chrome-2.png](https://storage.googleapis.com/google-code-attachments/dart/issue-2230/comment-3/Screenshot-Dart Documentation - Google Chrome-2.png) (225.91 KB)

@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, OldAreaFrog labels.

@anders-sandholm
Copy link
Contributor

Removed OldAreaFrog label.
Added FromAreaFrog label.

@kasperl
Copy link

kasperl commented Jun 12, 2012

This manifests as a dartdoc issue. Categorizing as such.


Removed Area-Dart2JS, FromAreaFrog labels.
Added Area-DartDoc label.
Changed the title to: "dartdoc: add libraries by their real filename".

@johnniwinther
Copy link
Member

Fixed by http://codereview.chromium.org/10701091/


Added Fixed label.

copybara-service bot pushed a commit that referenced this issue Sep 14, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/e96fbdb..babf5d1):
  babf5d1  2023-09-13  Devon Carew  add additional lints to dart_flutter_team_lints (#167)
  7740bef  2023-09-13  Moritz  Write comments on forks for `firehose` (#165)

http (https://github.com/dart-lang/http/compare/de19214..e19094a):
  e19094a  2023-09-14  Brian Quinlan  Use efficient operations when copying bytes between Dart and Java (#1019)
  d7e4375  2023-09-13  Parker Lougheed  Cleanup `package:http` utils (#1011)
  eafbbb0  2023-09-12  Brian Quinlan  Separate the cronet callbacks from the `send` method (#1017)
  2cbb703  2023-09-12  Brian Quinlan  Switch `cronet_http` to use jnigen (#1016)

native (https://github.com/dart-lang/native/compare/bbcbc1f..7faf62c):
  7faf62c  2023-09-14  Gabriel Terwesten  Add `includes`, `flags`, `std`, `language`, `cppLinkStdLib` options (#125)

shelf (https://github.com/dart-lang/shelf/compare/2926f76..e2a02b7):
  e2a02b7  2023-09-13  Kevin Moore  Move to latest pkg:dart_flutter_team_lints, bump min sdk to Dart 3 (#378)

tools (https://github.com/dart-lang/tools/compare/fa01f9b..1512f3d):
  1512f3d  2023-09-13  Elias Yishak  Add Fake Analytics instance that uses list to save events sent (#149)

webdev (https://github.com/dart-lang/webdev/compare/6b21ecf..501ccc2):
  501ccc28  2023-09-12  Elliott Brooks  Update DCM triggers to match Dart DevTools (#2230)

Change-Id: Ic3dc1924da48454a28e4c0d8705244ac1565e74a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325967
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants