Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventListener return value is ignored in html bindings #149

Closed
DartBot opened this issue Oct 17, 2011 · 1 comment
Closed

EventListener return value is ignored in html bindings #149

DartBot opened this issue Oct 17, 2011 · 1 comment
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable

Comments

@DartBot
Copy link

DartBot commented Oct 17, 2011

This issue was originally filed by danrice...@gmail.com


I am trying to intercept the right-click context menu as follows:

Window _window;
_window.on.contextMenu.add((Event event) {return false; });

This code is in fact called when I click the right mouse button in the browser window, but the 'return false' no longer has the desired effect of preventing the browser context menu from appearing, as it did in the previous DOM bindings.

A cursory inspection of the DOM code shows that contextMenu is a getter on the WindowEvents interface, returning an EventListenerList, and EventListenerList.add takes an EventListener as its first argument. However, EventListener is defined as a void function, while the standard DOM allows a return value in order to provide a way to cancel the event.

@DartBot
Copy link
Author

DartBot commented Oct 17, 2011

This comment was originally written by rice@google.com


Added Invalid label.

@DartBot DartBot added Type-Defect closed-invalid Closed as we don't believe the reported issue is generally actionable labels Oct 17, 2011
copybara-service bot pushed a commit that referenced this issue May 16, 2023
…ctor, browser_launcher, characters, cli_util, clock, collection, crypto, dartdoc, leak_tracker, lints

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2):
  f0f6cd2  2023-05-12  Devon Carew  blast_repo fixes (#243)

async (https://github.com/dart-lang/async/compare/0f368d3..d744058):
  d744058  2023-05-12  Devon Carew  blast_repo fixes (#242)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f):
  d9b389f  2023-05-12  Devon Carew  blast_repo fixes (#73)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4):
  e717ad4  2023-05-12  Devon Carew  blast_repo fixes (#90)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..3a1c982):
  3a1c982  2023-05-15  Devon Carew  Update README.md (#48)
  23e08e0  2023-05-12  Devon Carew  blast_repo fixes (#47)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315):
  40e4315  2023-05-12  Devon Carew  blast_repo fixes (#45)

characters (https://github.com/dart-lang/characters/compare/2af6783..3ef8883):
  3ef8883  2023-05-15  Devon Carew  blast_repo fixes (#82)

cli_util (https://github.com/dart-lang/cli_util/compare/7234f17..5a49947):
  5a49947  2023-05-15  Devon Carew  blast_repo fixes (#83)

clock (https://github.com/dart-lang/clock/compare/6b9df3e..fe85908):
  fe85908  2023-05-15  Devon Carew  blast_repo fixes (#51)

collection (https://github.com/dart-lang/collection/compare/6abff47..db2da48):
  db2da48  2023-05-15  Devon Carew  blast_repo fixes (#288)

crypto (https://github.com/dart-lang/crypto/compare/4e9dde1..216931a):
  216931a  2023-05-15  Devon Carew  blast_repo fixes (#149)

dartdoc (https://github.com/dart-lang/dartdoc/compare/d01ddc5..2952f6b):
  2952f6bf  2023-05-16  Sam Rawlins  Simplify ToolConfiguration and other options code (#3414)
  0cf21c15  2023-05-12  Janice Collins  Extract fileName / fileType from ModelElement, LibraryContainer into FileStructure (#3413)
  2ae78bcc  2023-05-12  Sam Rawlins  Split sidebars out into separate HTML files (#3384)
  f00d0443  2023-05-11  Janice Collins  Housekeeping:  language version 3.0, analyzer deprecations, pubspec update (#3412)
  370477d2  2023-05-10  dependabot[bot]  Bump github/codeql-action from 2.3.2 to 2.3.3 (#3410)
  e8c5de44  2023-05-08  Janice Collins  Begin extracting file structure information from ModelElement (#3408)
  24af8a11  2023-05-04  Janice Collins  Add a hideConstantImplementations dartdoc directive (#3398)
  078d42fd  2023-05-03  Janice Collins  Change language feature wording based on review in #3401 (#3405)
  31088c1b  2023-05-03  dependabot[bot]  Bump github/codeql-action from 2.2.12 to 2.3.2 (#3403)
  60055b4e  2023-05-03  Sam Rawlins  Update validate-sdk-docs task to allow 20 libs (#3404)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/bc7f604..8ae200a):
  8ae200a  2023-05-15  Polina Cherkasova  - (#62)

lints (https://github.com/dart-lang/lints/compare/17276ec..72f107a):
  72f107a  2023-05-15  Devon Carew  blast_repo fixes (#120)
  6732fbc  2023-05-15  Devon Carew  blast_repo fixes (#119)

Change-Id: Ibbb1fcc530da01653fe325bdcf77f1c764887a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303783
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Aug 23, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/dfeda1a..f777da7):
  f777da7  2023-08-22  Devon Carew  updates to the label normalization tool (#151)
  73a3464  2023-08-04  Moritz  Add permissions to `post_summaries.yaml` (#149)

mockito (https://github.com/dart-lang/mockito/compare/e54a006..70aabfc):
  70aabfc  2023-08-23  Copybara-Service  Merge pull request #686 from parlough:fix/example-analysis-errors
  9737d71  2023-08-15  Parker Lougheed  Fix analysis errors in example directory

tools (https://github.com/dart-lang/tools/compare/2be6c2e..e5ce42a):
  e5ce42a  2023-08-22  Jonas Finnemann Jensen  Support optional packageUri (#148)
  1c46390  2023-08-21  Kenzie Davisson  Improve exception messages for `ExpectJson` extension (#147)

webdriver (https://github.com/google/webdriver.dart/compare/d0f78d0..20ec47f):
  20ec47f  2023-08-21  sigmundch  Add content-type to async xhr request headers. (#277)

Change-Id: If6483e07c9d2a3670d2a9043bd56f40965e25c3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322362
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Sep 1, 2023
…li_util, clock, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, http, lints, logging, markdown, matcher, mime, native, path, pool, shelf, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, tools, typed_data, watcher, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/b65622a..75efa6c):
  75efa6c  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#250)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c29d162..f950bbf):
  f950bbf  2023-08-31  Parker Lougheed  Regenerate worker protocol protos to add constructors and comments (#78)
  9b4c6a0  2023-08-30  Parker Lougheed  Update e2e_test dependencies (#79)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/303635d..f255921):
  f255921  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#50)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/27ec600..1f69393):
  1f69393  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#48)

cli_util (https://github.com/dart-lang/cli_util/compare/9b7ce78..44118e3):
  44118e3  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#88)

clock (https://github.com/dart-lang/clock/compare/263e508..1e75f08):
  1e75f08  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#55)

convert (https://github.com/dart-lang/convert/compare/79ee174..c058c8f):
  c058c8f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#86)

crypto (https://github.com/dart-lang/crypto/compare/8b704c6..1e26879):
  1e26879  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#151)

csslib (https://github.com/dart-lang/csslib/compare/7e91228..bd30a1a):
  bd30a1a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#188)

dartdoc (https://github.com/dart-lang/dartdoc/compare/5fda5eb..695b218):
  695b218c  2023-08-30  Sam Rawlins  Tidy Category: (#3488)
  b26af96f  2023-08-30  Sam Rawlins  Tidy up library exports (#3487)
  be35cb00  2023-08-29  Devon Carew  Update dependabot.yaml (#3486)
  649bb8d2  2023-08-29  Sam Rawlins  Migrate to create_api_docs.dart (#3482)

ecosystem (https://github.com/dart-lang/ecosystem/compare/f777da7..89e58de):
  89e58de  2023-09-01  Hossein Yousefi  also install flutter on validate (#160)
  f95d0f2  2023-09-01  Hossein Yousefi  Add use-flutter arg to validate (#159)
  8743a9d  2023-09-01  Moritz  Pass a parameter for Flutter `firehose` support (#158)
  54d1628  2023-08-31  Moritz  Setup Flutter in publish workflow (#157)
  8fa89c6  2023-08-31  Moritz  Add flutter support (#155)
  65817bf  2023-08-29  Moritz  Switch to Pub API (#152)

ffi (https://github.com/dart-lang/ffi/compare/e2c01a9..d36e05a):
  d36e05a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#208)

fixnum (https://github.com/dart-lang/fixnum/compare/00fa120..87ed065):
  87ed065  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#114)

http (https://github.com/dart-lang/http/compare/cad7d60..7fb6fd6):
  7fb6fd6  2023-08-31  Brian Quinlan  Clarify how to set the body without a content type header (#1014)

lints (https://github.com/dart-lang/lints/compare/54cd7a0..da44af3):
  da44af3  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#144)

logging (https://github.com/dart-lang/logging/compare/5214987..bcaad0f):
  bcaad0f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#147)

markdown (https://github.com/dart-lang/markdown/compare/56e75df..6cfd6f1):
  6cfd6f1  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#554)
  52be591  2023-08-30  Parker Lougheed  Fix a few more lints, no longer ignore line length (#552)

matcher (https://github.com/dart-lang/matcher/compare/ce8f409..80910d6):
  80910d6  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#227)

mime (https://github.com/dart-lang/mime/compare/799b398..37ef637):
  37ef637  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#104)

native (https://github.com/dart-lang/native/compare/5a1361b..a2dfedc):
  a2dfedc  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#117)
  8dfb0d2  2023-09-01  dependabot[bot]  Bump nttld/setup-ndk from 1.2.0 to 1.3.1 (#118)

path (https://github.com/dart-lang/path/compare/7c2324b..96d9183):
  96d9183  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#150)

pool (https://github.com/dart-lang/pool/compare/7700102..a5bee35):
  a5bee35  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#73)

shelf (https://github.com/dart-lang/shelf/compare/73edd2b..2926f76):
  2926f76  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#376)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/16e54fd..196d7bf):
  196d7bf  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#41)

sse (https://github.com/dart-lang/sse/compare/8cc5b11..eeb2588):
  eeb2588  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#87)
  2bb1a6e  2023-09-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.1.1 to 2.2.0 (#88)

stack_trace (https://github.com/dart-lang/stack_trace/compare/4ddd86d..bcf2a0b):
  bcf2a0b  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#140)

stream_channel (https://github.com/dart-lang/stream_channel/compare/e54234f..0ce7ab6):
  0ce7ab6  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#94)

string_scanner (https://github.com/dart-lang/string_scanner/compare/413b57a..da9142c):
  da9142c  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#62)

term_glyph (https://github.com/dart-lang/term_glyph/compare/423700a..1b28285):
  1b28285  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#41)

test (https://github.com/dart-lang/test/compare/d0fc4bd..27dcae1):
  27dcae11  2023-09-01  dependabot[bot]  Bump github/codeql-action from 2.21.2 to 2.21.5 (#2086)
  cf0a0a73  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#2085)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/36d8617..030193d):
  030193d  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#55)

test_process (https://github.com/dart-lang/test_process/compare/b360784..2a6ee23):
  2a6ee23  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#47)

tools (https://github.com/dart-lang/tools/compare/b72fae8..2c8cbd6):
  2c8cbd6  2023-09-01  Jonas Finnemann Jensen  Extension discovery 2.0.0 (#156)
  3e12c2e  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#157)
  0f28f80  2023-08-28  Kenzie Davisson  Prepare extension_discovery for 1.0.1 release (#154)

typed_data (https://github.com/dart-lang/typed_data/compare/a20be90..80e8943):
  80e8943  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#72)

watcher (https://github.com/dart-lang/watcher/compare/7457413..1aed03e):
  1aed03e  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#149)

yaml (https://github.com/dart-lang/yaml/compare/7930148..ae00187):
  ae00187  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#150)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/87dcf31..4a9734d):
  4a9734d  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#56)
  83f9033  2023-07-01  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.5.3 (#54)

Change-Id: Ie6b9d9ef138730b98e9df8cbb31c6cc330ada9f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Sep 14, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/e96fbdb..babf5d1):
  babf5d1  2023-09-13  Devon Carew  add additional lints to dart_flutter_team_lints (#167)
  7740bef  2023-09-13  Moritz  Write comments on forks for `firehose` (#165)

http (https://github.com/dart-lang/http/compare/de19214..e19094a):
  e19094a  2023-09-14  Brian Quinlan  Use efficient operations when copying bytes between Dart and Java (#1019)
  d7e4375  2023-09-13  Parker Lougheed  Cleanup `package:http` utils (#1011)
  eafbbb0  2023-09-12  Brian Quinlan  Separate the cronet callbacks from the `send` method (#1017)
  2cbb703  2023-09-12  Brian Quinlan  Switch `cronet_http` to use jnigen (#1016)

native (https://github.com/dart-lang/native/compare/bbcbc1f..7faf62c):
  7faf62c  2023-09-14  Gabriel Terwesten  Add `includes`, `flags`, `std`, `language`, `cppLinkStdLib` options (#125)

shelf (https://github.com/dart-lang/shelf/compare/2926f76..e2a02b7):
  e2a02b7  2023-09-13  Kevin Moore  Move to latest pkg:dart_flutter_team_lints, bump min sdk to Dart 3 (#378)

tools (https://github.com/dart-lang/tools/compare/fa01f9b..1512f3d):
  1512f3d  2023-09-13  Elias Yishak  Add Fake Analytics instance that uses list to save events sent (#149)

webdev (https://github.com/dart-lang/webdev/compare/6b21ecf..501ccc2):
  501ccc28  2023-09-12  Elliott Brooks  Update DCM triggers to match Dart DevTools (#2230)

Change-Id: Ic3dc1924da48454a28e4c0d8705244ac1565e74a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325967
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 4, 2023
…ctor, browser_launcher, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/5a4e16f..df9b428):
  df9b428  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#256)
  892f013  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#257)

async (https://github.com/dart-lang/async/compare/75efa6c..def4482):
  def4482  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#253)
  a0ca552  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#252)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/159e671..b1b6a66):
  b1b6a66  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#82)
  bb9e48d  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#81)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/7d0d28e..59aea95):
  59aea95  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#94)
  e3f6207  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#93)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/f255921..9431e01):
  9431e01  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#51)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/1f69393..25bc94a):
  25bc94a  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#50)

cli_util (https://github.com/dart-lang/cli_util/compare/44118e3..9e48f0d):
  9e48f0d  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#90)

clock (https://github.com/dart-lang/clock/compare/1e75f08..200a020):
  200a020  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#56)
  8a2b550  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#57)

collection (https://github.com/dart-lang/collection/compare/91afde4..d27bfaf):
  d27bfaf  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#314)
  5d568ae  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#313)

convert (https://github.com/dart-lang/convert/compare/c058c8f..140b2f0):
  140b2f0  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#87)

crypto (https://github.com/dart-lang/crypto/compare/1e26879..b38dd62):
  b38dd62  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153)

csslib (https://github.com/dart-lang/csslib/compare/bd30a1a..f6b68dd):
  f6b68dd  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#190)
  4b1ee3f  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#189)

dartdoc (https://github.com/dart-lang/dartdoc/compare/a3cfdc4..59947b1):
  59947b14  2023-09-25  Sam Rawlins  Do not hide stacktrace of DartdocFailures (#3505)
  d95af5c7  2023-09-25  dependabot[bot]  Bump actions/checkout from 4.0.0 to 4.1.0 (#3506)

ecosystem (https://github.com/dart-lang/ecosystem/compare/3da2dd3..dcbd2ee):
  dcbd2ee  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#184)
  3006120  2023-10-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#183)
  69334aa  2023-10-01  dependabot[bot]  Bump actions/upload-artifact (#181)
  3dd6c69  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#185)
  2c5523c  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#182)
  5b7d3fd  2023-09-28  Devon Carew  update package:dart_flutter_team_lints to use the beta package:lints (#179)
  297e63e  2023-09-28  Devon Carew  fix an issue validating pre-release git publishing tags (#180)
  1154183  2023-09-28  Moritz  Check for `DO_NOT_SUBMIT` strings. (#178)
  bc2dd27  2023-09-28  Moritz  Add api tool call for testing (#153)
  eb8e398  2023-09-27  Moritz  Do not fail `publish` on forks (#177)
  f40a4eb  2023-09-25  Devon Carew  improve support for '-dev' and '-wip' package versions (#173)

ffi (https://github.com/dart-lang/ffi/compare/d36e05a..ee70dd4):
  ee70dd4  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#214)

fixnum (https://github.com/dart-lang/fixnum/compare/87ed065..ef0a587):
  ef0a587  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#115)

glob (https://github.com/dart-lang/glob/compare/9c1996f..0046533):
  0046533  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#83)
  f6ebc74  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#84)

html (https://github.com/dart-lang/html/compare/a1b193e..49e2c8e):
  49e2c8e  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#228)
  fb2de8a  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#227)

http (https://github.com/dart-lang/http/compare/1251619..88ec75e):
  88ec75e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3 to 4 (#1025)
  08143d1  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#1024)
  2c99da1  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#1023)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/9d62ea3..03041aa):
  03041aa  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#59)
  5efaa07  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#58)

http_parser (https://github.com/dart-lang/http_parser/compare/d2d03e7..c557f57):
  c557f57  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#78)
  a629fd6  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#79)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/50a3786..0521afb):
  0521afb  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#104)
  4782145  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103)

lints (https://github.com/dart-lang/lints/compare/b044aca..140c802):
  140c802  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#158)
  624a09d  2023-09-28  Devon Carew  add dangling_library_doc_comments, remove prefer_void_to_null (#157)
  296efaf  2023-09-28  Devon Carew  remove no_wildcard_variable_uses; improve testing (#156)
  c266a04  2023-09-26  Devon Carew  rev to 3.0.0-beta in preparation for publishing (#153)

logging (https://github.com/dart-lang/logging/compare/bcaad0f..642ed21):
  642ed21  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#149)
  287f4cb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#148)

markdown (https://github.com/dart-lang/markdown/compare/6cfd6f1..ae766d5):
  ae766d5  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#556)

matcher (https://github.com/dart-lang/matcher/compare/80910d6..11daad9):
  11daad9  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#229)

mime (https://github.com/dart-lang/mime/compare/37ef637..f3b9c49):
  f3b9c49  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#105)

mockito (https://github.com/dart-lang/mockito/compare/097e563..610c3dc):
  610c3dc  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#699)
  73930cd  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#698)

native (https://github.com/dart-lang/native/compare/be4aaf7..22500ea):
  22500ea  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#144)
  5bfc7ff  2023-10-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#145)
  0b7885a  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#143)

package_config (https://github.com/dart-lang/package_config/compare/ae7ad83..100533d):
  100533d  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#141)
  a4b474a  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#142)

path (https://github.com/dart-lang/path/compare/96d9183..abcf38c):
  abcf38c  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#151)

pool (https://github.com/dart-lang/pool/compare/a5bee35..4bcc7de):
  4bcc7de  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#75)

pub_semver (https://github.com/dart-lang/pub_semver/compare/f0be74a..8e5a58f):
  8e5a58f  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#93)
  81da7c8  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#92)

shelf (https://github.com/dart-lang/shelf/compare/4851978..c15fc6f):
  c15fc6f  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#386)
  e47c00e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#384)
  b9c898e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#385)
  9b96b9b  2023-09-26  Michael Thomsen  Add backend tag in pubspec.yaml (#381)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/196d7bf..73d449c):
  73d449c  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#42)
  2c4840e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#43)

source_maps (https://github.com/dart-lang/source_maps/compare/eb3d40a..fc6aa16):
  fc6aa16  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#83)
  dfca7d5  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#82)

source_span (https://github.com/dart-lang/source_span/compare/48d0f57..92e50bf):
  92e50bf  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#102)
  c212afa  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103)

sse (https://github.com/dart-lang/sse/compare/eeb2588..606387e):
  606387e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#89)

stack_trace (https://github.com/dart-lang/stack_trace/compare/bcf2a0b..1c36cd7):
  1c36cd7  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#143)

stream_channel (https://github.com/dart-lang/stream_channel/compare/0ce7ab6..bf74065):
  bf74065  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#95)

string_scanner (https://github.com/dart-lang/string_scanner/compare/da9142c..616424c):
  616424c  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#63)

term_glyph (https://github.com/dart-lang/term_glyph/compare/1b28285..19abf84):
  19abf84  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#42)

test (https://github.com/dart-lang/test/compare/8191a35..367aa39):
  367aa397  2023-10-02  Jacob MacDonald  release test_core and test (#2112)
  672be9d7  2023-10-02  Ben Konyi  Update package:vm_service to 12.0.0 (#2110)
  de324cc7  2023-10-01  dependabot[bot]  Bump github/codeql-action from 2.21.5 to 2.21.9 (#2106)
  31b94dbb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#2105)
  d56c2150  2023-10-01  dependabot[bot]  Bump actions/cache from 3.0.11 to 3.3.2 (#2108)
  b93f1b50  2023-10-01  dependabot[bot]  Bump actions/upload-artifact from 3.1.2 to 3.1.3 (#2109)
  a077b673  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#2107)
  566d70a2  2023-09-26  Lau Ching Jun  Filter test by line when kernel is compiled with --filesystem-scheme. (#2101)
  7ec1bbf5  2023-09-25  Nate Bosch  Drop support for legacy iframe communication (#2099)
  d3f4b368  2023-09-25  Nate Bosch  Tighten types in test utils (#2097)
  9d997910  2023-09-25  Nate Bosch  Add types to Browser implementation url arguments (#2096)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/030193d..55b5eac):
  55b5eac  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#57)
  c2ba59e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#56)

test_process (https://github.com/dart-lang/test_process/compare/2a6ee23..5efd0bf):
  5efd0bf  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#49)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/45c57d6..8593eb1):
  8593eb1  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#52)
  4857e22  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#53)

tools (https://github.com/dart-lang/tools/compare/3c248df..f318c80):
  f318c80  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#177)
  0480655  2023-10-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#176)
  73583e8  2023-09-29  Devon Carew  update package:cli_config to the latest package:dart_flutter_team_lints (#171)
  b293897  2023-09-28  Devon Carew  update to the latest package:dart_flutter_team_lints (#173)
  242fdb5  2023-09-28  Devon Carew  update to the latest package:dart_flutter_team_lints (#172)
  a51f779  2023-09-28  Elias Yishak  Use constant for no op client id (#168)
  e83caee  2023-09-27  Moritz  Allow `publish` to write comments on forks (#169)

typed_data (https://github.com/dart-lang/typed_data/compare/80e8943..d1c15ed):
  d1c15ed  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#73)
  e13af06  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#74)

usage (https://github.com/dart-lang/usage/compare/7b12d51..d7d2964):
  d7d2964  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#198)
  920c6e8  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#199)

watcher (https://github.com/dart-lang/watcher/compare/1aed03e..c480e2d):
  c480e2d  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#151)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/af945f1..364013d):
  364013d  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#286)
  50dada7  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#285)

webdev (https://github.com/dart-lang/webdev/compare/3078f48..7c2c2d7):
  7c2c2d70  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 4.1.0 (#2245)
  7739a114  2023-09-26  Elliott Brooks  Refactor tests to handle new `ToolConfiguration` (#2243)
  4e350cde  2023-09-21  Elliott Brooks  Fix issue with the inspector panel in the Dart Debug Extension (#2242)
  bbddba29  2023-09-21  Elliott Brooks  Prepare the Dart Debug Extension for release to version 1.36 (#2241)
  cc5db13f  2023-09-21  Elliott Brooks  Rename plainUri to debugUri and send it to the extension (#2238)
  48fc725f  2023-09-20  Elliott Brooks  Add a new workspaceName parameter to DWDS on start up (#2237)
  d2dae560  2023-09-20  Elliott Brooks  Refactor: Update the parameters for `DWDS.start` (#2231)

yaml (https://github.com/dart-lang/yaml/compare/ae00187..9f0d649):
  9f0d649  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153)
  8e70ffb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#152)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/4a9734d..a7e7fba):
  a7e7fba  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#58)
  f33e3d0  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#59)
  8a380e8  2023-09-28  Sigurd Meldgaard  Change AliasError to AliasException (#57)

Change-Id: I22f88e36d2eceb03495dabcf1265e9043364e0bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329260
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable
Projects
None yet
Development

No branches or pull requests

1 participant