Benchmark smoke test fails on IE

[kasperl]

After r8332.

[efortuna]

We cannot run any browser performance tests in IE when this is broken. I hope we can fix this ASAP.

[rakudrama]

I added a comment to https://chromiumcodereview.appspot.com//10544026 (r8332).

Basically: use getTypeNameOf only as a last resort, and if that does not work, use the string 'unknown'.

[kasperl]

Set owner to @kasperl.
Added Accepted label.

[kasperl]

I'm having a hard time reproducing this locally.

[efortuna]

I'm able to reproduce it okay on my machine. I ran
tools/test.py -m release -c dart2js -r ie benchmark_smoke and got the following output:

Test configuration: dart2js_ie_release_ia32
[00:00 | --% | + 0 | - 0]
FAILED: dart2js-ie release_ia32 benchmark_smoke/benchmark_smoke_test
Expected: pass
Actual: fail

stdout:
<table class="unittest-table"><tbody><tr><td class="unittest-fail" colSpan="3">FAIL</td></tr> <
tr>
        <td>1</td>
        <td class="unittest-error">ERROR</td>
        <td>Expectation: performanceTesting. Caught Instance of 'Error'</td>
      </tr><tr><td></td><td colSpan="2"><pre></pre></td></tr> <tr><td colSpan="3">Total
            <span class="unittest-pass">0 passed</span>,
            <span class="unittest-fail">0 failed</span>
            <span class="unittest-error">
            1 errors</span>
          </td></tr></tbody></table></body></html

Compilation command: ReleaseIA32/dart2js.bat --verbose --out=C:/Users/efortuna/dart/ReleaseIA32/gene
rated_tests/dart2js-ie/tests_benchmark_smoke_benchmark_smoke_test/test.js C:/Users/efortuna/dart/tes
ts/benchmark_smoke/benchmark_smoke_test.dart

Command line: python C:/Users/efortuna/dart/tools/testing/run_selenium.py --browser=ie --timeout=238
 --out=C:/Users/efortuna/dart/ReleaseIA32/generated_tests/dart2js-ie/tests_benchmark_smoke_benchmark
_smoke_test/../C__Users_efortuna_dart_tests_benchmark_smoke_benchmark_smoke_test.dartdart2js-ie.html

[00:07 | 100% | + 0 | - 1]

FAILED: dart2js-ie release_ia32 benchmark_smoke/benchmark_smoke_test
Expected: pass
Actual: fail

stdout:
<table class="unittest-table"><tbody><tr><td class="unittest-fail" colSpan="3">FAIL</td></tr> <
tr>
        <td>1</td>
        <td class="unittest-error">ERROR</td>
        <td>Expectation: performanceTesting. Caught Instance of 'Error'</td>
      </tr><tr><td></td><td colSpan="2"><pre></pre></td></tr> <tr><td colSpan="3">Total
            <span class="unittest-pass">0 passed</span>,
            <span class="unittest-fail">0 failed</span>
            <span class="unittest-error">
            1 errors</span>
          </td></tr></tbody></table></body></html

Compilation command: ReleaseIA32/dart2js.bat --verbose --out=C:/Users/efortuna/dart/ReleaseIA32/gene
rated_tests/dart2js-ie/tests_benchmark_smoke_benchmark_smoke_test/test.js C:/Users/efortuna/dart/tes
ts/benchmark_smoke/benchmark_smoke_test.dart

Command line: python C:/Users/efortuna/dart/tools/testing/run_selenium.py --browser=ie --timeout=238
 --out=C:/Users/efortuna/dart/ReleaseIA32/generated_tests/dart2js-ie/tests_benchmark_smoke_benchmark
_smoke_test/../C__Users_efortuna_dart_tests_benchmark_smoke_benchmark_smoke_test.dartdart2js-ie.html

[00:07 | 100% | + 0 | - 1]

Let me know if I can provide more help for you to set this up locally to reproduce.

[kasperl]

I will take another look. Thanks, Emily!

[kasperl]

Fixed in r9417.

---

Added Fixed label.