-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difference dartc, dart_bin #243
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Comments
This comment was originally written by zundel@google.com It looks to me like there should be a comma after 'a'. In spec 0.3 section 6.2 specifies a comma formalParameterList: So I'm assigning over to the VM for them to take a look |
Fixed in r973. Added Fixed label. |
DartBot
added
Type-Defect
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
labels
Oct 31, 2011
nex3
pushed a commit
that referenced
this issue
Aug 31, 2016
See rendered markdown here: https://github.com/dart-lang/dev_compiler/blob/strong/STRONGMODE.md Fixes #243 R=jmesserly@google.com, leafp@google.com Review URL: https://codereview.chromium.org/1218993004.
This was referenced Oct 29, 2020
copybara-service bot
pushed a commit
that referenced
this issue
May 19, 2022
Changes: ``` > git log --format="%C(auto) %h %s" ff5ccb1..e1a9ad6 https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/e1a9ad6 Update pubspec.yaml (#249) https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/ab84c3c Fix CI for pub changes (#246) https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/b51f67a Replace placeholder of copyright owner and year. https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/bad7678 Migrate to pkg:lints https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/d32c19e Fix formatting and analysis issues https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/a0fad2f GitHub Sync (#243) https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/31c990b Update ci.yaml (#241) https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/bd43501 fix lints ``` Diff: https://dart.googlesource.com/external/github.com/google/webdriver.dart.git/+/ff5ccb1522edf4bed578ead4d65e0cbc1f2c4f02~..e1a9ad671ee82e05eee463f922a34585ed2d2f15/ Change-Id: Id348c8605833effc02e6afcccff5fb27f4f68406 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245227 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Kevin Moore <kevmoo@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 15, 2023
…ctor, browser_launcher, file, mockito, tools, dartdoc Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc to 0cf21c15d7346a81838bd1c56677d88d690887f5 args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2): f0f6cd2 2023-05-12 Devon Carew blast_repo fixes (#243) async (https://github.com/dart-lang/async/compare/0f368d3..d744058): d744058 2023-05-12 Devon Carew blast_repo fixes (#242) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f): d9b389f 2023-05-12 Devon Carew blast_repo fixes (#73) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4): e717ad4 2023-05-12 Devon Carew blast_repo fixes (#90) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..23e08e0): 23e08e0 2023-05-12 Devon Carew blast_repo fixes (#47) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315): 40e4315 2023-05-12 Devon Carew blast_repo fixes (#45) file (https://github.com/google/file.dart/compare/e90e5ed..f05f5db): f05f5db 2023-05-15 James D. Lin Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again (#217) f2f3076 2023-05-12 Ross Wang MemoryFileSystem addStream onError (#220) 5e76f74 2023-05-12 James D. Lin Fix MemoryFileSystem to treat an empty path as non-existent (#213) 7941466 2023-05-12 James D. Lin Make `FileSystem.isLink` actually work (#214) mockito (https://github.com/dart-lang/mockito/compare/51a7728..b14d571): b14d571 2023-05-15 Googler Fix for InvalidType tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca): 49da4ca 2023-05-12 Polina Cherkasova Add memory events. (#92) Change-Id: I582320bb68ff5f48e9969cef906073e25ad6b875 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303380 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 16, 2023
…ean_selector, browser_launcher, file, mockito, tools, dartdoc" This reverts commit e3ba855. Reason for revert: b/282823291, breaks Flutter tests at least on Android. Original change's description: > [deps] rev args, async, bazel_worker, benchmark_harness, boolean_selector, browser_launcher, file, mockito, tools, dartdoc > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > dartdoc to 0cf21c15d7346a81838bd1c56677d88d690887f5 > > args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2): > f0f6cd2 2023-05-12 Devon Carew blast_repo fixes (#243) > > async (https://github.com/dart-lang/async/compare/0f368d3..d744058): > d744058 2023-05-12 Devon Carew blast_repo fixes (#242) > > bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f): > d9b389f 2023-05-12 Devon Carew blast_repo fixes (#73) > > benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4): > e717ad4 2023-05-12 Devon Carew blast_repo fixes (#90) > > boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..23e08e0): > 23e08e0 2023-05-12 Devon Carew blast_repo fixes (#47) > > browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315): > 40e4315 2023-05-12 Devon Carew blast_repo fixes (#45) > > file (https://github.com/google/file.dart/compare/e90e5ed..f05f5db): > f05f5db 2023-05-15 James D. Lin Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again (#217) > f2f3076 2023-05-12 Ross Wang MemoryFileSystem addStream onError (#220) > 5e76f74 2023-05-12 James D. Lin Fix MemoryFileSystem to treat an empty path as non-existent (#213) > 7941466 2023-05-12 James D. Lin Make `FileSystem.isLink` actually work (#214) > > mockito (https://github.com/dart-lang/mockito/compare/51a7728..b14d571): > b14d571 2023-05-15 Googler Fix for InvalidType > > tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca): > 49da4ca 2023-05-12 Polina Cherkasova Add memory events. (#92) > > Change-Id: I582320bb68ff5f48e9969cef906073e25ad6b875 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303380 > Reviewed-by: Konstantin Shcheglov <scheglov@google.com> > Commit-Queue: Devon Carew <devoncarew@google.com> Change-Id: Ifc2aa278a47a4060f2be28c1950084eb0c2de812 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303720 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ilya Yanok <yanok@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 16, 2023
…ctor, browser_launcher, characters, cli_util, clock, collection, crypto, dartdoc, leak_tracker, lints Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2): f0f6cd2 2023-05-12 Devon Carew blast_repo fixes (#243) async (https://github.com/dart-lang/async/compare/0f368d3..d744058): d744058 2023-05-12 Devon Carew blast_repo fixes (#242) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f): d9b389f 2023-05-12 Devon Carew blast_repo fixes (#73) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4): e717ad4 2023-05-12 Devon Carew blast_repo fixes (#90) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..3a1c982): 3a1c982 2023-05-15 Devon Carew Update README.md (#48) 23e08e0 2023-05-12 Devon Carew blast_repo fixes (#47) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315): 40e4315 2023-05-12 Devon Carew blast_repo fixes (#45) characters (https://github.com/dart-lang/characters/compare/2af6783..3ef8883): 3ef8883 2023-05-15 Devon Carew blast_repo fixes (#82) cli_util (https://github.com/dart-lang/cli_util/compare/7234f17..5a49947): 5a49947 2023-05-15 Devon Carew blast_repo fixes (#83) clock (https://github.com/dart-lang/clock/compare/6b9df3e..fe85908): fe85908 2023-05-15 Devon Carew blast_repo fixes (#51) collection (https://github.com/dart-lang/collection/compare/6abff47..db2da48): db2da48 2023-05-15 Devon Carew blast_repo fixes (#288) crypto (https://github.com/dart-lang/crypto/compare/4e9dde1..216931a): 216931a 2023-05-15 Devon Carew blast_repo fixes (#149) dartdoc (https://github.com/dart-lang/dartdoc/compare/d01ddc5..2952f6b): 2952f6bf 2023-05-16 Sam Rawlins Simplify ToolConfiguration and other options code (#3414) 0cf21c15 2023-05-12 Janice Collins Extract fileName / fileType from ModelElement, LibraryContainer into FileStructure (#3413) 2ae78bcc 2023-05-12 Sam Rawlins Split sidebars out into separate HTML files (#3384) f00d0443 2023-05-11 Janice Collins Housekeeping: language version 3.0, analyzer deprecations, pubspec update (#3412) 370477d2 2023-05-10 dependabot[bot] Bump github/codeql-action from 2.3.2 to 2.3.3 (#3410) e8c5de44 2023-05-08 Janice Collins Begin extracting file structure information from ModelElement (#3408) 24af8a11 2023-05-04 Janice Collins Add a hideConstantImplementations dartdoc directive (#3398) 078d42fd 2023-05-03 Janice Collins Change language feature wording based on review in #3401 (#3405) 31088c1b 2023-05-03 dependabot[bot] Bump github/codeql-action from 2.2.12 to 2.3.2 (#3403) 60055b4e 2023-05-03 Sam Rawlins Update validate-sdk-docs task to allow 20 libs (#3404) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/bc7f604..8ae200a): 8ae200a 2023-05-15 Polina Cherkasova - (#62) lints (https://github.com/dart-lang/lints/compare/17276ec..72f107a): 72f107a 2023-05-15 Devon Carew blast_repo fixes (#120) 6732fbc 2023-05-15 Devon Carew blast_repo fixes (#119) Change-Id: Ibbb1fcc530da01653fe325bdcf77f1c764887a81 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303783 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 19, 2023
…, http_parser, leak_tracker, logging, markdown, matcher, mockito, shelf, source_map_stack_trace, tools Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/d744058..96c29d0): 96c29d0 2023-05-17 Goddchen docs: fix typo in CancelableOperation.fromFuture(...) docs (#243) csslib (https://github.com/dart-lang/csslib/compare/923edf0..b2b9b55): b2b9b55 2023-05-18 Devon Carew address a regression in the compact output format (#183) 1ff82fd 2023-05-15 Devon Carew blast_repo fixes (#181) 35bef7f 2023-05-11 Nate Bosch Simplify TopLevelIncludes visitor (#180) c4e904c 2023-05-10 Devon Carew rev for publishing (#179) c9e47d0 2023-05-10 Kevin Moore Require Dart 2.19, latest lints, skin hanging test (#175) 3976e6f 2023-05-10 Devon Carew address an issue parsing font names (#168) a337a9a 2023-05-10 Devon Carew fixed CssPrinter pretty print indent levels (#169) fixnum (https://github.com/dart-lang/fixnum/compare/006a130..d9b9a2a): d9b9a2a 2023-05-17 Devon Carew blast_repo fixes (#112) glob (https://github.com/dart-lang/glob/compare/46403be..30f6aba): 30f6aba 2023-05-17 Devon Carew blast_repo fixes (#77) html (https://github.com/dart-lang/html/compare/593d6f6..92eacab): 92eacab 2023-05-17 Devon Carew blast_repo fixes (#216) http (https://github.com/dart-lang/http/compare/fb3b4be..d845560): d845560 2023-05-17 Devon Carew blast_repo fixes (#933) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/d1fffed..a209cd5): a209cd5 2023-05-17 Devon Carew blast_repo fixes (#55) http_parser (https://github.com/dart-lang/http_parser/compare/5a33f5f..1ef3e56): 1ef3e56 2023-05-17 Devon Carew blast_repo fixes (#73) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/8ae200a..571c24a): 571c24a 2023-05-18 Polina Cherkasova Delete generate_diagrams.yaml (#67) f2029b6 2023-05-18 Devon Carew blast_repo fixes (#66) 474fd4f 2023-05-18 Polina Cherkasova Separate testing. (#65) 92a0b48 2023-05-17 Polina Cherkasova Fixes to support G3. (#64) logging (https://github.com/dart-lang/logging/compare/b75cba7..fa2486d): fa2486d 2023-05-18 Desislava Stefanova Logger `onLevelChanged` notification (#138) markdown (https://github.com/dart-lang/markdown/compare/6db8fc1..b951454): b951454 2023-05-18 Devon Carew blast_repo fixes (#542) a714d95 2023-05-17 Zhiguang Chen Fix delimiter row matching pattern for tables (#540) matcher (https://github.com/dart-lang/matcher/compare/4dfd9ad..7e10117): 7e10117 2023-05-18 Devon Carew blast_repo fixes (#224) mockito (https://github.com/dart-lang/mockito/compare/3fadd2d..28f174f): 28f174f 2023-05-17 Ilya Yanok Only check formatting with the stable SDK shelf (https://github.com/dart-lang/shelf/compare/79e3cee..8793687): 8793687 2023-05-18 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.3 (#353) 2f1aefb 2023-05-18 Devon Carew blast_repo fixes (#351) e1ca05d 2023-05-18 Devon Carew Update no-response.yml (#349) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/09715f9..b83af01): b83af01 2023-05-18 Devon Carew blast_repo fixes (#39) tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca): 49da4ca 2023-05-12 Polina Cherkasova Add memory events. (#92) Change-Id: I5cd1277e6df1d72f69569090d9a2381a2b81d5d0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304460 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
This issue was originally filed by karl.kr...@gmail.com
I've found a minor difference between dartc accepted input and dart_bin:
krukow:~$ cat scratchpad/dartc_vs_vm.dart
f(a [b=42]) => b;
main () {print(f(1,2));}
krukow:
$ dart_bin scratchpad/dartc_vs_vm.dart$ dartc scratchpad/dartc_vs_vm.dart2
krukow:
scratchpad/dartc_vs_vm.dart/dartc_vs_vm.dart:2: Unexpected token '[' (expected 'IDENTIFIER')
1:
2: f(a [b=42]) => b;
scratchpad/dartc_vs_vm.dart/dartc_vs_vm.dart:2: Unexpected token 'IDENTIFIER' (expected ',')
1:
2: f(a [b=42]) => b;
scratchpad/dartc_vs_vm.dart/dartc_vs_vm.dart:2: Unexpected token '=' (expected '{')
1:
2: f(a [b=42]) => b;
scratchpad/dartc_vs_vm.dart/dartc_vs_vm.dart:2: Unexpected token ']' (expected ';')
1:
2: f(a [b=42]) => b;
scratchpad/dartc_vs_vm.dart/dartc_vs_vm.dart:6:1: Unexpected token 'EOS'
Compilation failed with 5 problems.
The text was updated successfully, but these errors were encountered: