Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A 'return' in a generative constructor does not trigger a compile-time error #224

Closed
DartBot opened this issue Oct 25, 2011 · 2 comments
Closed
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@DartBot
Copy link

DartBot commented Oct 25, 2011

This issue was originally filed by ngeoffray@google.com


The following code (tests/language/src/ConstructorReturnNegativeTest) runs fine on the VM:

class A {
  A() { return null; }
}

main() {
  new A();
}

Instead it should trigger a compile-time error (see spec version 0.03, section 11.10).

@DartBot
Copy link
Author

DartBot commented Nov 3, 2011

This comment was originally written by @mhausner


Set owner to @mhausner.
Added Started label.

@DartBot
Copy link
Author

DartBot commented Nov 3, 2011

This comment was originally written by @mhausner


Fixed with CL 1161.


Added Fixed label.

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Nov 3, 2011
copybara-service bot pushed a commit that referenced this issue Jun 2, 2022
…criptor, stack_trace, usage, watcher

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/ceeba09..9710de6):
  9710de6  2022-04-19  Devon Carew  Update pubspec.yaml (#62)
  ec5905a  2022-03-20  Kevin Moore  Fix CI (#61)

collection (https://github.com/dart-lang/collection/compare/e1407da..69766da):
  69766da  2022-05-25  Nate Bosch  Add complexity bound on binary search methods (#239)
  5b43ad7  2022-04-08  Kevin Moore  Fix analysis issue with latest dev release (#236)
  e83c373  2022-04-08  Enrico Zamagni  fixed maxBy compare param signature (#224)
  c1a07e4  2022-04-08  Sandro Lovnički  Add a comment about NaN in min/max extensions (#234)
  2bbb27b  2022-03-07  Nate Bosch  Prepare to publish (#233)

mockito (https://github.com/dart-lang/mockito/compare/1e977a7..fcd6b28):
  fcd6b28  2022-05-16  srawlins  Release mockito 5.2.0
  2faf8f1  2022-05-16  srawlins  Import dart-lang/mockito#533
  0f8ed0c  2022-04-19  Devon Carew  Populate the pubspec 'repository' field.
  d399ca8  2022-05-13  fzyzcjy  Fix compile errors in Flutter 3.0
  948973e  2022-04-06  Samuel Rawlins  clarify docs for unsupportedMembers.
  b86c24d  2022-03-14  srawlins  Support `@GenerateMocks` annotations on `import` and `export` directives.
  c6971dd  2022-03-05  srawlins  Fix generation of methods with return type of `FutureOr<T>`.

pub_semver (https://github.com/dart-lang/pub_semver/compare/ea6c540..5c0b4bf):
  5c0b4bf  2022-03-07  Devon Carew  Update README.md (#65)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/ead23c1..5ed5d7f):
  5ed5d7f  2022-05-24  Nate Bosch  Move TestOn annotation to library level (#41)
  ecb2447  2022-05-03  Devon Carew  populate the repository field (#40)
  776a4c4  2022-03-02  dependabot[bot]  Bump actions/checkout from 2 to 3 (#39)
  d8eb6bd  2021-10-04  Kevin Moore  Migrate to pkg:lints, enable two disable lints (#38)

stack_trace (https://github.com/dart-lang/stack_trace/compare/5220580..17f09c2):
  17f09c2  2022-05-03  Devon Carew  Merge pull request #117 from dart-lang/repository_field
  a6403d0  2022-05-03  Devon Carew  switch to package:lints
  ae8b883  2022-05-03  Devon Carew  add markdown badges
  eed6081  2022-05-03  Devon Carew  populate the pubspec repository field
  46f6ee1  2022-02-01  Nate Bosch  Change a TODO to a permanent comment (#114)

usage (https://github.com/dart-lang/usage/compare/e85d575..79eef48):
  79eef48  2022-05-25  Devon Carew  refactor the github action (#177)
  f296352  2022-05-02  dependabot[bot]  Bump actions/checkout from 2 to 3 (#176)
  8852f1a  2022-05-02  Devon Carew  Update dependabot to watch github actions (#175)
  2d5b693  2022-04-26  Devon Carew  Update README.md (#174)
  2b2f3f8  2022-04-20  Devon Carew  Switch from homepage to repository in pubspec (#173)
  9b90d7c  2022-04-14  Devon Carew  Update dependabot.yaml (#172)

watcher (https://github.com/dart-lang/watcher/compare/f76997a..e00c0ea):
  e00c0ea  2022-01-19  Danny Tuppeny  Add/enable Windows tests (#124)


Change-Id: I0d48d3a7831040a18c996120cd51898e24215512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246725
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 21, 2022
args (https://github.com/dart-lang/args/compare/80d4abb..aaf671c):
  aaf671c  2022-10-20  Kevin Moore  Require Dart 2.18, update lints, update CI, add dependabot (#222)

async (https://github.com/dart-lang/async/compare/f3ed5f6..18a780e):
  18a780e  2022-10-20  Kevin Moore  Nit: fix analysis_options (#224)
  b6e7885  2022-10-20  Kevin Moore  Require Dart 2.18, latest lints, latest CI bits (#223)

lints (https://github.com/dart-lang/lints/compare/8294e56..16bdefe):
  16bdefe  2022-10-20  dependabot[bot]  Bump actions/checkout from 3.0.2 to 3.1.0 (#89)
  0fae4ee  2022-10-20  Devon Carew  update lint files docs (#88)

usage (https://github.com/dart-lang/usage/compare/9a98c89..fee1d9d):
  fee1d9d  2022-10-20  dependabot[bot]  Bump actions/checkout from 3.0.2 to 3.1.0 (#184)

webdev (https://github.com/dart-lang/webdev/compare/a02f073..81c5384):
  81c5384  2022-10-20  Nate Bosch  Migrate webdev tests to null safety (#1761)

Change-Id: I238d46cb5b24d64788862f06dc903a2cd2312725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265140
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
copybara-service bot pushed a commit that referenced this issue May 19, 2023
…, http_parser, leak_tracker, logging, markdown, matcher, mockito, shelf, source_map_stack_trace, tools

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/d744058..96c29d0):
  96c29d0  2023-05-17  Goddchen  docs: fix typo in CancelableOperation.fromFuture(...) docs (#243)

csslib (https://github.com/dart-lang/csslib/compare/923edf0..b2b9b55):
  b2b9b55  2023-05-18  Devon Carew  address a regression in the compact output format (#183)
  1ff82fd  2023-05-15  Devon Carew  blast_repo fixes (#181)
  35bef7f  2023-05-11  Nate Bosch  Simplify TopLevelIncludes visitor (#180)
  c4e904c  2023-05-10  Devon Carew  rev for publishing (#179)
  c9e47d0  2023-05-10  Kevin Moore  Require Dart 2.19, latest lints, skin hanging test (#175)
  3976e6f  2023-05-10  Devon Carew  address an issue parsing font names (#168)
  a337a9a  2023-05-10  Devon Carew  fixed CssPrinter pretty print indent levels (#169)

fixnum (https://github.com/dart-lang/fixnum/compare/006a130..d9b9a2a):
  d9b9a2a  2023-05-17  Devon Carew  blast_repo fixes (#112)

glob (https://github.com/dart-lang/glob/compare/46403be..30f6aba):
  30f6aba  2023-05-17  Devon Carew  blast_repo fixes (#77)

html (https://github.com/dart-lang/html/compare/593d6f6..92eacab):
  92eacab  2023-05-17  Devon Carew  blast_repo fixes (#216)

http (https://github.com/dart-lang/http/compare/fb3b4be..d845560):
  d845560  2023-05-17  Devon Carew  blast_repo fixes (#933)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/d1fffed..a209cd5):
  a209cd5  2023-05-17  Devon Carew  blast_repo fixes (#55)

http_parser (https://github.com/dart-lang/http_parser/compare/5a33f5f..1ef3e56):
  1ef3e56  2023-05-17  Devon Carew  blast_repo fixes (#73)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/8ae200a..571c24a):
  571c24a  2023-05-18  Polina Cherkasova  Delete generate_diagrams.yaml (#67)
  f2029b6  2023-05-18  Devon Carew  blast_repo fixes (#66)
  474fd4f  2023-05-18  Polina Cherkasova  Separate testing. (#65)
  92a0b48  2023-05-17  Polina Cherkasova  Fixes to support G3. (#64)

logging (https://github.com/dart-lang/logging/compare/b75cba7..fa2486d):
  fa2486d  2023-05-18  Desislava Stefanova  Logger `onLevelChanged` notification (#138)

markdown (https://github.com/dart-lang/markdown/compare/6db8fc1..b951454):
  b951454  2023-05-18  Devon Carew  blast_repo fixes (#542)
  a714d95  2023-05-17  Zhiguang Chen  Fix delimiter row matching pattern for tables (#540)

matcher (https://github.com/dart-lang/matcher/compare/4dfd9ad..7e10117):
  7e10117  2023-05-18  Devon Carew  blast_repo fixes (#224)

mockito (https://github.com/dart-lang/mockito/compare/3fadd2d..28f174f):
  28f174f  2023-05-17  Ilya Yanok  Only check formatting with the stable SDK

shelf (https://github.com/dart-lang/shelf/compare/79e3cee..8793687):
  8793687  2023-05-18  dependabot[bot]  Bump actions/labeler from 4.0.2 to 4.0.3 (#353)
  2f1aefb  2023-05-18  Devon Carew  blast_repo fixes (#351)
  e1ca05d  2023-05-18  Devon Carew  Update no-response.yml (#349)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/09715f9..b83af01):
  b83af01  2023-05-18  Devon Carew  blast_repo fixes (#39)

tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca):
  49da4ca  2023-05-12  Polina Cherkasova  Add memory events. (#92)

Change-Id: I5cd1277e6df1d72f69569090d9a2381a2b81d5d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

1 participant