-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve htmlconverter.py #112
Comments
This comment was originally written by jat@google.com If you care about the resulting compiled JS size, you should be compiling with --optimize that eliminates dead code and minifies identifiers. Removed Type-Defect label. |
This comment was originally written by jordonwi...@gmail.com I think a more important issue with htmlconverter.py is the time it takes to compile. It takes well more than 10 seconds on my dual-core laptop (probably more like 30), which is a hassle for development. |
This comment was originally written by zundel@google.com dartc is no longer used to generate JS. Added WontFix label. |
fixes #109, code coverage for SDK generation
Change-Id: I35efbe3a409516b386980d65befb4ac835483c2b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264160 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
…, http_parser, leak_tracker, logging, markdown, matcher, mockito, shelf, source_map_stack_trace, tools Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/d744058..96c29d0): 96c29d0 2023-05-17 Goddchen docs: fix typo in CancelableOperation.fromFuture(...) docs (#243) csslib (https://github.com/dart-lang/csslib/compare/923edf0..b2b9b55): b2b9b55 2023-05-18 Devon Carew address a regression in the compact output format (#183) 1ff82fd 2023-05-15 Devon Carew blast_repo fixes (#181) 35bef7f 2023-05-11 Nate Bosch Simplify TopLevelIncludes visitor (#180) c4e904c 2023-05-10 Devon Carew rev for publishing (#179) c9e47d0 2023-05-10 Kevin Moore Require Dart 2.19, latest lints, skin hanging test (#175) 3976e6f 2023-05-10 Devon Carew address an issue parsing font names (#168) a337a9a 2023-05-10 Devon Carew fixed CssPrinter pretty print indent levels (#169) fixnum (https://github.com/dart-lang/fixnum/compare/006a130..d9b9a2a): d9b9a2a 2023-05-17 Devon Carew blast_repo fixes (#112) glob (https://github.com/dart-lang/glob/compare/46403be..30f6aba): 30f6aba 2023-05-17 Devon Carew blast_repo fixes (#77) html (https://github.com/dart-lang/html/compare/593d6f6..92eacab): 92eacab 2023-05-17 Devon Carew blast_repo fixes (#216) http (https://github.com/dart-lang/http/compare/fb3b4be..d845560): d845560 2023-05-17 Devon Carew blast_repo fixes (#933) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/d1fffed..a209cd5): a209cd5 2023-05-17 Devon Carew blast_repo fixes (#55) http_parser (https://github.com/dart-lang/http_parser/compare/5a33f5f..1ef3e56): 1ef3e56 2023-05-17 Devon Carew blast_repo fixes (#73) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/8ae200a..571c24a): 571c24a 2023-05-18 Polina Cherkasova Delete generate_diagrams.yaml (#67) f2029b6 2023-05-18 Devon Carew blast_repo fixes (#66) 474fd4f 2023-05-18 Polina Cherkasova Separate testing. (#65) 92a0b48 2023-05-17 Polina Cherkasova Fixes to support G3. (#64) logging (https://github.com/dart-lang/logging/compare/b75cba7..fa2486d): fa2486d 2023-05-18 Desislava Stefanova Logger `onLevelChanged` notification (#138) markdown (https://github.com/dart-lang/markdown/compare/6db8fc1..b951454): b951454 2023-05-18 Devon Carew blast_repo fixes (#542) a714d95 2023-05-17 Zhiguang Chen Fix delimiter row matching pattern for tables (#540) matcher (https://github.com/dart-lang/matcher/compare/4dfd9ad..7e10117): 7e10117 2023-05-18 Devon Carew blast_repo fixes (#224) mockito (https://github.com/dart-lang/mockito/compare/3fadd2d..28f174f): 28f174f 2023-05-17 Ilya Yanok Only check formatting with the stable SDK shelf (https://github.com/dart-lang/shelf/compare/79e3cee..8793687): 8793687 2023-05-18 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.3 (#353) 2f1aefb 2023-05-18 Devon Carew blast_repo fixes (#351) e1ca05d 2023-05-18 Devon Carew Update no-response.yml (#349) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/09715f9..b83af01): b83af01 2023-05-18 Devon Carew blast_repo fixes (#39) tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca): 49da4ca 2023-05-12 Polina Cherkasova Add memory events. (#92) Change-Id: I5cd1277e6df1d72f69569090d9a2381a2b81d5d0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304460 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/4757339..e04a6b3): e04a6b30 2023-06-23 Sam Rawlins Remove grind_test; not important (#3453) ecosystem (https://github.com/dart-lang/ecosystem/compare/a2dac18..b1056e6): b1056e6 2023-06-13 Nate Bosch Allow prerelease suffix in CHANGELOG versions (#112) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/2149e5c..c75b0a7): c75b0a7 2023-06-23 Yii Chen make LeakTrackingConfiguration to const (#83) webdev (https://github.com/dart-lang/webdev/compare/6fe17fe..8360d50): 8360d50f 2023-06-22 Elliott Brooks Shard MV2 and MV3 extension tests (#2153) 12e8aa2d 2023-06-22 Elliott Brooks Reset Webdev to 3.0.6-wip (#2154) 8ca3a891 2023-06-22 Elliott Brooks Fix the Puppeteer tests for the Debug Extension (#2152) Change-Id: I8f9ec79d99f375898b3ecd3330512fd39579f37b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311462 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
…st, tools Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/97fc1a7..dfeda1a): dfeda1a 2023-08-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.3.0 (#148) c341051 2023-08-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#147) c1c8d1f 2023-08-01 Moritz Update health.yaml (#146) 31c5d21 2023-07-27 Devon Carew misc updates to the label management tool (#145) http (https://github.com/dart-lang/http/compare/4289e8b..7e9ed12): 7e9ed12 2023-08-01 dependabot[bot] Bump actions/labeler from 4.2.0 to 4.3.0 (#1000) e8e35db 2023-07-31 Alex James [java_http] send request body (#995) mockito (https://github.com/dart-lang/mockito/compare/b421775..ff79de6): ff79de6 2023-08-04 Nate Bosch Allow the latest package:analyzer native (https://github.com/dart-lang/native/compare/f0dc3e9..0187d0e): 0187d0e 2023-08-07 Daco Harkes [native_assets_cli] Rename `Asset` `name` to `id` (#113) 1b984c7 2023-08-07 Daco Harkes [native_assets_cli] Replace `TypeError`s with `FormatException`s (#112) b2b26db 2023-08-07 Daco Harkes [native_assets_builder] Stop throwing from BuildRunner (#108) c940ac8 2023-08-03 Daco Harkes [native_assets_builder] return build dependencies (#107) 63daab8 2023-08-03 Daco Harkes [native_assets_builder] Fix dry run directory structure (#110) 3f26f20 2023-08-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#104) protobuf (https://github.com/dart-lang/protobuf/compare/d9e8a31..217c030): 217c030 2023-08-02 Ömer Sinan Ağacan Avoid holding onto the buffer when parsing unknown length-delimited fields (#863) shelf (https://github.com/dart-lang/shelf/compare/bd59ead..73edd2b): 73edd2b 2023-08-01 dependabot[bot] Bump actions/labeler from 4.2.0 to 4.3.0 (#370) sse (https://github.com/dart-lang/sse/compare/e241085..8cc5b11): 8cc5b11 2023-08-01 dependabot[bot] Bump nanasess/setup-chromedriver from 2.0.0 to 2.1.1 (#86) test (https://github.com/dart-lang/test/compare/92eb0f7..5d571d6): 5d571d64 2023-08-03 Nate Bosch Add --fail-fast flag (#2040) a9dcce29 2023-08-01 Nate Bosch Rerun publish workflow on more PR changes (#2070) 50d558b2 2023-08-01 dependabot[bot] Bump github/codeql-action from 2.20.1 to 2.21.2 (#2071) 9e124e9f 2023-07-31 Nate Bosch Prepare to publish (#2069) tools (https://github.com/dart-lang/tools/compare/af3fc99..f14bf2e): f14bf2e 2023-08-07 Elias Yishak Remove unused NoOp classes (#138) a2aa1c3 2023-08-07 Devon Carew add CI; update readme (#140) d424568 2023-08-06 Devon Carew add usage docs to package:cli_config (#141) 921611a 2023-08-03 Elias Yishak Survey handler feature (#109) Change-Id: Iee720272733822d11caf46adcae516f12f11abec Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318801 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/a32ba3a..adc76e6): adc76e6d 2023-09-06 Parker Lougheed Take advantage of a few Dart 3 features (#3491) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/098bafc..4616c8b): 4616c8b 2023-09-05 Polina Cherkasova Note about OverlayEntry. (#142) fd7d70f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#141) c6c1004 2023-09-01 Polina Cherkasova - (#139) 0298e20 2023-08-31 Polina Cherkasova Add a test specific rule. (#138) ea17fa4 2023-08-29 Polina Cherkasova Increase version of leak_tracker_flutter_testing (#136) 8f830d6 2023-08-29 Polina Cherkasova Update pubspec.yaml (#135) 8a54575 2023-08-29 Polina Cherkasova Enable connection to vm service for flutter testing and define matcher for reporting for memory allocations. (#128) 88a19a7 2023-08-28 Polina Cherkasova - (#133) 2070856 2023-08-24 Polina Cherkasova Add instruction to start tracking instances of ChangeNotifier earlier. (#130) eb6113a 2023-08-23 Polina Cherkasova Measure how memory is consumed by a test. (#114) 72264f7 2023-08-22 Polina Cherkasova Fix misspelling. (#131) 87c9e9e 2023-08-16 Polina Cherkasova Add debugging construcstors to LeakTrackingTestConfig, per leak type. (#129) b29547a 2023-08-15 Polina Cherkasova Create visibility for roadmap for leak_tracker. (#124) 23b15b6 2023-08-15 Polina Cherkasova Fix issue of using wrong settings for a phase. (#122) 713f646 2023-08-11 Polina Cherkasova Enable global configuration for leak tracking. (#121) 19b01cf 2023-08-10 Polina Cherkasova Create package leak_tracker_flutter_testing. (#119) 02d0b2f 2023-08-07 Polina Cherkasova Stop failing if object is disposed twice. (#117) 2026379 2023-08-04 Polina Cherkasova Remove not-published versions and increase leak_tracker version. (#116) 9bb71c6 2023-08-04 Polina Cherkasova Stop requiring registration of disposed objects. (#113) 8939456 2023-08-04 Polina Cherkasova Refactor dispatcher. (#115) 6f54f5a 2023-08-01 Polina Cherkasova Start vm service when needed. (#112) b045c5e 2023-08-01 Polina Cherkasova Reorganize leak tracker for better performance. (#106) 127b83c 2023-07-31 Polina Cherkasova Update TROUBLESHOOT.md (#108) 6dabd33 2023-07-31 Polina Cherkasova Simplify and clarify instructions to fix leaks. (#107) c53db68 2023-07-25 Polina Cherkasova Improve code structure. (#103) 10cce1a 2023-07-24 Polina Cherkasova Rename `gcCountBuffer` to `numberOfGcCycles`. (#101) 3a061a4 2023-07-21 Polina Cherkasova Improve doc comments. (#100) 6e3f57c 2023-07-21 Polina Cherkasova Fix and test cover case of customized `gcCountBuffer` (#99) 2152aab 2023-07-21 Polina Cherkasova Add details about hidden leaks. (#97) lints (https://github.com/dart-lang/lints/compare/da44af3..8d5f750): 8d5f750 2023-09-06 Devon Carew move the list of lint rules from the readme to a separate rules.md file (#145) native (https://github.com/dart-lang/native/compare/a2dfedc..387f894): 387f894 2023-09-06 Gabriel Terwesten [native_toolchain_c] Default handling for PIC/PIE compiler flags (#121) 0a4e5f8 2023-09-06 Gabriel Terwesten Add support for defines to `CBuilder` (#120) webdev (https://github.com/dart-lang/webdev/compare/fc876cb..9487a45): 9487a459 2023-09-05 Jacob Bang Update README.md to use `dart pub` instead of `pub` (#2195) 07367779 2023-08-31 Elliott Brooks Pass the package config directly to the load strategy instead of depending on an app entrypoint (#2203) 0044d753 2023-08-24 Jonas Termansen Fix conflicting webdev smoke package names. (#2202) 6183f270 2023-08-23 Elliott Brooks Allow client to specify a way to convert an absolute path into a g3-relative path (#2200) b244b899 2023-08-22 Elliott Brooks Allow client to specify how to find the package config (#2199) Change-Id: Ic00adc68ec01cd0cc6e27be665436de5095d8d07 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324801 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…mime, protobuf, pub_semver, sse, string_scanner, term_glyph, test, test_reflective_loader, typed_data, vector_math, web, webdriver Revisions updated by `dart tools/rev_sdk_deps.dart`. browser_launcher (https://github.com/dart-lang/browser_launcher/compare/f60df1d..c68ec25): c68ec25 2023-12-04 Kevin Moore drop outdated lints ecosystem (https://github.com/dart-lang/ecosystem/compare/805ab4f..79a1bc5): 79a1bc5 2023-12-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#204) c51c500 2023-12-01 dependabot[bot] Bump actions/github-script (#202) 64eeeee 2023-12-01 dependabot[bot] Bump peter-evans/create-or-update-comment (#203) 32461a7 2023-12-01 Moritz Upgrades to `health.yaml` (#201) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/2238a6b..ae48489): ae48489 2023-12-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#61) markdown (https://github.com/dart-lang/markdown/compare/3774ad0..d2e7903): d2e7903 2023-12-01 dependabot[bot] Bump subosito/flutter-action from 2.11.0 to 2.12.0 (#569) 42d32cb 2023-11-30 Kevin Moore Update to latest lints, require Dart ^3.1 (#568) mime (https://github.com/dart-lang/mime/compare/8ebf946..56359b0): 56359b0 2023-12-05 Yoshihiro Tanaka Detect HEIC/HEIF format by checking header bytes (#109) protobuf (https://github.com/dart-lang/protobuf/compare/dcec2ed..bb19774): bb19774 2023-11-29 Ömer Sinan Ağacan Revert `PbMap._wrappedMap` empty map value (#904) cf43230 2023-11-23 Ömer Sinan Ağacan Update getList and getMap return types (#903) 4e0bdff 2023-11-23 Ömer Sinan Ağacan Make wrapped lists in PbList monomorphic (#902) pub_semver (https://github.com/dart-lang/pub_semver/compare/f9e94ee..4572181): 4572181 2023-12-04 Kevin Moore drop outdated lints (#96) sse (https://github.com/dart-lang/sse/compare/1df63f2..8d2e2f0): 8d2e2f0 2023-12-01 dependabot[bot] Bump nanasess/setup-chromedriver (#99) c6501b3 2023-12-01 Kevin Moore Drop unneeded dep on pkg:test (#98) string_scanner (https://github.com/dart-lang/string_scanner/compare/a7105ef..ebc30a3): ebc30a3 2023-12-04 Kevin Moore Update to latest lints and cleanup (#67) term_glyph (https://github.com/dart-lang/term_glyph/compare/7c1eb9d..4c5a496): 4c5a496 2023-12-04 Kevin Moore drop outdated lints (#46) test (https://github.com/dart-lang/test/compare/a0a4d1e..9fffb48): 9fffb489 2023-12-01 dependabot[bot] Bump github/codeql-action from 2.22.5 to 2.22.8 (#2145) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/17d40bb..6edf535): 6edf535 2023-11-30 Kevin Moore Update lints, bump min SDK to ^3.1.0 (#56) typed_data (https://github.com/dart-lang/typed_data/compare/0b16bd2..6f6d81d): 6f6d81d 2023-12-04 Kevin Moore drop outdated lints (#78) vector_math (https://github.com/google/vector_math.dart/compare/cca3cf1..38a00c3): 38a00c3 2023-12-04 Kevin Moore Update to latest lints and cleanup (#309) cedd304 2023-12-04 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#307) web (https://github.com/dart-lang/web/compare/cffc2e3..865aeaf): 865aeaf 2023-12-01 Devon Carew update the CI workflow to test the generation script (#112) webdriver (https://github.com/google/webdriver.dart/compare/43ed1db..2c1b6f8): 2c1b6f8 2023-12-01 dependabot[bot] Bump nanasess/setup-chromedriver (#290) dc988d7 2023-12-01 Devon Carew update to the latest package:lints (#291) Change-Id: I2d898b6d772925146630777ef587d29a05288a3b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339720 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was originally filed by alexander.orlov@loxal.net
9 MB as a result for a "Hello World" app is just worse.
The text was updated successfully, but these errors were encountered: