-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Annotation Syntax On The Right. Use of def, var and val in lieu of var, T x, final x. #56
Comments
This comment was originally written by drfibonacci@google.com Removed Type-Defect label. |
This comment was originally written by carstenkl...@yahoo.de Personally I do not support the suggestion to replace 'final' by 'val'. If it were to be replaced, then by 'const'. And proper alignment in the editor is not such a big deal at all, see proposal below. Additionally, I believe that one should remove the 'var' keyword from the language because it is redundant. As for type hints, one could use the proposal made below. Proposal: Declaring an initialized variable: x = 5; Declaring a typed, initialized variable: x : num = null; or x : int = 5; Declaring a final untyped variable: x : final = 5; Declaring a final, typed variable: x : final int = 5; Declaring uninitialized variables is supported by the language, and variables with a type hint of <dynamic> should be initialized with null. Declaring an untyped variable and omitting the initializer: x; Declaring a typed variable and omitting the initializer: x : int; and so on. I think you get the picture. |
This comment was originally written by jat@google.com If you don't have some difference between declaring a variable and an expression, how do you distinguish likely typos? In many dynamic languages, this is a common problem where you thought you were assigning to an existing variable but typo'd it and instead created a new one. Regarding type on the left or type on the right, I am not sure why it is claimed that on the right is more readable. I would bet if you take the total number of programmer hours spent in particular languages, those using declarations on the left would outweigh those on the right. I agree that having a : type after a variable declaration does fit optional types better, but I think you will then need a keyword to introduce declarations like in Scala. Then if you usually use types, you will be typing more rather than less: "var foo: int;" rather than "int foo;". |
jat@, I believe the implication with the suggestion here is that "var" would be the keyword to indicate a variable declaration. I don't think we're talking implicit declaration here. So: var foo = 123; // both current and proposed style |
This comment was originally written by jat@google.com That wasn't my interpretation of comment #2 - it looked like he was suggesting dropping the keyword to declare a variable. |
Oh, sorry, my mistake. Note to self: read all comments on bug before opening my mouth. |
Hi, My syntactic preferences are well known, and I have great sympathy for what you are saying. However: Set owner to @gbracha. |
This comment was originally written by Ray.Rac...@gmail.com Of course I was looking at the big picture. If all unfolds as it well mayhappen Dart is destined to be the most widely used language in the world with a life span of many decades if not well over a century. Ergo what the heck was worth a shot! Please close, along with companion issue #99. |
Closing at submitter's request. If only all feature requesters were so accommodating ... Added WontFix label. |
Changes: ``` > git log --format="%C(auto) %h %s" 7abe634..c40cc32 https://dart.googlesource.com/pool.git/+/c40cc32 Merge pull request #56 from dart-lang/devoncarew-patch-1 https://dart.googlesource.com/pool.git/+/5ce105e test against Dart 2.15 https://dart.googlesource.com/pool.git/+/6e9885f switch to package:lints https://dart.googlesource.com/pool.git/+/430b860 rev to a dev version https://dart.googlesource.com/pool.git/+/a1e710d Update pubspec.yaml https://dart.googlesource.com/pool.git/+/4fcbdb9 Use latest CI setup, test on oldest supported SDK (#55) https://dart.googlesource.com/pool.git/+/005271c Merge pull request #54 from dart-lang/franklinyow-patch-1 https://dart.googlesource.com/pool.git/+/b2dbf29 Update LICENSE https://dart.googlesource.com/pool.git/+/878759a Prepare to publish for stable null safety (#52) https://dart.googlesource.com/pool.git/+/c065054 Migrate to GitHub Actions (#51) https://dart.googlesource.com/pool.git/+/96b6734 Merge pull request #48 from dart-lang/pq-analyze https://dart.googlesource.com/pool.git/+/9688715 migrate from `dartanalyzer` to `dart analyze` ``` Diff: https://dart.googlesource.com/pool.git/+/7abe634002a1ba8a0928eded086062f1307ccfae~..c40cc32eabecb9d60f1045d1403108d968805f9a/ Change-Id: I10e7d7c2b8a4168770da5dfa8211bba9ce37a1f5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244722 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
…s, markdown, matcher, mockito, path, pool, source_map_stack_trace, sse, stream_channel, string_scanner, test, test_reflective_loader, tools, typed_data, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. cli_util (https://github.com/dart-lang/cli_util/compare/91747f7..6c318c2): 6c318c2 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#81) df83fb5 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#80) collection (https://github.com/dart-lang/collection/compare/0d0e184..30fd0f8): 30fd0f8 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#277) dartdoc (https://github.com/dart-lang/dartdoc/compare/0746cda..9be04e0): 9be04e0c 2023-03-28 Jonas Finnemann Jensen Allow ID attributes on headings when running with --sanitize-html (#3358) 8785dd24 2023-03-27 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#3377) 0944fa32 2023-03-27 dependabot[bot] Bump github/codeql-action from 2.2.6 to 2.2.9 (#3379) e318d34f 2023-03-27 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#3378) ffi (https://github.com/dart-lang/ffi/compare/32f5eef..04fa38a): 04fa38a 2023-04-03 Daco Harkes test zero termination of Utf8 string (#147) eb93bbb 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#188) 2a6b643 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#189) intl (https://github.com/dart-lang/intl/compare/fca552f..a958db0): a958db0 2023-03-29 Googler Internal change json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/0280ac6..aea3bea): aea3bea 2023-03-28 Kevin Moore Fix analysis, bump min SDK to 2.19 (#93) lints (https://github.com/dart-lang/lints/compare/dfded5e..f09399a): f09399a 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#110) 9581bab 2023-03-25 Parker Lougheed Fix 'recommended' spelling in README (#109) c92e1ca 2023-03-23 Michael Thomsen Update README.md (#108) 7134608 2023-02-01 dependabot[bot] Bump actions/checkout from 3.2.0 to 3.3.0 (#98) markdown (https://github.com/dart-lang/markdown/compare/ecbffa9..d437c85): d437c85 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#529) 3550fe6 2023-04-01 dependabot[bot] Bump subosito/flutter-action from 2.8.0 to 2.10.0 (#528) d1b7907 2023-04-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#527) 0daf231 2023-03-31 le.chang Footnote support (#441) b96bc08 2023-03-30 Jonas Finnemann Jensen Prepare a release of 7.0.2 (#526) matcher (https://github.com/dart-lang/matcher/compare/dc310d9..61f4347): 61f4347 2023-03-21 Nate Bosch Prepare to publish (#214) mockito (https://github.com/dart-lang/mockito/compare/ed5bd84..28e8eda): 28e8eda 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 ccb9abf 2023-04-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 65ee0c4 2023-03-23 Nate Bosch Expand pub constraint on test_api (#615) e6ea7ad 2023-03-23 Nate Bosch GitHub Sync (#614) path (https://github.com/dart-lang/path/compare/24b58a2..cd37179): cd37179 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#139) pool (https://github.com/dart-lang/pool/compare/694cfd8..338bfb4): 338bfb4 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#67) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/45ea368..08a81a8): 08a81a8 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#37) 4cbe06e 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#36) sse (https://github.com/dart-lang/sse/compare/8c03b73..8c3efdc): 8c3efdc 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#80) e35336a 2023-04-02 dependabot[bot] Bump nanasess/setup-chromedriver from 1.1.0 to 2.0.0 (#81) stream_channel (https://github.com/dart-lang/stream_channel/compare/a20ccd4..fe0f5e4): fe0f5e4 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#89) string_scanner (https://github.com/dart-lang/string_scanner/compare/29e471e..f7a656f): f7a656f 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#56) fe8c301 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#55) test (https://github.com/dart-lang/test/compare/cc0598b..a01b185): a01b185e 2023-03-30 Nate Bosch More smoothly handle missing compiler info (#1980) b24b4668 2023-03-27 Daco Harkes Support native assets (#1975) c3828267 2023-03-23 Nate Bosch Prepare to publish (#1974) 9035bba8 2023-03-21 Parker Lougheed Use deps.dev for OpenSSF scorecard results link (#1976) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/c4c2d5c..a85a930): a85a930 2023-04-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#46) 27bc418 2023-04-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#47) tools (https://github.com/dart-lang/tools/compare/fb2dada..d40ca93): d40ca93 2023-04-03 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.3 (#66) 4185d6d 2023-04-03 dependabot[bot] Bump coverallsapp/github-action from 1.2.4 to 2.0.0 (#65) b14d5be 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#64) typed_data (https://github.com/dart-lang/typed_data/compare/f858046..d85363d): d85363d 2023-04-02 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#62) 0f57d9b 2023-04-02 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#63) webdev (https://github.com/dart-lang/webdev/compare/c2c8b17..b139649): b139649e 2023-03-31 Elliott Brooks Don't show non-instantiated variables (#2061) 8437f60a 2023-03-31 Elliott Brooks Move project-specific getters to `TestProject` instead of `TestContext` (#2052) 652e040c 2023-03-30 Elliott Brooks Provide an app entrypoint to DWDS (#2047) 0afc9eb4 2023-03-30 Elliott Brooks Add Dart Code Metrics (#2055) 5fcbb803 2023-03-29 Elliott Brooks Apply `trailing-comma` lint (#2054) 5bd21384 2023-03-28 Elliott Brooks Skip failing webdev integration_test cases (#2051) 2d8e9c23 2023-03-24 Elliott Brooks (she/her) Adds a script for the release steps of `dwds` and `webdev` (#2049) afee8c74 2023-03-23 Elliott Brooks (she/her) Reset `webdev`, `dwds`, `test_common` after publishing (#2048) 4122b234 2023-03-22 Devon Carew update to the latest mono_repo generated CI (#2044) 2b6e9182 2023-03-22 Elliott Brooks (she/her) Prepare Webdev for `3.0.3` release (#2046) c3cbd89b 2023-03-22 Elliott Brooks (she/her) Prepare DWDS for 18.0.2 release (#2045) bb22b3a0 2023-03-22 Anna Gringauze Make debugger skip same locations in dart during stepping. (#2043) b9499819 2023-03-20 Anna Gringauze Prepare for variable names changes due to patterns support in DDC (#2042) Change-Id: I5b8d591d1b906338564cf008f935b17f85ed2813 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292922 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…native, protobuf, pub_semver, shelf, stack_trace, tools, vector_math, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/f0f6cd2..a9543c0): a9543c0 2023-05-31 Devon Carew switch to using package:dart_flutter_team_lints (#247) 36407ea 2023-05-31 Devon Carew adjust the validation of mandatory options (#246) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d9b389f..c14a268): c14a268 2023-05-31 Kevin Moore Bump lints, regenerate proto file, fix script (#74) dartdoc (https://github.com/dart-lang/dartdoc/compare/950898f..39fe1a8): 39fe1a8a 2023-05-31 Parker Lougheed Update highlight.js to 11.8.0 for Dart 3 syntax highlighting (#3416) 4574e819 2023-05-30 Sam Rawlins Convert kind to an enum (#3426) http (https://github.com/dart-lang/http/compare/18a43a2..8834aec): 8834aec 2023-05-31 Brian Quinlan Update readme and prepare for a new release (#954) aca7f0e 2023-05-31 dependabot[bot] Bump futureware-tech/simulator-action from 1 to 2 (#936) 7a238a9 2023-05-31 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.4 (#952) 4c0eb48 2023-05-30 Brian Quinlan Prepare to publish cupertino_http 1.0.0 (#951) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/7f2cab3..cbbdeca): cbbdeca 2023-05-31 Polina Cherkasova Improve getting retaining path. (#69) mockito (https://github.com/dart-lang/mockito/compare/40fe2ca..924f65c): 924f65c 2023-06-01 Ilya Yanok Add support for records native (https://github.com/dart-lang/native/compare/76bc55e..c851e69): c851e69 2023-06-01 dependabot[bot] Bump nttld/setup-ndk (#57) 0df0cad 2023-06-01 dependabot[bot] Bump actions/labeler from 4.0.3 to 4.0.4 (#58) c30faa2 2023-05-31 Daco Harkes [c_compiler] test install_name_tool behavior (#56) 45ef2e7 2023-05-31 Daco Harkes [c_compiler] Support setting the install name of dylibs (#55) protobuf (https://github.com/dart-lang/protobuf/compare/346a72d..da6953c): da6953c 2023-05-31 Kevin Moore Update to latest lints and Dart SDK (#828) pub_semver (https://github.com/dart-lang/pub_semver/compare/c034352..3930557): 3930557 2023-05-31 Kevin Moore Bump lints, require Dart 3.0 (#89) shelf (https://github.com/dart-lang/shelf/compare/a404b6a..ce379aa): ce379aa 2023-06-01 dependabot[bot] Bump actions/labeler from 4.0.3 to 4.0.4 (#363) stack_trace (https://github.com/dart-lang/stack_trace/compare/86f7e30..8b2046e): 8b2046e 2023-05-31 Devon Carew blast_repo fixes (#134) tools (https://github.com/dart-lang/tools/compare/d723a55..389925f): 389925f 2023-06-01 Elias Yishak Utility function added to check permissions on directory (#95) a436fee 2023-05-31 Elias Yishak Asserts added to check all relevant GA4 limitations (#96) vector_math (https://github.com/google/vector_math.dart/compare/cd87f57..a3aca09): a3aca09 2023-05-31 Lukas Klingsbo fix: Revert negation change for Vector2 (#296) webdev (https://github.com/dart-lang/webdev/compare/d442fa8..f565d7f): f565d7f1 2023-05-31 Anna Gringauze Disable flaky test on windows (#2127) 6eed300e 2023-05-31 Anna Gringauze Cleanup expression evalaluation tests (#2125) Change-Id: Ia568db23bbc923f764cdf323e249175b609d57ee Tested: affected files are regenerated test goldens Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306903 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…ctor, browser_launcher, characters, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, leak_tracker, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, protobuf, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, web_socket_channel, webdev, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/a9543c0..da56b18): da56b18 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#249) async (https://github.com/dart-lang/async/compare/a506993..b65622a): b65622a 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#247) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/f7b714e..c29d162): c29d162 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#77) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/e717ad4..fde73cb): fde73cb 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#91) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/3a1c982..303635d): 303635d 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#49) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/40e4315..27ec600): 27ec600 2023-07-05 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#46) dd8df9c 2023-07-05 Devon Carew update formatting for recent lints (#47) characters (https://github.com/dart-lang/characters/compare/3ef8883..ec844db): ec844db 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) cli_util (https://github.com/dart-lang/cli_util/compare/5a49947..9b7ce78): 9b7ce78 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) clock (https://github.com/dart-lang/clock/compare/21caac1..263e508): 263e508 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#54) collection (https://github.com/dart-lang/collection/compare/a37bd51..db343da): db343da 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#295) convert (https://github.com/dart-lang/convert/compare/9a387f0..79ee174): 79ee174 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) crypto (https://github.com/dart-lang/crypto/compare/216931a..8b704c6): 8b704c6 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#150) csslib (https://github.com/dart-lang/csslib/compare/be2e11e..7e91228): 7e91228 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#187) dartdoc (https://github.com/dart-lang/dartdoc/compare/c2ed703..2522559): 25225596 2023-06-29 Sam Rawlins Migrate some simple tasks to a simple package:args command (#3456) ecosystem (https://github.com/dart-lang/ecosystem/compare/19fa443..b34db4f): b34db4f 2023-07-10 Moritz Allow empty coverage (#128) 5944328 2023-07-04 Moritz Prepare for publish (#127) c0701c9 2023-07-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#122) 9bf3a10 2023-07-03 Moritz Fix bug by switching `reduce` to `fold` (#126) fdfa528 2023-07-01 dependabot[bot] Bump actions/cache from 3.2.6 to 3.3.1 (#121) 238444c 2023-07-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.3 (#123) ca1e1ae 2023-06-30 Moritz Add coverage workflow (#119) cf02b4a 2023-06-30 Lasse R.H. Nielsen Make Changelog class eagerly load and parse file. (#120) ffi (https://github.com/dart-lang/ffi/compare/f582ca0..f01dfca): f01dfca 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#199) fixnum (https://github.com/dart-lang/fixnum/compare/d9b9a2a..00fa120): 00fa120 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#113) glob (https://github.com/dart-lang/glob/compare/109121d..5b24393): 5b24393 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#79) html (https://github.com/dart-lang/html/compare/b3b820b..4060496): 4060496 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#218) 8cb99e4 2023-07-01 Devon Carew address new analysis issues (#219) http (https://github.com/dart-lang/http/compare/d68081f..c148a3a): c148a3a 2023-07-07 Alex James Java http BaseClient implementation (#980) 474999f 2023-07-05 Brian Quinlan Document that the network entitlement is required when running in the macOS sandbox (#979) 98e4112 2023-07-05 Brian Quinlan Fix a bug where ...WebSocketClosed had two different initializer signatures (#981) 9833a20 2023-07-05 Brian Quinlan Support Steam<List<int>> as a provider of request data (#975) d3e78a0 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#976) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/a209cd5..aa128cf): aa128cf 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#56) http_parser (https://github.com/dart-lang/http_parser/compare/19466c0..c14fbf6): c14fbf6 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#75) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/73467f3..509f71e): 509f71e 2023-07-05 Nate Bosch Fix the example to act as a server (#100) d80cbd0 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/c75b0a7..85bd7fb): 85bd7fb 2023-07-05 Polina Cherkasova - (#87) lints (https://github.com/dart-lang/lints/compare/89f9519..e03dc04): e03dc04 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#138) logging (https://github.com/dart-lang/logging/compare/f2fe2ac..5214987): 5214987 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#144) markdown (https://github.com/dart-lang/markdown/compare/4674d09..b4bdde2): b4bdde2 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#549) matcher (https://github.com/dart-lang/matcher/compare/7e10117..ce8f409): ce8f409 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#225) mime (https://github.com/dart-lang/mime/compare/2444840..bdb66bd): bdb66bd 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) mockito (https://github.com/dart-lang/mockito/compare/974226e..451f756): 451f756 2023-07-10 Nate Bosch Add example of mocking callbacks c13496c 2023-07-05 Googler Rollback of "Use `FunctionTypedElement.type` while generating method overrides" 60e619a 2023-07-05 Ilya Yanok Use `FunctionTypedElement.type` while generating method overrides 93b69ef 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#669) a926a63 2023-06-30 Ilya Yanok Add a note on only running codegen on files under `test/` by default 9f40189 2023-06-30 Ilya Yanok Require analyzer 5.12.0 native (https://github.com/dart-lang/native/compare/e12d3e6..de1b0cc): de1b0cc 2023-07-10 Daco Harkes [c_compiler] Pass the correct SDK for iOS simulator builds (#77) 21d7270 2023-07-01 dependabot[bot] Bump coverallsapp/github-action from 2.1.2 to 2.2.0 (#72) 23a9b62 2023-07-01 dependabot[bot] Bump nttld/setup-ndk (#74) 44073a8 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#75) 6f01604 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#73) package_config (https://github.com/dart-lang/package_config/compare/203de20..be0c441): be0c441 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#138) path (https://github.com/dart-lang/path/compare/592505f..282dd18): 282dd18 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#147) pool (https://github.com/dart-lang/pool/compare/c6b1b2c..7700102): 7700102 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#72) protobuf (https://github.com/dart-lang/protobuf/compare/7bebbc6..a912f76): a912f76 2023-07-04 Ömer Sinan Ağacan Add more message set tests, fix a bug (#859) pub_semver (https://github.com/dart-lang/pub_semver/compare/3930557..028b435): 028b435 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#90) shelf (https://github.com/dart-lang/shelf/compare/ce379aa..bd59ead): bd59ead 2023-07-06 Kevin Moore router_generator: allow latest pkg:analyzer, request Dart 3 (#368) bebc801 2023-07-06 Jonas Finnemann Jensen Fix 244 (#268) 1617efa 2023-07-02 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#366) c037bb6 2023-07-02 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#365) 1ae4d4e 2023-07-01 Devon Carew address a new lint (#367) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/b83af01..16e54fd): 16e54fd 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#40) source_maps (https://github.com/dart-lang/source_maps/compare/58eef30..97c4833): 97c4833 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#80) source_span (https://github.com/dart-lang/source_span/compare/4dc78fb..37735ae): 37735ae 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) sse (https://github.com/dart-lang/sse/compare/bfcbcd7..e241085): e241085 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#85) stack_trace (https://github.com/dart-lang/stack_trace/compare/8b2046e..4ddd86d): 4ddd86d 2023-07-05 Slava Egorov Prepare 1.11.1 release (#137) d3e4c4d 2023-07-04 Slava Egorov Use awaiter-link pragma to guide VM's builtin awaiter stack unwinding (#135) 44aafa3 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#136) stream_channel (https://github.com/dart-lang/stream_channel/compare/34804a1..e54234f): e54234f 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#93) string_scanner (https://github.com/dart-lang/string_scanner/compare/6bb314f..35657e2): 35657e2 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#59) term_glyph (https://github.com/dart-lang/term_glyph/compare/4daa34e..423700a): 423700a 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#40) test (https://github.com/dart-lang/test/compare/021667a..3429712): 3429712b 2023-07-06 Nate Bosch Drop usage of window.testRunner (#2059) dc6b8236 2023-06-29 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.5.3 (#2051) b6dc3f8d 2023-06-29 dependabot[bot] Bump dart-lang/setup-dart from 1.3.0 to 1.5.0 (#2052) 5fa2572f 2023-06-29 Jacob MacDonald regenerate mono_repo with the latest (#2055) 56584627 2023-06-29 dependabot[bot] Bump github/codeql-action from 2.3.5 to 2.20.1 (#2053) 050fe2d6 2023-06-29 dependabot[bot] Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (#2054) ba6ccfc2 2023-06-29 Devon Carew config dependabot to send daily PRs for major version bumps (#2050) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/be7ce07..54a4c59): 54a4c59 2023-07-03 Devon Carew update formatting for recent lints (#54) test_process (https://github.com/dart-lang/test_process/compare/5ff2122..b360784): b360784 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#46) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/40d61b1..0bfaad9): 0bfaad9 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#50) tools (https://github.com/dart-lang/tools/compare/8db0aa1..af38b2b): af38b2b 2023-07-02 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#119) 8b8ccab 2023-07-01 Devon Carew update formatting based on the recent lints (#121) 30b50ff 2023-07-01 dependabot[bot] Bump coverallsapp/github-action from 2.1.2 to 2.2.0 (#118) 74979c1 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#120) typed_data (https://github.com/dart-lang/typed_data/compare/8d29573..a20be90): a20be90 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#69) usage (https://github.com/dart-lang/usage/compare/6ee0908..09bb847): 09bb847 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#196) watcher (https://github.com/dart-lang/watcher/compare/3f17faa..7457413): 7457413 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#148) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/7fb82f2..7ae4d0f): 7ae4d0f 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#274) webdev (https://github.com/dart-lang/webdev/compare/8360d50..f0ba743): f0ba7438 2023-07-07 Elliott Brooks Reset webdev to version 3.0.7-wip (#2170) 2fcc1ba9 2023-07-06 Anna Gringauze Add option of running frontend server tests in canary mode (#2169) 632763a5 2023-07-06 Elliott Brooks Prepare webdev for release to 3.0.6 (#2167) fa7b6d44 2023-07-05 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.3 (#2163) 2a6a457b 2023-07-05 Devon Carew regenerate from the latest mono_repo (#2165) cbb0d76a 2023-07-05 Anna Gringauze Run instance tests with frontend server (#2160) b672e98a 2023-07-05 Elliott Brooks Reset DWDS after release (#2168) 8ef92d71 2023-07-05 Elliott Brooks Prepare DWDS for release to version 19.0.2 (#2166) 77e5b373 2023-07-05 Elliott Brooks Handle potential `null` value in `setUpChromeConsoleListeners` (#2162) 5081dff0 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#2164) yaml (https://github.com/dart-lang/yaml/compare/0b9041d..7930148): 7930148 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#148) Change-Id: I095a2479946e13d8499f1b3a58dc5a82688063f6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313020 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…li_util, clock, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, http, lints, logging, markdown, matcher, mime, native, path, pool, shelf, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, tools, typed_data, watcher, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/b65622a..75efa6c): 75efa6c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#250) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c29d162..f950bbf): f950bbf 2023-08-31 Parker Lougheed Regenerate worker protocol protos to add constructors and comments (#78) 9b4c6a0 2023-08-30 Parker Lougheed Update e2e_test dependencies (#79) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/303635d..f255921): f255921 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#50) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/27ec600..1f69393): 1f69393 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#48) cli_util (https://github.com/dart-lang/cli_util/compare/9b7ce78..44118e3): 44118e3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#88) clock (https://github.com/dart-lang/clock/compare/263e508..1e75f08): 1e75f08 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#55) convert (https://github.com/dart-lang/convert/compare/79ee174..c058c8f): c058c8f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#86) crypto (https://github.com/dart-lang/crypto/compare/8b704c6..1e26879): 1e26879 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#151) csslib (https://github.com/dart-lang/csslib/compare/7e91228..bd30a1a): bd30a1a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#188) dartdoc (https://github.com/dart-lang/dartdoc/compare/5fda5eb..695b218): 695b218c 2023-08-30 Sam Rawlins Tidy Category: (#3488) b26af96f 2023-08-30 Sam Rawlins Tidy up library exports (#3487) be35cb00 2023-08-29 Devon Carew Update dependabot.yaml (#3486) 649bb8d2 2023-08-29 Sam Rawlins Migrate to create_api_docs.dart (#3482) ecosystem (https://github.com/dart-lang/ecosystem/compare/f777da7..89e58de): 89e58de 2023-09-01 Hossein Yousefi also install flutter on validate (#160) f95d0f2 2023-09-01 Hossein Yousefi Add use-flutter arg to validate (#159) 8743a9d 2023-09-01 Moritz Pass a parameter for Flutter `firehose` support (#158) 54d1628 2023-08-31 Moritz Setup Flutter in publish workflow (#157) 8fa89c6 2023-08-31 Moritz Add flutter support (#155) 65817bf 2023-08-29 Moritz Switch to Pub API (#152) ffi (https://github.com/dart-lang/ffi/compare/e2c01a9..d36e05a): d36e05a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#208) fixnum (https://github.com/dart-lang/fixnum/compare/00fa120..87ed065): 87ed065 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#114) http (https://github.com/dart-lang/http/compare/cad7d60..7fb6fd6): 7fb6fd6 2023-08-31 Brian Quinlan Clarify how to set the body without a content type header (#1014) lints (https://github.com/dart-lang/lints/compare/54cd7a0..da44af3): da44af3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#144) logging (https://github.com/dart-lang/logging/compare/5214987..bcaad0f): bcaad0f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#147) markdown (https://github.com/dart-lang/markdown/compare/56e75df..6cfd6f1): 6cfd6f1 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#554) 52be591 2023-08-30 Parker Lougheed Fix a few more lints, no longer ignore line length (#552) matcher (https://github.com/dart-lang/matcher/compare/ce8f409..80910d6): 80910d6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#227) mime (https://github.com/dart-lang/mime/compare/799b398..37ef637): 37ef637 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#104) native (https://github.com/dart-lang/native/compare/5a1361b..a2dfedc): a2dfedc 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#117) 8dfb0d2 2023-09-01 dependabot[bot] Bump nttld/setup-ndk from 1.2.0 to 1.3.1 (#118) path (https://github.com/dart-lang/path/compare/7c2324b..96d9183): 96d9183 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#150) pool (https://github.com/dart-lang/pool/compare/7700102..a5bee35): a5bee35 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#73) shelf (https://github.com/dart-lang/shelf/compare/73edd2b..2926f76): 2926f76 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#376) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/16e54fd..196d7bf): 196d7bf 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#41) sse (https://github.com/dart-lang/sse/compare/8cc5b11..eeb2588): eeb2588 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#87) 2bb1a6e 2023-09-01 dependabot[bot] Bump nanasess/setup-chromedriver from 2.1.1 to 2.2.0 (#88) stack_trace (https://github.com/dart-lang/stack_trace/compare/4ddd86d..bcf2a0b): bcf2a0b 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#140) stream_channel (https://github.com/dart-lang/stream_channel/compare/e54234f..0ce7ab6): 0ce7ab6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#94) string_scanner (https://github.com/dart-lang/string_scanner/compare/413b57a..da9142c): da9142c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#62) term_glyph (https://github.com/dart-lang/term_glyph/compare/423700a..1b28285): 1b28285 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#41) test (https://github.com/dart-lang/test/compare/d0fc4bd..27dcae1): 27dcae11 2023-09-01 dependabot[bot] Bump github/codeql-action from 2.21.2 to 2.21.5 (#2086) cf0a0a73 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#2085) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/36d8617..030193d): 030193d 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#55) test_process (https://github.com/dart-lang/test_process/compare/b360784..2a6ee23): 2a6ee23 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#47) tools (https://github.com/dart-lang/tools/compare/b72fae8..2c8cbd6): 2c8cbd6 2023-09-01 Jonas Finnemann Jensen Extension discovery 2.0.0 (#156) 3e12c2e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#157) 0f28f80 2023-08-28 Kenzie Davisson Prepare extension_discovery for 1.0.1 release (#154) typed_data (https://github.com/dart-lang/typed_data/compare/a20be90..80e8943): 80e8943 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#72) watcher (https://github.com/dart-lang/watcher/compare/7457413..1aed03e): 1aed03e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#149) yaml (https://github.com/dart-lang/yaml/compare/7930148..ae00187): ae00187 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#150) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/87dcf31..4a9734d): 4a9734d 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#56) 83f9033 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#54) Change-Id: Ie6b9d9ef138730b98e9df8cbb31c6cc330ada9f8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323703 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…ctor, browser_launcher, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/5a4e16f..df9b428): df9b428 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#256) 892f013 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#257) async (https://github.com/dart-lang/async/compare/75efa6c..def4482): def4482 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#253) a0ca552 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#252) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/159e671..b1b6a66): b1b6a66 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#82) bb9e48d 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#81) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/7d0d28e..59aea95): 59aea95 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#94) e3f6207 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#93) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/f255921..9431e01): 9431e01 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#51) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/1f69393..25bc94a): 25bc94a 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#50) cli_util (https://github.com/dart-lang/cli_util/compare/44118e3..9e48f0d): 9e48f0d 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#90) clock (https://github.com/dart-lang/clock/compare/1e75f08..200a020): 200a020 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#56) 8a2b550 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#57) collection (https://github.com/dart-lang/collection/compare/91afde4..d27bfaf): d27bfaf 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#314) 5d568ae 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#313) convert (https://github.com/dart-lang/convert/compare/c058c8f..140b2f0): 140b2f0 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#87) crypto (https://github.com/dart-lang/crypto/compare/1e26879..b38dd62): b38dd62 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153) csslib (https://github.com/dart-lang/csslib/compare/bd30a1a..f6b68dd): f6b68dd 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#190) 4b1ee3f 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#189) dartdoc (https://github.com/dart-lang/dartdoc/compare/a3cfdc4..59947b1): 59947b14 2023-09-25 Sam Rawlins Do not hide stacktrace of DartdocFailures (#3505) d95af5c7 2023-09-25 dependabot[bot] Bump actions/checkout from 4.0.0 to 4.1.0 (#3506) ecosystem (https://github.com/dart-lang/ecosystem/compare/3da2dd3..dcbd2ee): dcbd2ee 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#184) 3006120 2023-10-01 dependabot[bot] Bump peter-evans/create-or-update-comment (#183) 69334aa 2023-10-01 dependabot[bot] Bump actions/upload-artifact (#181) 3dd6c69 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#185) 2c5523c 2023-10-01 dependabot[bot] Bump actions/cache from 3.3.1 to 3.3.2 (#182) 5b7d3fd 2023-09-28 Devon Carew update package:dart_flutter_team_lints to use the beta package:lints (#179) 297e63e 2023-09-28 Devon Carew fix an issue validating pre-release git publishing tags (#180) 1154183 2023-09-28 Moritz Check for `DO_NOT_SUBMIT` strings. (#178) bc2dd27 2023-09-28 Moritz Add api tool call for testing (#153) eb8e398 2023-09-27 Moritz Do not fail `publish` on forks (#177) f40a4eb 2023-09-25 Devon Carew improve support for '-dev' and '-wip' package versions (#173) ffi (https://github.com/dart-lang/ffi/compare/d36e05a..ee70dd4): ee70dd4 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#214) fixnum (https://github.com/dart-lang/fixnum/compare/87ed065..ef0a587): ef0a587 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#115) glob (https://github.com/dart-lang/glob/compare/9c1996f..0046533): 0046533 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#83) f6ebc74 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#84) html (https://github.com/dart-lang/html/compare/a1b193e..49e2c8e): 49e2c8e 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#228) fb2de8a 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#227) http (https://github.com/dart-lang/http/compare/1251619..88ec75e): 88ec75e 2023-10-01 dependabot[bot] Bump actions/checkout from 3 to 4 (#1025) 08143d1 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#1024) 2c99da1 2023-10-01 dependabot[bot] Bump actions/cache from 3.3.1 to 3.3.2 (#1023) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/9d62ea3..03041aa): 03041aa 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#59) 5efaa07 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#58) http_parser (https://github.com/dart-lang/http_parser/compare/d2d03e7..c557f57): c557f57 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#78) a629fd6 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#79) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/50a3786..0521afb): 0521afb 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#104) 4782145 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103) lints (https://github.com/dart-lang/lints/compare/b044aca..140c802): 140c802 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#158) 624a09d 2023-09-28 Devon Carew add dangling_library_doc_comments, remove prefer_void_to_null (#157) 296efaf 2023-09-28 Devon Carew remove no_wildcard_variable_uses; improve testing (#156) c266a04 2023-09-26 Devon Carew rev to 3.0.0-beta in preparation for publishing (#153) logging (https://github.com/dart-lang/logging/compare/bcaad0f..642ed21): 642ed21 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#149) 287f4cb 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#148) markdown (https://github.com/dart-lang/markdown/compare/6cfd6f1..ae766d5): ae766d5 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#556) matcher (https://github.com/dart-lang/matcher/compare/80910d6..11daad9): 11daad9 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#229) mime (https://github.com/dart-lang/mime/compare/37ef637..f3b9c49): f3b9c49 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#105) mockito (https://github.com/dart-lang/mockito/compare/097e563..610c3dc): 610c3dc 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#699) 73930cd 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#698) native (https://github.com/dart-lang/native/compare/be4aaf7..22500ea): 22500ea 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#144) 5bfc7ff 2023-10-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#145) 0b7885a 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#143) package_config (https://github.com/dart-lang/package_config/compare/ae7ad83..100533d): 100533d 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#141) a4b474a 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#142) path (https://github.com/dart-lang/path/compare/96d9183..abcf38c): abcf38c 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#151) pool (https://github.com/dart-lang/pool/compare/a5bee35..4bcc7de): 4bcc7de 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#75) pub_semver (https://github.com/dart-lang/pub_semver/compare/f0be74a..8e5a58f): 8e5a58f 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#93) 81da7c8 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#92) shelf (https://github.com/dart-lang/shelf/compare/4851978..c15fc6f): c15fc6f 2023-10-01 dependabot[bot] Bump actions/cache from 3.3.1 to 3.3.2 (#386) e47c00e 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#384) b9c898e 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#385) 9b96b9b 2023-09-26 Michael Thomsen Add backend tag in pubspec.yaml (#381) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/196d7bf..73d449c): 73d449c 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#42) 2c4840e 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#43) source_maps (https://github.com/dart-lang/source_maps/compare/eb3d40a..fc6aa16): fc6aa16 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#83) dfca7d5 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#82) source_span (https://github.com/dart-lang/source_span/compare/48d0f57..92e50bf): 92e50bf 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#102) c212afa 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103) sse (https://github.com/dart-lang/sse/compare/eeb2588..606387e): 606387e 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#89) stack_trace (https://github.com/dart-lang/stack_trace/compare/bcf2a0b..1c36cd7): 1c36cd7 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#143) stream_channel (https://github.com/dart-lang/stream_channel/compare/0ce7ab6..bf74065): bf74065 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#95) string_scanner (https://github.com/dart-lang/string_scanner/compare/da9142c..616424c): 616424c 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#63) term_glyph (https://github.com/dart-lang/term_glyph/compare/1b28285..19abf84): 19abf84 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#42) test (https://github.com/dart-lang/test/compare/8191a35..367aa39): 367aa397 2023-10-02 Jacob MacDonald release test_core and test (#2112) 672be9d7 2023-10-02 Ben Konyi Update package:vm_service to 12.0.0 (#2110) de324cc7 2023-10-01 dependabot[bot] Bump github/codeql-action from 2.21.5 to 2.21.9 (#2106) 31b94dbb 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#2105) d56c2150 2023-10-01 dependabot[bot] Bump actions/cache from 3.0.11 to 3.3.2 (#2108) b93f1b50 2023-10-01 dependabot[bot] Bump actions/upload-artifact from 3.1.2 to 3.1.3 (#2109) a077b673 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#2107) 566d70a2 2023-09-26 Lau Ching Jun Filter test by line when kernel is compiled with --filesystem-scheme. (#2101) 7ec1bbf5 2023-09-25 Nate Bosch Drop support for legacy iframe communication (#2099) d3f4b368 2023-09-25 Nate Bosch Tighten types in test utils (#2097) 9d997910 2023-09-25 Nate Bosch Add types to Browser implementation url arguments (#2096) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/030193d..55b5eac): 55b5eac 2023-10-02 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#57) c2ba59e 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#56) test_process (https://github.com/dart-lang/test_process/compare/2a6ee23..5efd0bf): 5efd0bf 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#49) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/45c57d6..8593eb1): 8593eb1 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#52) 4857e22 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#53) tools (https://github.com/dart-lang/tools/compare/3c248df..f318c80): f318c80 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#177) 0480655 2023-10-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#176) 73583e8 2023-09-29 Devon Carew update package:cli_config to the latest package:dart_flutter_team_lints (#171) b293897 2023-09-28 Devon Carew update to the latest package:dart_flutter_team_lints (#173) 242fdb5 2023-09-28 Devon Carew update to the latest package:dart_flutter_team_lints (#172) a51f779 2023-09-28 Elias Yishak Use constant for no op client id (#168) e83caee 2023-09-27 Moritz Allow `publish` to write comments on forks (#169) typed_data (https://github.com/dart-lang/typed_data/compare/80e8943..d1c15ed): d1c15ed 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#73) e13af06 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#74) usage (https://github.com/dart-lang/usage/compare/7b12d51..d7d2964): d7d2964 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#198) 920c6e8 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#199) watcher (https://github.com/dart-lang/watcher/compare/1aed03e..c480e2d): c480e2d 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#151) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/af945f1..364013d): 364013d 2023-10-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#286) 50dada7 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#285) webdev (https://github.com/dart-lang/webdev/compare/3078f48..7c2c2d7): 7c2c2d70 2023-10-01 dependabot[bot] Bump actions/checkout from 3.2.0 to 4.1.0 (#2245) 7739a114 2023-09-26 Elliott Brooks Refactor tests to handle new `ToolConfiguration` (#2243) 4e350cde 2023-09-21 Elliott Brooks Fix issue with the inspector panel in the Dart Debug Extension (#2242) bbddba29 2023-09-21 Elliott Brooks Prepare the Dart Debug Extension for release to version 1.36 (#2241) cc5db13f 2023-09-21 Elliott Brooks Rename plainUri to debugUri and send it to the extension (#2238) 48fc725f 2023-09-20 Elliott Brooks Add a new workspaceName parameter to DWDS on start up (#2237) d2dae560 2023-09-20 Elliott Brooks Refactor: Update the parameters for `DWDS.start` (#2231) yaml (https://github.com/dart-lang/yaml/compare/ae00187..9f0d649): 9f0d649 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153) 8e70ffb 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#152) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/4a9734d..a7e7fba): a7e7fba 2023-10-01 dependabot[bot] Bump actions/checkout from 3.6.0 to 4.1.0 (#58) f33e3d0 2023-10-01 dependabot[bot] Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#59) 8a380e8 2023-09-28 Sigurd Meldgaard Change AliasError to AliasException (#57) Change-Id: I22f88e36d2eceb03495dabcf1265e9043364e0bd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329260 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…mime, protobuf, pub_semver, sse, string_scanner, term_glyph, test, test_reflective_loader, typed_data, vector_math, web, webdriver Revisions updated by `dart tools/rev_sdk_deps.dart`. browser_launcher (https://github.com/dart-lang/browser_launcher/compare/f60df1d..c68ec25): c68ec25 2023-12-04 Kevin Moore drop outdated lints ecosystem (https://github.com/dart-lang/ecosystem/compare/805ab4f..79a1bc5): 79a1bc5 2023-12-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#204) c51c500 2023-12-01 dependabot[bot] Bump actions/github-script (#202) 64eeeee 2023-12-01 dependabot[bot] Bump peter-evans/create-or-update-comment (#203) 32461a7 2023-12-01 Moritz Upgrades to `health.yaml` (#201) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/2238a6b..ae48489): ae48489 2023-12-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#61) markdown (https://github.com/dart-lang/markdown/compare/3774ad0..d2e7903): d2e7903 2023-12-01 dependabot[bot] Bump subosito/flutter-action from 2.11.0 to 2.12.0 (#569) 42d32cb 2023-11-30 Kevin Moore Update to latest lints, require Dart ^3.1 (#568) mime (https://github.com/dart-lang/mime/compare/8ebf946..56359b0): 56359b0 2023-12-05 Yoshihiro Tanaka Detect HEIC/HEIF format by checking header bytes (#109) protobuf (https://github.com/dart-lang/protobuf/compare/dcec2ed..bb19774): bb19774 2023-11-29 Ömer Sinan Ağacan Revert `PbMap._wrappedMap` empty map value (#904) cf43230 2023-11-23 Ömer Sinan Ağacan Update getList and getMap return types (#903) 4e0bdff 2023-11-23 Ömer Sinan Ağacan Make wrapped lists in PbList monomorphic (#902) pub_semver (https://github.com/dart-lang/pub_semver/compare/f9e94ee..4572181): 4572181 2023-12-04 Kevin Moore drop outdated lints (#96) sse (https://github.com/dart-lang/sse/compare/1df63f2..8d2e2f0): 8d2e2f0 2023-12-01 dependabot[bot] Bump nanasess/setup-chromedriver (#99) c6501b3 2023-12-01 Kevin Moore Drop unneeded dep on pkg:test (#98) string_scanner (https://github.com/dart-lang/string_scanner/compare/a7105ef..ebc30a3): ebc30a3 2023-12-04 Kevin Moore Update to latest lints and cleanup (#67) term_glyph (https://github.com/dart-lang/term_glyph/compare/7c1eb9d..4c5a496): 4c5a496 2023-12-04 Kevin Moore drop outdated lints (#46) test (https://github.com/dart-lang/test/compare/a0a4d1e..9fffb48): 9fffb489 2023-12-01 dependabot[bot] Bump github/codeql-action from 2.22.5 to 2.22.8 (#2145) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/17d40bb..6edf535): 6edf535 2023-11-30 Kevin Moore Update lints, bump min SDK to ^3.1.0 (#56) typed_data (https://github.com/dart-lang/typed_data/compare/0b16bd2..6f6d81d): 6f6d81d 2023-12-04 Kevin Moore drop outdated lints (#78) vector_math (https://github.com/google/vector_math.dart/compare/cca3cf1..38a00c3): 38a00c3 2023-12-04 Kevin Moore Update to latest lints and cleanup (#309) cedd304 2023-12-04 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#307) web (https://github.com/dart-lang/web/compare/cffc2e3..865aeaf): 865aeaf 2023-12-01 Devon Carew update the CI workflow to test the generation script (#112) webdriver (https://github.com/google/webdriver.dart/compare/43ed1db..2c1b6f8): 2c1b6f8 2023-12-01 dependabot[bot] Bump nanasess/setup-chromedriver (#290) dc988d7 2023-12-01 Devon Carew update to the latest package:lints (#291) Change-Id: I2d898b6d772925146630777ef587d29a05288a3b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339720 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was originally filed by Ray.Rac...@gmail.com
What steps will reproduce the problem?
1.Write Dart code as proposed.
2.
3.
What is the expected output? What do you see instead?
Optional type annotation to be on the right of the identifier. Use of val to replace final and def to denote the start of a method/function definition.
What version of the product are you using? On what operating system?
All
Please provide any additional information below.
val x Int = 3
var y String = 'Gilad'
def rev (s String)String => s.reverse ()
Use of val of final is more intuitive, pithy aligns code nicely with var and def.
Placing the type on the right supports (requires) the use of a keyword to denote a method / function definition. Use of 'def' is suggested.
Primary Reason Not to Change.
The stated reason to keeping type annotations on the left is familiarity for the mainstream programmer as (I assume) many of the new Dart new comers will be from C#, Java.
There are as many non-Java people coming to Dart who will not have any basis. Those from JS, Ruby, Python will be familiar with 'def' for example.
Universally Java/C# people coming to Scala have been positive with this syntax as cleaner and enhancing readability. (Scala adoption issues center on the complex type system and not its base declaration syntax).
It is apparent that Dart has been painted, unfairly, as "its just Java". These small syntax changes,off a sense of "freshness" to the Dart language that will soon be appreciated by new comers.
Adaption has shown the barrier to new syntax is very low barrier and immediately appreciated by the majority of Java users for its basic elegance and cleaness.
People will be much more receptive to Dart from such a sense "newness" and "freshness" about it from such minor syntax cleanups yet retains all the core familiar concepts.
The text was updated successfully, but these errors were encountered: