Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/compiler/buildbot.py should exit with non-zero exit code if a step fails #2633

Closed
peter-ahe-google opened this issue Apr 18, 2012 · 12 comments
Closed

utils/compiler/buildbot.py should exit with non-zero exit code if a step fails #2633

peter-ahe-google opened this issue Apr 18, 2012 · 12 comments
Assignees
@peter-ahe-google
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

buildbot_annotated_steps runs all test steps even if one fails. Unfortunately, the exit code does not reflect the test status.
@peter-ahe-google
Copy link
Contributor Author

Added this to the Later milestone.
Removed Priority-Medium label.
Added Priority-Low label.

@kasperl
Copy link

kasperl commented Sep 3, 2012

Changed the title to: "utils/compiler/buildbot.py should exit with non-zero exit code if a step fails".

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed this from the Later milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Added this to the M2 milestone.
Removed Priority-Low label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed Priority-Medium label.
Added Priority-Low label.

@peter-ahe-google
Copy link
Contributor Author

Removed this from the M2 milestone.
Added this to the Later milestone.
Removed Priority-Low label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Is this still an issue, Peter? The file seems to have gone away.

Removed TriageForM5 label.
Added AssumedStale label.

@peter-ahe-google
Copy link
Contributor Author

The file is now called dart/tools/bots/compiler.py and the issue still exists.

Added Triaged label.

@peter-ahe-google
Copy link
Contributor Author

Removed Type-Defect label.
Added Type-Enhancement label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@peter-ahe-google peter-ahe-google self-assigned this Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@sigmundch sigmundch added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 22, 2018
dart-bot pushed a commit that referenced this issue Oct 14, 2020
@sigurdm
Bump pub
da9f410 
git log --oneline cf9795f3bb209504c349e20501f0b4b8ae31530c..f0c7771b38155d3829a60d60b5dba2784b100811
f0c7771b Set first version with null safety to 2.12 (#2684)
df1140af Warn from get, when mixed mode (#2590)
765778c0 Simplify test detection (#2682)
afd66ea2 Inline the single test asset. (#2681)
059e4796 Simplify the logic for unicode and colors in output (#2679)
35ddaec2 Dartify test tool (#2680)
62f26401 Example for User-Agent (#2678)
e8b4b114 fixes: #2670 pub global activate commands always exit cmd on windows. (#2671)
93e703b1 Improve stack traces in many tests (#2673)
5b540a39 Fix experiments tests for Dart 2.11 (#2672)
b0ac77d8 Bump dependency on pkg:analyzer (#2662)
73f0906e Removed @alwaysThrows (#2642)
88e0a83c Fixed bug in adding dependency to empty dependencies key (#2640)
135d9fa0 Pub add/remove now remove dependencies key if it makes them empty (#2639)
f4cc9673 Fix "pubpsec" typo (#2641)
4686d74d Adding an existing package is now a dataError (#2638)
1e93f47c Checks pubspec keys for potential typos (#2616)
fa5f51ef Vendor yaml_edit (#2633)
ac6d307f Adding a `pub remove` command (#2620)
9d236e00 Adding the `pub add` command (#2618)
04e237f7 Drop upper bound instead of using "any" while resolving in "pub outdated" (#2623)
93954f33 Use InternetAddress.tryParse over try/catch (#2626)
638c81c9 Refine publishing message (#2624)


Allow github


Embed pub as a library into dartdev

Change-Id: Iadc6acb5c3425dfb8848db89820e6c9c8caf16ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167574
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @sigmundch @kasperl @peter-ahe-google