Double.toRadixString not implemented

[terrylucas]

Even though my number is an int the VM some how thinks it's a double. Certainly implementing toRadixString will fix it but I'm wondering if there's a bigger problem that r1 is not an int but a double?

class Bug {
  static String convertToHexString(int r) {
    int r1 = Bug._changeTintShadeColor(r, .10);
    String rHex = Bug._numAs2DigitHex(r1);

    // TODO(terry) 15.toRadixString(16) return 'F' on Dartium not f as in JS.
    // bug: <http://code.google.com/p/dart/issues/detail?id=2670>
    return "$rHex".toLowerCase();
  }

  static String _numAs2DigitHex(int v) {
    String hex = "${v.toRadixString(16)}";
    if (hex.length == 1) {
      hex = "0${hex}";
    }
    return hex;
  }

  static num _clamp(num value, num min, num max) =>
      Math.max(Math.min(max, value), min);

  static int _changeTintShadeColor(num v, num delta) =>
      Bug._clamp((v + (255 * delta)).round(), 0, 255);
}

Bug.convertToHexString(10);

[terrylucas]

Looks like changing _numAs2DigitHex's line

    String hex = "${v.toRadixString(16)}";
to
    String hex = "${v.toInt().toRadixString(16)}";

Works around the problem. I've downgraded the bug.

---

Removed Priority-Critical label.
Added Priority-High label.

[madsager]

cc @floitschG.
Added Triaged label.

[DartBot]

This comment was originally written by @mhausner

---

Actually, everything works as intended here. r1 is a double because the delta parameter to _changeTintShadeColor is a double, so the expression v + (255 * .1) becomes double. round() and min() and max() will return double values.

the double value is assigned to int r1, which in non-checked mode is not a problem. If you run this code in checked mode, it would produce a type check error.

I just ran the code and realize that there is a problem even before the assignment to r1. The method toRadixString() is not implemented for double values, so you get an exception. You do need to convert the value to integer first, which is what your "workaround" does.

In any case, this is not a bug. I'll let Florian close the bug if he agrees with my assessment.

[DartBot]

This comment was originally written by @mhausner

---

I guess reading the summary would have helped and I wouldn't have had to "discover" the same toRadixString() issue. Nevertheless, the "bigger problem" you hint at is not a problem, as per my explanation.

[floitschG]

Agreed.

---

Added Duplicate label.
Marked as being merged into #1896.