dart:html requestAnimationFrame should hide browser differences

[jmesserly]

Some browsers like Chrome 19 (and earlier?) pass a different value to the callback timestamp compared to others like Safari on my Mac or Dartium (based on Chome 20). I'm not sure which one is right or where the API is headed... but it'd be nice to handle this in requestAnimationFrame.

Easiest way to try it is something like:
  window.requestAnimationFrame((num timestamp) => print('timestamp is: $timestamp');

[DartBot]

This comment was originally written by @bp74

---

Please check the following issues:

Issue #2185 - Browser-independent way of doing request animation frame.
Issue #2894 - requestAnimationFrame callback with "double" not "int" value.
Issue #3025 - dart2js breaks requestAnimationFrame implementation in IE9.

[sethladd]

See also Issue #4593

[sethladd]

Removed Area-Library label.
Added Area-HTML label.

[vsmenon]

Added this to the M1 milestone.

[vsmenon]

Issue #4593 has been merged into this issue.

[blois]

Set owner to @blois.
Added Accepted label.

[blois]

Anton- do you think you could take a look at this?

I have a preliminary CL here: https://chromiumcodereview.appspot.com/10910291/
This fixes the problem but redefines the return type of DartRequestAnimationFrameCallback::handleEvent which causes compilation errors. Not quite sure the best way to address that.

Thanks!

---

Set owner to antonm@google.com.
Removed Area-HTML label.
Added Area-Dartium, Triaged labels.

[DartBot]

This comment was originally written by antonm@google.com

---

looking into it now.

[DartBot]

This comment was originally written by antonm@google.com

---

Peter, I believe that after http://code.google.com/p/dart/source/detail?r=12440 your patch should just apply

---

Set owner to @blois.
Removed Area-Dartium label.
Added Area-HTML, Started labels.

[blois]

Anton- just tried this (http://code.google.com/p/dart/source/detail?r=12508) and it failed compiling dartium-lucid64-debug (all others compiled clean): http://chromegw.corp.google.com/i/client.dart/builders/dartium-lucid64-debug/builds/4824/steps/compile/logs/stdio

out/Debug/../../third_party/gold/gold64: error: out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_remaining.a(out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/../../../../../webcore_remaining/third_party/WebKit/Source/WebCore/bindings/dart/custom/DartRequestAnimationFrameCallbackCustom.o): multiple definition of 'WebCore::DartRequestAnimationFrameCallback::handleEvent(unsigned long long)'
out/Debug/../../third_party/gold/gold64: out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_bindings.a(out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/../../../../../webcore_bindings/gen/webkit/bindings/dart/DartDerivedSources06.o): previous definition here

Any ideas?

Thanks!

[blois]

Added Fixed label.