Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler error converted to warning in section 7.5.2: Factories #3078

Closed
gbracha opened this issue May 16, 2012 · 8 comments
Closed

Compiler error converted to warning in section 7.5.2: Factories #3078

gbracha opened this issue May 16, 2012 · 8 comments
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Milestone
M1

Comments

@gbracha
Copy link
Contributor

gbracha commented May 16, 2012

In section 7.5.2, the spec now reads:

It is a static warning if M is not the name of the immediately enclosing class or the name of an interface in the enclosing lexical scope.

This used to be an error. We need the analyzer to mark these as warnings before we can turn off the errors in the compiler and the VM.
@gbracha
Copy link
Contributor Author

gbracha commented May 16, 2012

Changed the title to: "Compiler error converted to warning in section 7.5.2: Factories".

@danrubel
Copy link

danrubel commented Jun 4, 2012

Added this to the M1 milestone.

@bwilkerson
Copy link
Member

Added Waiting label.

@scheglov
Copy link
Contributor

Set owner to @scheglov.
Added Accepted label.

@bwilkerson
Copy link
Member

Added Triaged label.

@scheglov
Copy link
Contributor

https://chromiumcodereview.appspot.com/10824256

Added Started label.

@scheglov
Copy link
Contributor

https://code.google.com/p/dart/source/detail?r=10520

Added Fixed label.

@kasperl
Copy link

kasperl commented Sep 3, 2012

Marked this as blocking #3080.

@gbracha gbracha added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Sep 3, 2012
@gbracha gbracha added this to the M1 milestone Sep 3, 2012
@gbracha gbracha mentioned this issue Jun 3, 2015
Closed
dart-bot pushed a commit that referenced this issue Sep 13, 2021
@sigurdm
Roll pub
a704116 
New commits in this version:

git -C third_party/pkg/pub log --oneline cd7a43f2109f7e5eb22e73c7f4e15d25fd57598e..d95c5713dda518ed53ada70e00789e6aadbfbe48
d95c5713 (HEAD, origin/master, origin/HEAD) Remove duplicate global invocation on Windows (#3055)
4c5198df master->main (#3101)
e793fd52 More tool/test.dart tweaks (#3097)
1b228edd Report retracted packages (#3093)
4fedb6c5 Tweak strict dependencies error message for `_validateBenchmarkTestTool` (#3087)
e608ab6e Improve test script (#3091)
abf702c4 Detect potential leaks in `dart pub publish`. (#3049)
9941c1f9 Fix broken simplification of prerelease constraints (#3078)
f0cdfa27 format (#3086)
5a1242c6 Fix unicode terminal detection windows (#2933)
58e2296d Dart format (#3084)
1426601c use incremental compilation in the tool/test.dart script (#3075)
9954f851 Fix a typo (#3062)
44489b31 Use relative import for path.dart (#2959)
77702ab1 Always precompile scripts before running them (#3074)

Change-Id: I913ab9e3b5bc7181d483a2de96ec4ad917028b75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213262
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
Roll Dart Documentation Generator from adc5a45ddafb to 621c9192cc24 (…
bdf8fcc 
…4 revisions)

https://dart.googlesource.com/dartdoc/+log/adc5a45ddafb..621c9192cc24

2022-07-12 srawlins@google.com Move annotation tests out of end-to-end test (#3078)
2022-07-11 srawlins@google.com Move test skip above test body (#3076)
2022-07-11 srawlins@google.com Remove ElementType.returnedFrom; was completely unused (#3077)
2022-07-09 srawlins@google.com Make Mixin.superclassConstraints late final non-nullable (#3075)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-ecosystem-gardener@grotations.appspotmail.com
Change-Id: I82e92bf6c915969b2ba72de470939673f63b4de9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251161
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Milestone
M1
Development

No branches or pull requests
5 participants
@scheglov @kasperl @danrubel @gbracha @bwilkerson