Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

communicate to user when analysis gives up [+2] #3428

Closed
pq opened this issue Jun 7, 2012 · 9 comments
Closed

communicate to user when analysis gives up [+2] #3428

pq opened this issue Jun 7, 2012 · 9 comments
Assignees
@danrubel
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
M1

Comments

@pq
Copy link
Member

pq commented Jun 7, 2012

For the second time in as many days folks have been hit by this issue (and pinged me about it).

Net-net: if we punt on analyzing an opened folder we need to tell the user that we've done so (and point them to the remedy).

Assigning to Luke for UX thoughts.
@alan-knight
Copy link
Contributor

I'm one of the ones who got hit. Basically, I noticed that when I added the larger folder it was grey, but didn't have any idea why, or how to find out. Everything seemed to work at the time, so I ignored it, and didn't notice that things weren't being syntax highlighted. I'm not sure what would be a better mechanism.

Perhaps one thing that might be useful is if a warning was added to the list of problems, saying that a particular file, or directory, was not being analyzed, so problems could not be listed. That might also get lost, but when it was noticed at least would be concrete and could say what to do.

@stevemessick
Copy link
Contributor

Let's talk about this. I'm sure we can create a reasonable UX.

cc @clayberg.
Set owner to @pq.

@clayberg
Copy link

clayberg commented Aug 7, 2012

All search results views (Search & Callers) should show a prominent warning to the user that the results are based on a partial analysis (e.g., incomplete and [potentially wrong!) and provide a link to a preference where the user could increase the analysis threshold. This came up today when Lars was showing me the editor and none of the search options were showing the correct results.

cc @danrubel.
Changed the title to: "communicate to user when analysis gives up [+2]".

@clayberg
Copy link

clayberg commented Aug 7, 2012

This is related to Issue #4387/

@lukechurch
Copy link
Contributor

Lets talk at our Friday meeting

@danrubel
Copy link

Is this fixed now that we have the open folder action showing analysis progress to the user?

@pq
Copy link
Member Author

pq commented Sep 3, 2012

This deserves more refinement but it's not M1-blocking. Moving to M2.

Removed this from the M1 milestone.
Added this to the M2 milestone.

@pq
Copy link
Member Author

pq commented Oct 15, 2012

I think this is no longer an issue. Feel free to close unless you feel otherwise.

Set owner to @danrubel.

@danrubel
Copy link

No longer an issue now that we display progress to the user, and continue to analyze until the user tells us otherwise by canceling.

Removed this from the M2 milestone.
Added this to the M1 milestone.
Added Fixed label.

@pq pq added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Oct 15, 2012
@pq pq added this to the M1 milestone Oct 15, 2012
@clayberg clayberg mentioned this issue Jun 3, 2015
Closed
copybara-service bot pushed a commit that referenced this issue Jun 5, 2023
@devoncarew
[deps] rev async, dartdoc, ffi, http, leak_tracker, lints, mockito, t…
03b2abf 
…est, tools, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/96c29d0..a506993):
  a506993  2023-06-01  Kevin Moore  Update testing SDK in CI (#245)
  9be3fc0  2023-06-01  Kevin Moore  Require Dart 2.19, use latest team lints (#244)

dartdoc (https://github.com/dart-lang/dartdoc/compare/39fe1a8..0c8feac):
  0c8feac6  2023-06-04  Sam Rawlins  Sort enum_test.dart (#3428)

ffi (https://github.com/dart-lang/ffi/compare/7f4acbd..f582ca0):
  f582ca0  2023-05-17  Daco Harkes  Rename `master` branch to `main` (#197)
  604451d  2023-05-16  Devon Carew  blast_repo fixes (#195)

http (https://github.com/dart-lang/http/compare/8834aec..5312366):
  5312366  2023-06-02  Brian Quinlan  Reland "support the nsurl session web socket api" (#950)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/cbbdeca..f17da61):
  f17da61  2023-06-02  Polina Cherkasova  Add constructor for retaining path. (#72)
  b70e538  2023-06-01  Polina Cherkasova  Fix connection issue. (#70)
  a80f253  2023-06-01  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.2 (#71)

lints (https://github.com/dart-lang/lints/compare/edc28ed..fc74ce0):
  fc74ce0  2023-06-02  Devon Carew  update the readme to clarify the package's goals (#130)
  4e4c18f  2023-06-02  Devon Carew  mv analysis_options file (#129)

mockito (https://github.com/dart-lang/mockito/compare/924f65c..cca4858):
  cca4858  2023-06-02  Ilya Yanok  Fix the unresolved types if used as ignored type-alias arguments
  8652886  2023-06-01  Googler  Prepare for NamedType breaking change in the analyzer.

test (https://github.com/dart-lang/test/compare/3276921..7a6c98d):
  7a6c98d0  2023-06-01  Konstantin Scheglov  Require analyzer 5.12.0, refactor InstanceCreationExpression type name extraction. (#2015)
  23bd4159  2023-06-01  Nate Bosch  Use switch expressions for switch/return pattern (#2027)
  06bdbb65  2023-06-01  Nate Bosch  Make State and Result enums (#2028)
  11805dc5  2023-06-01  Nate Bosch  Migrate to Dart 3 (#2024)

tools (https://github.com/dart-lang/tools/compare/389925f..8d6e8b8):
  8d6e8b8  2023-06-01  Kevin Moore  unified_analytics and graphs: cleanup lints, bump pkg deps (#108)

webdev (https://github.com/dart-lang/webdev/compare/f565d7f..b10d62b):
  b10d62b8  2023-06-02  Anna Gringauze  Support using scope in evaluateInFrame (#2122)
  c0300ce6  2023-06-02  Elliott Brooks  Included requested-by header in `ProxyServerAssetReader` (#2129)
  57699563  2023-06-01  dependabot[bot]  Bump actions/labeler from 4.0.3 to 4.0.4 (#2128)

Change-Id: Ia6114a0cbbe789f13e2c42399f53ff0e4d29d74a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307502
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danrubel danrubel

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
M1
Development

No branches or pull requests
6 participants
@pq @danrubel @lukechurch @alan-knight @stevemessick @clayberg