-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve on library imports #71
Comments
This comment was originally written by drfibonacci@google.com Added Area-Language, Triaged labels. |
This comment was originally written by carstenkl...@yahoo.de Well, having read through the specification once more, I find that most of what is stated above can just be ignored. The only thing left you might take into consideration when finalizing the specification is that the prefix must be an identifier since it is also to be used as a namespace. And since stringLiteralS normally include all strings, even those with whitespace, it is IMO mandatory that the prefix is a valid identifier of the language. |
See: https://github.com/dart-lang/linter/issues/1759 Addresses Object.noSuchMethod: 00:53 +313 -3: rule dart (config: nnbd) omit_local_variable_types [E] NoSuchMethodError: The getter 'declaredElement' was called on null. Receiver: null Tried calling: declaredElement #0 Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5) #1 ResolverVisitor.visitForStatementInScope (package:analyzer/src/generated/resolver.dart:3993:30) #2 ScopedVisitor.visitForStatement (package:analyzer/src/generated/resolver.dart:5477:7) #3 ForStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:4772:49) #4 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:7682:20) #5 BlockImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:1115:17) #6 ResolverVisitor.visitNode (package:analyzer/src/generated/resolver.dart:4286:10) #7 UnifyingAstVisitor.visitBlock (package:analyzer/dart/ast/visitor.dart:3128:31) #8 ScopedVisitor.visitBlock (package:analyzer/src/generated/resolver.dart:5187:13) #9 BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:1111:49) #10 BlockFunctionBodyImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:1070:13) #11 ResolverVisitor.visitNode (package:analyzer/src/generated/resolver.dart:4286:10) #12 UnifyingAstVisitor.visitBlockFunctionBody (package:analyzer/dart/ast/visitor.dart:3131:55) #13 ScopedVisitor.visitBlockFunctionBody (package:analyzer/src/generated/resolver.dart:5198:13) #14 ResolverVisitor.visitBlockFunctionBody (package:analyzer/src/generated/resolver.dart:3522:13) #15 BlockFunctionBodyImpl.accept (package:analyzer/src/dart/ast/ast.dart:1066:49) #16 FunctionExpressionImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:5088:12) #17 ResolverVisitor.visitNode (package:analyzer/src/generated/resolver.dart:4286:10) #18 UnifyingAstVisitor.visitFunctionExpression (package:analyzer/dart/ast/visitor.dart:3263:57) #19 ScopedVisitor.visitFunctionExpression (package:analyzer/src/generated/resolver.dart:5524:13) #20 ResolverVisitor.visitFunctionExpression (package:analyzer/src/generated/resolver.dart:4050:13) #21 FunctionExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:5082:49) #22 FunctionDeclarationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:4941:26) #23 ResolverVisitor.visitNode (package:analyzer/src/generated/resolver.dart:4286:10) #24 UnifyingAstVisitor.visitFunctionDeclaration (package:analyzer/dart/ast/visitor.dart:3256:59) #25 ScopedVisitor.visitFunctionDeclarationInScope (package:analyzer/src/generated/resolver.dart:5517:11) #26 ResolverVisitor.visitFunctionDeclarationInScope (package:analyzer/src/generated/resolver.dart:4025:11) #27 ScopedVisitor.visitFunctionDeclaration (package:analyzer/src/generated/resolver.dart:5510:7) #28 ResolverVisitor.visitFunctionDeclaration (package:analyzer/src/generated/resolver.dart:4016:13) #29 FunctionDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:4934:49) #30 ResolverVisitor.visitCompilationUnit (package:analyzer/src/generated/resolver.dart:3608:23) #31 CompilationUnitImpl.accept (package:analyzer/src/dart/ast/ast.dart:2140:49) #32 LibraryAnalyzer._resolveFile (package:analyzer/src/dart/analysis/library_analyzer.dart:680:10) #33 LibraryAnalyzer.analyzeSync.<anonymous closure> (package:analyzer/src/dart/analysis/library_analyzer.dart:151:7) #34 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:377:8) #35 LibraryAnalyzer.analyzeSync (package:analyzer/src/dart/analysis/library_analyzer.dart:150:11) #36 LibraryAnalyzer.analyze.<anonymous closure> (package:analyzer/src/dart/analysis/library_analyzer.dart:113:14) #37 _PerformanceTagImpl.makeCurrentWhile (package:analyzer/src/generated/utilities_general.dart:258:15) #38 LibraryAnalyzer.analyze (package:analyzer/src/dart/analysis/library_analyzer.dart:112:43) #39 AnalysisDriver._computeAnalysisResult.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:1261:63) #40 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:34:15) #41 AnalysisDriver._computeAnalysisResult (package:analyzer/src/dart/analysis/driver.dart:1237:20) #42 AnalysisDriver.getErrors (package:analyzer/src/dart/analysis/driver.dart:548:41) <asynchronous suspension> #43 LintDriver.analyze (package:analyzer/src/lint/analysis.dart:220:32) <asynchronous suspension> #44 DartLinter.lintFiles (package:analyzer/src/lint/linter.dart:87:36) <asynchronous suspension> #45 testRule.<anonymous closure> (file:///Users/pquitslund/src/repos/linter/test/rule_test.dart:262:54) <asynchronous suspension> #46 Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:27) <asynchronous suspension> #47 Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:242:15) <asynchronous suspension> #48 _rootRun (dart:async/zone.dart:1124:13) #49 _CustomZone.run (dart:async/zone.dart:1021:19) #50 _runZoned (dart:async/zone.dart:1516:10) #51 runZoned (dart:async/zone.dart:1463:12) #52 Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:239:5) #53 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:166:33) #54 _rootRun (dart:async/zone.dart:1124:13) #55 _CustomZone.run (dart:async/zone.dart:1021:19) #56 _runZoned (dart:async/zone.dart:1516:10) #57 runZoned (dart:async/zone.dart:1463:12) #58 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:165:13) <asynchronous suspension> #59 Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:392:25) <asynchronous suspension> #60 new Future.<anonymous closure> (dart:async/future.dart:176:37) #61 StackZoneSpecification._run (package:stack_trace/src/stack_zone_specification.dart:209:15) #62 StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:119:48) #63 _rootRun (dart:async/zone.dart:1120:38) #64 _CustomZone.run (dart:async/zone.dart:1021:19) #65 _CustomZone.runGuarded (dart:async/zone.dart:923:7) #66 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23) #67 StackZoneSpecification._run (package:stack_trace/src/stack_zone_specification.dart:209:15) #68 StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:119:48) #69 _rootRun (dart:async/zone.dart:1124:13) #70 _CustomZone.run (dart:async/zone.dart:1021:19) #71 _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23) #72 Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:21:15) #73 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:382:19) #74 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5) #75 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12) Change-Id: I15b2298f88ee986475736807ef8fd15133e18472 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120928 Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com>
…ackage_config, path, shelf, term_glyph, test_reflective_loader, webdev, webkit_inspection_protocol, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. cli_util (https://github.com/dart-lang/cli_util/compare/b0adbba..edcf1c3): edcf1c3 2022-11-15 Devon Carew blast_repo fixes (#71) csslib (https://github.com/dart-lang/csslib/compare/ba2eb2d..34203c0): 34203c0 2022-11-15 Kevin Moore blast_repo fixes (#154) dartdoc (https://github.com/dart-lang/dartdoc/compare/08e3098..dc502d0): dc502d08 2022-11-15 Sam Rawlins Move much PackageWarning logic _out_ of PackageGraph, into the enum. (#3251) ad651b15 2022-11-15 Sam Rawlins Move the e2e source-link test to a unit test (#3254) d14c680c 2022-11-11 Sam Rawlins Make many Strings in DocumentationComment non-nullable (#3243) 92afb9bb 2022-11-10 dependabot[bot] Bump github/codeql-action from 2.1.29 to 2.1.31 (#3246) http (https://github.com/dart-lang/http/compare/6339026..d56141d): d56141d 2022-11-11 Brian Quinlan Upgrade to ffigen ^7.2 and remove unnecessary casts (#820) d95a544 2022-11-10 Brian Quinlan Add a more complete implementation for `URLSessionTask`. (#818) intl (https://github.com/dart-lang/intl/compare/442193c..a127902): a127902 2022-11-16 Kevin Moore blast_repo fixes (#510) matcher (https://github.com/dart-lang/matcher/compare/6a9b83b..9051de0): 9051de0 2022-11-15 Kevin Moore blast_repo fixes (#197) mockito (https://github.com/dart-lang/mockito/compare/748e88e..347d3e4): 347d3e4 2022-11-14 Kevin Moore blast_repo fixes (#587) package_config (https://github.com/dart-lang/package_config/compare/cff98c9..abb4aec): abb4aec 2022-11-15 Kevin Moore blast_repo fixes (#127) path (https://github.com/dart-lang/path/compare/58ba22c..12ce876): 12ce876 2022-11-14 hellohuanlin Support more arguments in path.join API (#130) shelf (https://github.com/dart-lang/shelf/compare/5fd2593..1c21047): 1c21047 2022-11-11 Devon Carew update the no-response.yml configuration (#308) term_glyph (https://github.com/dart-lang/term_glyph/compare/ec7cf7b..822cd5b): 822cd5b 2022-11-15 Kevin Moore blast_repo fixes (#29) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/ef934b7..52b6753): 52b6753 2022-11-15 Kevin Moore blast_repo fixes (#42) webdev (https://github.com/dart-lang/webdev/compare/22f6271..3ec168f): 3ec168f 2022-11-15 Anna Gringauze Add --enable-experience flag and pass it to the expression compiler service (#1794) 72272dd 2022-11-10 Elliott Brooks (she/her) Include a settings page for configuring the Dart Debug Extension (#1776) 73839e7 2022-11-10 Elliott Brooks (she/her) Log entire exception message instead of first line (#1782) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/b825c8f..ddb624c): ddb624c 2022-11-14 Kevin Moore blast_repo fixes (#95) yaml (https://github.com/dart-lang/yaml/compare/fda5b15..f699275): f699275 2022-11-15 Devon Carew Merge pull request #131 from dart-lang/blast_repo-2022_11_15T20_23_04 8f6a5f7 2022-11-15 Kevin Moore blast_repo fixes Change-Id: I5d55d733b7f9256edf4f44229cc810e827c23f7d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270240 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Kevin Moore <kevmoo@google.com> Reviewed-by: Kevin Moore <kevmoo@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`. browser_launcher (https://github.com/dart-lang/browser_launcher/compare/5fa0bd6..2712dda): 2712dda 2022-12-13 Anna Gringauze Fix internal CI test failures (#35) dartdoc (https://github.com/dart-lang/dartdoc/compare/eb90a44..1f42216): 1f422163 2022-12-13 Sam Rawlins Bump to 6.1.5 (#3274) intl (https://github.com/dart-lang/intl/compare/234b291..6fb07f2): 6fb07f2 2022-12-14 Copybara-Service Merge pull request #520 from dart-lang:revto18 1f9815c 2022-12-14 Moritz Rev version in preparation for publish of 0.18.0 1d37c42 2022-12-13 Googler Internal change 708b85c 2022-12-13 Copybara-Service Merge pull request #498 from dart-lang:remove_intl_stream 2d9eca9 2022-09-28 moritz sort imports 08a35bd 2022-09-28 moritz Merge branch 'master' into remove_intl_stream 0fc6ab9 2022-09-28 moritz Changes as per review 4680742 2022-09-27 moritz rename to stack f687c72 2022-09-27 moritz changes as per review ef36013 2022-09-26 moritz add reference to benchmark 117c0cf 2022-09-26 moritz separate read and pop 434378a 2022-09-26 moritz move method e98c4aa 2022-09-26 moritz fix typo 9234540 2022-09-26 moritz rename file 024cffc 2022-09-26 moritz make it a tad faster c6f7b6a 2022-09-26 moritz some renaming 443c9e0 2022-09-26 moritz Remove StringIterator 1953002 2022-09-23 Nate Bosch Inline the extension 4dfdc1b 2022-09-22 Nate Bosch Simplify the IntlStream class mime (https://github.com/dart-lang/mime/compare/c0c4c47..273d454): 273d454 2022-12-13 tomk9 Add .dcm to extension map (#74) aacec32 2022-12-12 Kevin Moore Update to latest lints, bump min SDK to 2.18 (#77) 536db4f 2022-12-12 Kevin Moore blast_repo fixes (#79) 2343229 2022-12-12 Kevin Moore Add .msj (and change .js) to text/javascript (#76) mockito (https://github.com/dart-lang/mockito/compare/347d3e4..942dd03): 942dd03 2022-12-12 yanok Override `SmartFake.toString` to be super-verbose 5f97a43 2022-12-09 Sam Rawlins Stop using deprecated analyzer APIs 0660e61 2022-12-06 yanok Generate method overrides even then source lib is not null-safe cf7d851 2022-12-06 yanok Add override for `Object.operator==` in `SmartFake` 6b89e99 2022-12-02 yanok Automated g4 rollback of changelist 492410078. d11d010 2022-12-02 yanok Generate method overrides even then source lib is not null-safe sse (https://github.com/dart-lang/sse/compare/d396145..cfa93b1): cfa93b1 2022-12-14 Elliott Brooks (she/her) Add `package:js` to dependencies (#71) 00335e4 2022-12-13 Elliott Brooks (she/her) Update `package:sse` to `4.1.2`(#70) webdev (https://github.com/dart-lang/webdev/compare/3e2364e..317288a): 317288a 2022-12-14 Derek Xu Remove ChromeProxyService.setExceptionPauseMode() (#1820) bbe7143 2022-12-14 Elliott Brooks (she/her) Migrate `events_test.dart` to null-safety (#1819) 1d1c98f 2022-12-14 Elliott Brooks (she/her) Settings page, Dart Debugger panel, and Flutter Inspector panel match DevTools styles (#1815) a9b8887 2022-12-13 Elliott Brooks (she/her) Update tests that are incompatible with `3.0.0` (#1817) Change-Id: I08e555dc22e5577740fe43e91ff31e4601ac15f0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275781 Commit-Queue: Nate Bosch <nbosch@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
…g, mockito, package_config, shelf, string_scanner, test, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/f700e9a..f700e9a): f700e9a 2023-01-27 Devon Carew blast_repo fixes (#231) characters (https://github.com/dart-lang/characters/compare/4526aa8..4526aa8): 4526aa8 2023-01-30 Lasse R.H. Nielsen Update tables to Unicode 15.0. (#71) collection (https://github.com/dart-lang/collection/compare/a566328..a566328): a566328 2023-01-26 Devon Carew add a publish script; prep to publish (#267) dartdoc (https://github.com/dart-lang/dartdoc/compare/bc7bdc4..bc7bdc4): bc7bdc44 2023-01-30 dependabot[bot] Bump js from 0.6.5 to 0.6.7 (#3310) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/e73c4ad..e73c4ad): e73c4ad 2023-01-26 Devon Carew blast_repo fixes (#89) logging (https://github.com/dart-lang/logging/compare/399100a..399100a): 399100a 2023-01-26 Devon Carew add a publish script; prep to publish 1.1.1 (#128) mockito (https://github.com/dart-lang/mockito/compare/d2a8df1..d2a8df1): d2a8df1 2023-01-30 Kevin Moore Latest build_web_compilers, move to pkg:lints, fix breaks (#605) 13340b5 2023-01-30 dependabot[bot] Bump dart-lang/setup-dart from 1.3 to 1.4 (#600) package_config (https://github.com/dart-lang/package_config/compare/3fe81c4..3fe81c4): 3fe81c4 2023-01-30 Kevin Moore Support latest pkg:build_web_compilers, lints. Update min SDK (#129) shelf (https://github.com/dart-lang/shelf/compare/8fca9d9..8fca9d9): 8fca9d9 2023-01-26 Devon Carew blast_repo fixes (#326) string_scanner (https://github.com/dart-lang/string_scanner/compare/29e471e..29e471e): 29e471e 2023-01-30 dependabot[bot] Bump dart-lang/setup-dart from 1.3 to 1.4 (#53) test (https://github.com/dart-lang/test/compare/cec47c1..cec47c1): cec47c1c 2023-01-27 Nate Bosch Add missing pub requirements (#1878) c99d455e 2023-01-27 Nate Bosch Prepare to publish (#1877) 0e7ec6a7 2023-01-27 Nate Bosch Rename `Check` to `Subject` (#1875) 78382731 2023-01-27 Nate Bosch Add String.matches condition (#1874) 26e0e87b 2023-01-27 Nate Bosch Add Iterable.containsInOrder condition (#1873) c9232d6b 2023-01-27 Nate Bosch Rename `that` to `which` (#1872) 457166b3 2023-01-26 Nate Bosch Add missing dependency on package:lints (#1876) 193f2a0b 2023-01-26 Nate Bosch Retry instead of extend timeout for flaky Node tests (#1871) 7ad9b2c3 2023-01-26 Nate Bosch Overhaul async matchers (#1868) ca254546 2023-01-26 Nate Bosch Add a withQueue utility (#1870) 6ae2e5e9 2023-01-26 Nate Bosch Refactor tests to a new isRejectedBy utility (#1867) 5aeba66d 2023-01-26 Nate Bosch Use pubspec_overrides.yaml files (#1869) webdev (https://github.com/dart-lang/webdev/compare/ce9c581..ce9c581): ce9c581 2023-01-29 Anna Gringauze Validate only needed summaries in expression_compiler_service (#1920) Change-Id: I3ddb0ddeb3b989f6f9e78cd8aa6327aba5899018 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280078 Commit-Queue: Devon Carew <devoncarew@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
…, http_parser, pub_semver, shelf, term_glyph, test, typed_data, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/bd3ac85..b08471e): b08471e 2023-02-09 Sigurd Meldgaard Suggest command based on aliases (#235) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1124692..53871c5): 53871c5 2023-02-09 Kevin Moore Migrate to dart_flutter_team_lints, cleanup (#69) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/b1efcf7..a6a0891): a6a0891 2023-02-09 Kevin Moore Require Dart 2.19, update lints to dart_flutter_team_lints (#84) dartdoc (https://github.com/dart-lang/dartdoc/compare/494a6be..3931595): 39315954 2023-02-13 Devon Carew enable additional lints (#3336) a52639e7 2023-02-10 Sam Rawlins Use markdown 7 (#3332) glob (https://github.com/dart-lang/glob/compare/a828420..f378dc8): f378dc8 2023-02-13 Kevin Moore Update to dart_flutter_team_lints, also cleaned up markdown (#71) http (https://github.com/dart-lang/http/compare/8386923..f4b365e): f4b365e 2023-02-07 Sigurd Meldgaard Remove dependency on package:path (#865) http_parser (https://github.com/dart-lang/http_parser/compare/1c0c17a..b3b283b): b3b283b 2023-02-08 Kevin Moore Bump min SDK to 2.17 (#69) pub_semver (https://github.com/dart-lang/pub_semver/compare/e9c600c..c0e6ea7): c0e6ea7 2023-02-12 Devon Carew Update CHANGELOG.md (#81) 0d62000 2023-02-12 Kevin Moore Fix new type error, use dart_flutter_team_lints (#80) shelf (https://github.com/dart-lang/shelf/compare/9d1fb8a..707c8b2): 707c8b2 2023-02-07 Kevin Moore move to pkg:dart_flutter_team_lints (#330) term_glyph (https://github.com/dart-lang/term_glyph/compare/520784d..d275a8f): d275a8f 2023-02-12 Kevin Moore Fix CI, update lints (#34) test (https://github.com/dart-lang/test/compare/da7c667..b5e70db): b5e70db5 2023-02-10 Jacob MacDonald Add notes about versioning and publishing to CONTRIBUTING.md (#1929) 2773daa6 2023-02-09 Jacob MacDonald update changelog version in test to use ## (#1926) 9e3072e1 2023-02-09 Danny Tuppeny Handle absolute paths on Windows (#1923) 07380027 2023-02-09 Nicholas Shahan Fix typo in migration doc (#1924) f49fc16a 2023-02-09 Kevin Moore Add auto-publish configuration (#1922) 5bf28959 2023-02-08 Nate Bosch Add link to file issue on README (#1921) ef81f471 2023-02-08 Nate Bosch Fix directory name for issue templates (#1920) f3bfda9d 2023-02-08 Nate Bosch Add issue templates (#1919) a80f4fd0 2023-02-08 Devon Carew Refactor top level and package README files (#1918) 0f4558fe 2023-02-07 Nate Bosch Prepare to publish test_core and test (#1917) 39f498c8 2023-02-06 Nate Bosch Minor readme improvements (#1913) 2cb07a3f 2023-02-06 Nate Bosch Rename matches to matchesPattern, accept Pattern (#1907) ba6fb1c9 2023-02-06 Jacob MacDonald Support running tests by absolute file: uri (#1893) ffeaec66 2023-02-06 Nate Bosch Take Condition for async nesting expectations (#1896) cdd8c395 2023-02-06 Daniel Chevalier update vm_service to support 11.0.0 (#1910) f2d97bf2 2023-02-06 Nate Bosch Expand the doc comment for Context (#1902) typed_data (https://github.com/dart-lang/typed_data/compare/6fbbd95..f858046): f858046 2023-02-12 Kevin Moore fix ci, update analysis options (#61) webdev (https://github.com/dart-lang/webdev/compare/6255c85..0bae2be): 0bae2be 2023-02-10 Elliott Brooks (she/her) Fix lifeline connection logic (#1952) 4a41cf9 2023-02-10 Anna Gringauze Support records (#1919) d6229e3 2023-02-09 Anna Gringauze Fix failure on getting a list with out of range offset (#1947) f1b15e8 2023-02-09 Anna Gringauze Fix incorrect list element count (#1944) fff4865 2023-02-09 Elliott Brooks (she/her) Add missing IDs to inspector panel (#1946) 47287e3 2023-02-08 Elliott Brooks (she/her) [MV3 Debug Extension] Extension sets the `ide` query parameter for the DevTools URI (#1943) 1136d51 2023-02-08 Elliott Brooks (she/her) Catch exceptions in unawaited `Futures` (#1938) 2cad786 2023-02-07 Anna Gringauze Cleanup getObject logic for handling offsets and counts (#1936) b399e94 2023-02-06 Elliott Brooks (she/her) Pull out `dart:io`-dependent functions from`/src/utilities/shared.dart` into `/src/utilities/server.dart` (#1942) Change-Id: I64bdc5485665ca4c13a331ae7a6c77b1cd3208d8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282802 Commit-Queue: Devon Carew <devoncarew@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
…ctor, browser_launcher, characters, clock, collection, convert, crypto, csslib, dartdoc, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, logging, matcher, mime, package_config, path, pool, pub_semver, source_maps, source_span, sse, stack_trace, stream_channel, term_glyph, test, test_descriptor, test_process, tools, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/7a5e3b0..5ac2ba1): 5ac2ba1 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#238) f77b1dc 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#239) async (https://github.com/dart-lang/async/compare/f454380..0127813): 0127813 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#236) 100445b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#237) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/53871c5..d5f8837): d5f8837 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#70) a8a55e6 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#71) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/725534a..e591ec4): e591ec4 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#86) 38bf5b8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#87) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/16e6ad3..28dc03d): 28dc03d 2023-04-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#45) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/bc2dc4e..ba4e028): ba4e028 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#41) characters (https://github.com/dart-lang/characters/compare/3281cc7..ba8d557): ba8d557 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#79) 60cae68 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#80) clock (https://github.com/dart-lang/clock/compare/984642e..93d9f56): 93d9f56 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#48) collection (https://github.com/dart-lang/collection/compare/30fd0f8..9db854d): 9db854d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#278) convert (https://github.com/dart-lang/convert/compare/83886e3..8812e40): 8812e40 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79) d28dc33 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#80) crypto (https://github.com/dart-lang/crypto/compare/9efb888..8a03816): 8a03816 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#143) csslib (https://github.com/dart-lang/csslib/compare/d32bdd4..5836863): 5836863 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#177) dartdoc (https://github.com/dart-lang/dartdoc/compare/9be04e0..1a7952b): 1a7952b1 2023-04-03 dependabot[bot] Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#3382) fixnum (https://github.com/dart-lang/fixnum/compare/f8379d9..92ec336): 92ec336 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#108) f14fd19 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#109) glob (https://github.com/dart-lang/glob/compare/f378dc8..eaa878b): eaa878b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#73) c0c7e66 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#74) html (https://github.com/dart-lang/html/compare/08643e9..57b747d): 57b747d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#209) 51c9910 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#210) http (https://github.com/dart-lang/http/compare/74f9d3d..ffb4438): ffb4438 2023-04-04 Brian Quinlan Fix maxRedirects documentation to mention ClientException rather than RedirectException (#907) ad0e1cf 2023-04-03 Bahaa Fathi Yousef Fix some spelling (#885) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/7bd190c..e0b5d35): e0b5d35 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#53) 3bbaf22 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#52) http_parser (https://github.com/dart-lang/http_parser/compare/b3b283b..bbe37dd): bbe37dd 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#70) f0527a8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#71) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/aea3bea..5da2705): 5da2705 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#94) d6ab373 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#95) logging (https://github.com/dart-lang/logging/compare/abef371..787030a): 787030a 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#133) be6a20e 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#134) matcher (https://github.com/dart-lang/matcher/compare/61f4347..cb6b68c): cb6b68c 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#216) mime (https://github.com/dart-lang/mime/compare/1a51be0..2d8496d): 2d8496d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#90) 3b39378 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#91) package_config (https://github.com/dart-lang/package_config/compare/74ac1cb..7e09db1): 7e09db1 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#132) 6dc4072 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#133) path (https://github.com/dart-lang/path/compare/cd37179..23e3319): 23e3319 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#140) pool (https://github.com/dart-lang/pool/compare/338bfb4..650e5d3): 650e5d3 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#66) pub_semver (https://github.com/dart-lang/pub_semver/compare/c0e6ea7..860e3d8): 860e3d8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#82) 12eca92 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#83) source_maps (https://github.com/dart-lang/source_maps/compare/a112e98..0a4b030): 0a4b030 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#76) e753fea 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#75) source_span (https://github.com/dart-lang/source_span/compare/3951ba5..b739fbf): b739fbf 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#94) c6547c2 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#95) sse (https://github.com/dart-lang/sse/compare/8c3efdc..11e83a0): 11e83a0 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79) stack_trace (https://github.com/dart-lang/stack_trace/compare/6ceb191..9c1b1c5): 9c1b1c5 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#128) 56a09db 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#129) stream_channel (https://github.com/dart-lang/stream_channel/compare/fe0f5e4..74646ea): 74646ea 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#88) term_glyph (https://github.com/dart-lang/term_glyph/compare/d275a8f..f6856e2): f6856e2 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#36) test (https://github.com/dart-lang/test/compare/a01b185..8ea4298): 8ea42987 2023-04-04 Jakub Vrána Make tests compatible with Strict CSP (#1987) 49f7e17a 2023-04-03 dependabot[bot] Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#1982) 1a4f76b2 2023-04-03 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.9 (#1985) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/1d4a967..aa11162): aa11162 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49) 226fe86 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#50) test_process (https://github.com/dart-lang/test_process/compare/f76d0b8..946bc27): 946bc27 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#40) 441f585 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#41) tools (https://github.com/dart-lang/tools/compare/d40ca93..0304fbb): 0304fbb 2023-04-04 Elias Yishak Add catcherror callback for `sendData` (#72) 6d1dedf 2023-04-04 Daco Harkes [cli_config] Pub badges (#71) 561dce2 2023-04-04 Daco Harkes [cli_config] Bump version (#68) d3909a4 2023-04-04 Daco Harkes Fix windows path resolving (#67) 77cf078 2023-04-03 Daco Harkes [cli_config] Fix optionalString validValues (#69) usage (https://github.com/dart-lang/usage/compare/399770f..0698711): 0698711 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#190) 2cdb5e3 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#189) watcher (https://github.com/dart-lang/watcher/compare/5968409..00aa79b): 00aa79b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140) 598038f 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#141) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/e2fe7f6..40eb236): 40eb236 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#260) 1823444 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#261) webdev (https://github.com/dart-lang/webdev/compare/b139649..e887316): e887316c 2023-04-03 Elliott Brooks Prepare DWDS for version `19.0.0` release (#2068) 704d5086 2023-04-03 Elliott Brooks Fix typo (#2069) 2e6e1b63 2023-04-03 Anna Gringauze Fix getObject failure on record class. (#2063) yaml (https://github.com/dart-lang/yaml/compare/0f80b12..56dfaf4): 56dfaf4 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140) d925d7e 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#141) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/fbc5cb3..386fd33): 386fd33 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49) Change-Id: I986c83f657631813a32e360fbb90f42f7d43440a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293280 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
…est, tools, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/96c29d0..a506993): a506993 2023-06-01 Kevin Moore Update testing SDK in CI (#245) 9be3fc0 2023-06-01 Kevin Moore Require Dart 2.19, use latest team lints (#244) dartdoc (https://github.com/dart-lang/dartdoc/compare/39fe1a8..0c8feac): 0c8feac6 2023-06-04 Sam Rawlins Sort enum_test.dart (#3428) ffi (https://github.com/dart-lang/ffi/compare/7f4acbd..f582ca0): f582ca0 2023-05-17 Daco Harkes Rename `master` branch to `main` (#197) 604451d 2023-05-16 Devon Carew blast_repo fixes (#195) http (https://github.com/dart-lang/http/compare/8834aec..5312366): 5312366 2023-06-02 Brian Quinlan Reland "support the nsurl session web socket api" (#950) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/cbbdeca..f17da61): f17da61 2023-06-02 Polina Cherkasova Add constructor for retaining path. (#72) b70e538 2023-06-01 Polina Cherkasova Fix connection issue. (#70) a80f253 2023-06-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#71) lints (https://github.com/dart-lang/lints/compare/edc28ed..fc74ce0): fc74ce0 2023-06-02 Devon Carew update the readme to clarify the package's goals (#130) 4e4c18f 2023-06-02 Devon Carew mv analysis_options file (#129) mockito (https://github.com/dart-lang/mockito/compare/924f65c..cca4858): cca4858 2023-06-02 Ilya Yanok Fix the unresolved types if used as ignored type-alias arguments 8652886 2023-06-01 Googler Prepare for NamedType breaking change in the analyzer. test (https://github.com/dart-lang/test/compare/3276921..7a6c98d): 7a6c98d0 2023-06-01 Konstantin Scheglov Require analyzer 5.12.0, refactor InstanceCreationExpression type name extraction. (#2015) 23bd4159 2023-06-01 Nate Bosch Use switch expressions for switch/return pattern (#2027) 06bdbb65 2023-06-01 Nate Bosch Make State and Result enums (#2028) 11805dc5 2023-06-01 Nate Bosch Migrate to Dart 3 (#2024) tools (https://github.com/dart-lang/tools/compare/389925f..8d6e8b8): 8d6e8b8 2023-06-01 Kevin Moore unified_analytics and graphs: cleanup lints, bump pkg deps (#108) webdev (https://github.com/dart-lang/webdev/compare/f565d7f..b10d62b): b10d62b8 2023-06-02 Anna Gringauze Support using scope in evaluateInFrame (#2122) c0300ce6 2023-06-02 Elliott Brooks Included requested-by header in `ProxyServerAssetReader` (#2129) 57699563 2023-06-01 dependabot[bot] Bump actions/labeler from 4.0.3 to 4.0.4 (#2128) Change-Id: Ia6114a0cbbe789f13e2c42399f53ff0e4d29d74a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307502 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
…, typed_data Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/449478c..2a39574): 2a395741 2023-06-07 Sam Rawlins Seal mustachio nodes (#3433) d5bb24b2 2023-06-07 Sam Rawlins Convert Tuples to Records and split a helper out from findCanonicalModelElementFor (#3432) http_parser (https://github.com/dart-lang/http_parser/compare/1ef3e56..19466c0): 19466c0 2023-06-07 Kevin Moore Require Dart 3.0, update lints (#74) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/f17da61..fc45bec): fc45bec 2023-06-07 Polina Cherkasova Break the leak tracker code to packages. (#80) path (https://github.com/dart-lang/path/compare/f8d15c2..592505f): 592505f 2023-06-07 Kevin Moore Require Dart 3.0, update lints (#146) pool (https://github.com/dart-lang/pool/compare/a10a0f9..c6b1b2c): c6b1b2c 2023-06-07 Kevin Moore Require Dart 3.0, update lints (#71) term_glyph (https://github.com/dart-lang/term_glyph/compare/9d8956f..4daa34e): 4daa34e 2023-06-07 Kevin Moore Require Dart 3.0, update lints (#39) typed_data (https://github.com/dart-lang/typed_data/compare/693f48e..8d29573): 8d29573 2023-06-07 Kevin Moore Require Dart 3.0, update lints (#67) Change-Id: I11fe765858ba970f13a2051abee34abf910f4698 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308161 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was originally filed by carstenkl...@yahoo.de
In the specs it reads
libraryImport:
'#' 'import' '(' stringLiteral (', ' 'prefix:' stringLiteral)? ') ';'
;
This is utterly redundant.
I would like to suggest that this will be reduced to either
libraryImport:
'#' 'import' stringLiteral 'as' stringLiteral;
;
or, by making this more 'compatible' to CommonJS
libraryImport:
stringLiteral = 'import' stringLiteral;
;
The extra opening and closing brackets are not really necessary unless
import was a function, which it definitely is not.
And if it were, then the '#' hash before the 'import' keyword should be removed, leaving us with
libraryImport:
stringLiteral = 'import' '(' stringLiteral ')';
;
Having this, one could also just import specific elements declared by the library, such as
foo = import('bar').foo;
or, using the import...as notation
libraryImport:
'import' '(' stringLiteral ')' ('as' stringLiteral)?;
;
However, using stringLiteral for the prefix is rather weak, as it definitely needs to be an identifier.
The text was updated successfully, but these errors were encountered: