support scrollTop as an Attribute of Element [patch]

[DartBot]

This issue was originally filed by jeffbailey@google.com

---

What steps will reproduce the problem?

1. textWindow.scrollTop = textWindow.scrollHeight;

only knows about scrollHeight, not scrollTop and issues a warning
at compile time.

This appears to be the canonical way to cause a window to be scrolled all the way to the bottom.

What version of the product are you using? On what operating system?

Path: .
URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/client/html
Repository Root: http://dart.googlecode.com/svn
Repository UUID: 260f80e4-7a28-3924-810f-c04153c831b5
Revision: 1856
Node Kind: directory
Schedule: normal
Last Changed Author: jacobr@google.com
Last Changed Rev: 1771
Last Changed Date: 2011-11-22 17:12:10 -0800 (Tue, 22 Nov 2011)

Please provide any additional information below.

[DartBot]

This comment was originally written by jeffbailey@google.com

---

Index: client/html/src/Element.dart
===================================================================

--- client/html/src/Element.dart (revision 1856)
+++ client/html/src/Element.dart (working copy)
@@ -141,6 +142,10 @­@
 
   void set scrollTop(int value);
 

• int get scrollWidth();

• int get scrollHeight();

   bool get spellcheck();
 
   void set spellcheck(bool value);
Index: client/html/src/ElementWrappingImplementation.dart
===================================================================

--- client/html/src/ElementWrappingImplementation.dart (revision 1856)
+++ client/html/src/ElementWrappingImplementation.dart (working copy)
@@ -721,6 +734,10 @­@
  
   void set scrollTop(int value) { _ptr.scrollTop = value; }
 

• int get scrollWidth() { return _ptr.scrollWidth; }

• int get scrollHeight() { return _ptr.scrollHeight; }

   /** @­domName getClientRects */
   Future<ElementRect> get rect() {
     return _createMeasurementFuture(

Index: client/html/src/DocumentFragmentWrappingImplementation.dart
===================================================================

--- client/html/src/DocumentFragmentWrappingImplementation.dart (revision 1856)
+++ client/html/src/DocumentFragmentWrappingImplementation.dart (working copy)
@@ -349,6 +358,18 @­@
       "Document fragments don't support scrolling.");
   }
 

• int get scrollWidth() {
• throw new UnsupportedOperationException(

•  "Document fragments don't support scrolling.");
  
• }

• int get scrollHeight() {
• throw new UnsupportedOperationException(

•  "Document fragments don't support scrolling.");
  
• }

   void set spellcheck(bool value) {
      throw new UnsupportedOperationException(
       "Spellcheck can't be set for document fragments.");

---

Changed the title to: "support scrollTop as an Attribute of Element [patch]".

[DartBot]

This comment was originally written by drfibonacci@google.com

---

Added Area-UI, Triaged labels.

[DartBot]

This comment was originally written by jeffbailey@google.com

---

Assigning per Jacob's request.

---

Set owner to @jacob314.

[DartBot]

This comment was originally written by jeffbailey@google.com

[DartBot]

This comment was originally written by zundel@google.com

---

I'm wondering why in the html library we only have setters for scrollTop and scrollLeft and not getters as well. I think its supposed to be a read/write property on the DOM.

http://api.dartlang.org/html/Element.html#set:scrollTop
http://api.dartlang.org/html/Element.html#set:scrollLeft

[DartBot]

This comment was originally written by zundel@google.com

---

(I found Element.rect() and see it returns a Future so maybe its because reading this property forces a layout)

[DartBot]

This comment was originally written by jeffbailey@google.com

---

My understanding is that yes, that's why it's attached to a Future.

My argument when I met the developers in person is that this is the Wrong Thing because it doesn't let me, the developer, decide when I'm willing to take that performance penalty in exchange for not having to use a callback in the middle of some code.

[vsmenon]

Removed Area-UI label.
Added Area-DOM label.

[vsmenon]

cc @jacob314.
Set owner to @vsmenon.
Added this to the M1 milestone.

[iposva-google]

Removed Area-DOM label.
Added Area-HTML label.

[vsmenon]

Removed the owner.

[vsmenon]

Removed this from the M1 milestone.
Added this to the M2 milestone.

[blois]

Removed this from the M2 milestone.
Added this to the Later milestone.

[DartBot]

This comment was originally written by amouravski@google.com

---

This appears to be fixed.

---

Added AssumedStale label.