ElementAttributeMap.[]= fails in Dartium build on SVGElement sample #1877
Assignees
Comments
|
This comment was originally written by antonm@google.com Set owner to antonm@google.com. |
|
This comment was originally written by antonm@google.com This is due missing number to string conversion: Element.setAttribute accepts only Strings as a name and a value. I believe this should be fixed either in dart:html or in the code itself. I'd vote for dart:html fix. Jacob, wdyt? Set owner to @jacob314. |
|
Patch under review. Was able to implement this in Frog without degrading performance more than 1%. Added Started label. |
|
Added Fixed label. |
copybara-service bot
pushed a commit
that referenced
this issue
Jan 10, 2023
…_server, http_parser, logging, mockito, path, pool, shelf, source_map_stack_trace, sse, stream_channel, term_glyph, test, typed_data, watcher, web_socket_channel, webdev, webkit_inspection_protocol, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. cli_util (https://github.com/dart-lang/cli_util/compare/5a8e8ee..32bc077): 32bc077 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#73) clock (https://github.com/dart-lang/clock/compare/6b8b7bf..65e8a13): 65e8a13 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#42) csslib (https://github.com/dart-lang/csslib/compare/d776535..7054945): 7054945 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#157) dartdoc (https://github.com/dart-lang/dartdoc/compare/29a1bbf..c4ab682): c4ab6824 2023-01-10 Sam Rawlins Regenerate so latest analyzer is happy (#3293) fixnum (https://github.com/dart-lang/fixnum/compare/714381c..71f0d4d): 71f0d4d 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#103) glob (https://github.com/dart-lang/glob/compare/7adf833..4579281): 4579281 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#68) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/beb40a7..cce5080): cce5080 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#48) http_parser (https://github.com/dart-lang/http_parser/compare/16a4f34..6f73e4a): 6f73e4a 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#66) logging (https://github.com/dart-lang/logging/compare/b525d5c..34ed68f): 34ed68f 2023-01-09 Kevin Moore Move to new analyzer language settings (#126) mockito (https://github.com/dart-lang/mockito/compare/942dd03..9cc958a): 9cc958a 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts path (https://github.com/dart-lang/path/compare/1299791..9768908): 9768908 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#133) pool (https://github.com/dart-lang/pool/compare/713e631..ad4e2a7): ad4e2a7 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#60) shelf (https://github.com/dart-lang/shelf/compare/32e342d..a44e95e): a44e95e 2023-01-10 Kevin Moore Fix doc comment references (#323) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/e5f9564..adea3e5): adea3e5 2023-01-09 Sam Rawlins Migrate no-implicit-casts to strict-casts (#32) sse (https://github.com/dart-lang/sse/compare/3c37edb..be426a2): be426a2 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#74) stream_channel (https://github.com/dart-lang/stream_channel/compare/0a7800a..3b99268): 3b99268 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#84) term_glyph (https://github.com/dart-lang/term_glyph/compare/2bf4594..8cd9318): 8cd9318 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#31) test (https://github.com/dart-lang/test/compare/3415089..932a652): 932a652b 2023-01-09 Nate Bosch Add a Map operator[] extension (#1830) 1f2e963e 2023-01-09 Nate Bosch Add Future.doesNotComplete condition (#1827) typed_data (https://github.com/dart-lang/typed_data/compare/dbf81a7..9c209b9): 9c209b9 2023-01-09 Sam Rawlins Migrate no-implicit-casts to strict-casts (#58) watcher (https://github.com/dart-lang/watcher/compare/2e0db71..3b49c7e): 3b49c7e 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#134) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/ebd0fe9..28d7b82): 28d7b82 2023-01-10 Kevin Moore Fix CI link in readme (#248) c6ce895 2023-01-09 Sam Rawlins Update analysis_options.yaml (#247) webdev (https://github.com/dart-lang/webdev/compare/49f97b8..094ee97): 094ee97 2023-01-10 Anna Gringauze Add back setExceptionPauseMode (#1871) 2e65ddf 2023-01-10 Anna Gringauze Prepare for dart 3.0 alpha breaking changes (#1880) 2e2587a 2023-01-10 Elliott Brooks (she/her) Add hotfix instructions to DWDS (#1876) fe39123 2023-01-10 Elliott Brooks (she/her) Re-enable `reload_tests` (#1877) e71c0e3 2023-01-09 Anna Gringauze Fix crash on processing devtools event (#1875) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/ddb624c..15244ff): 15244ff 2023-01-09 Kevin Moore Add cron to CI (#97) yaml (https://github.com/dart-lang/yaml/compare/02be51e..b2fce6c): b2fce6c 2023-01-10 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#134) Change-Id: I4fb257fe7c697fab562f4d18e4ea50c5903b4cd8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278807 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Jan 31, 2023
…g, mockito, package_config, shelf, string_scanner, test, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/f700e9a..f700e9a): f700e9a 2023-01-27 Devon Carew blast_repo fixes (#231) characters (https://github.com/dart-lang/characters/compare/4526aa8..4526aa8): 4526aa8 2023-01-30 Lasse R.H. Nielsen Update tables to Unicode 15.0. (#71) collection (https://github.com/dart-lang/collection/compare/a566328..a566328): a566328 2023-01-26 Devon Carew add a publish script; prep to publish (#267) dartdoc (https://github.com/dart-lang/dartdoc/compare/bc7bdc4..bc7bdc4): bc7bdc44 2023-01-30 dependabot[bot] Bump js from 0.6.5 to 0.6.7 (#3310) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/e73c4ad..e73c4ad): e73c4ad 2023-01-26 Devon Carew blast_repo fixes (#89) logging (https://github.com/dart-lang/logging/compare/399100a..399100a): 399100a 2023-01-26 Devon Carew add a publish script; prep to publish 1.1.1 (#128) mockito (https://github.com/dart-lang/mockito/compare/d2a8df1..d2a8df1): d2a8df1 2023-01-30 Kevin Moore Latest build_web_compilers, move to pkg:lints, fix breaks (#605) 13340b5 2023-01-30 dependabot[bot] Bump dart-lang/setup-dart from 1.3 to 1.4 (#600) package_config (https://github.com/dart-lang/package_config/compare/3fe81c4..3fe81c4): 3fe81c4 2023-01-30 Kevin Moore Support latest pkg:build_web_compilers, lints. Update min SDK (#129) shelf (https://github.com/dart-lang/shelf/compare/8fca9d9..8fca9d9): 8fca9d9 2023-01-26 Devon Carew blast_repo fixes (#326) string_scanner (https://github.com/dart-lang/string_scanner/compare/29e471e..29e471e): 29e471e 2023-01-30 dependabot[bot] Bump dart-lang/setup-dart from 1.3 to 1.4 (#53) test (https://github.com/dart-lang/test/compare/cec47c1..cec47c1): cec47c1c 2023-01-27 Nate Bosch Add missing pub requirements (#1878) c99d455e 2023-01-27 Nate Bosch Prepare to publish (#1877) 0e7ec6a7 2023-01-27 Nate Bosch Rename `Check` to `Subject` (#1875) 78382731 2023-01-27 Nate Bosch Add String.matches condition (#1874) 26e0e87b 2023-01-27 Nate Bosch Add Iterable.containsInOrder condition (#1873) c9232d6b 2023-01-27 Nate Bosch Rename `that` to `which` (#1872) 457166b3 2023-01-26 Nate Bosch Add missing dependency on package:lints (#1876) 193f2a0b 2023-01-26 Nate Bosch Retry instead of extend timeout for flaky Node tests (#1871) 7ad9b2c3 2023-01-26 Nate Bosch Overhaul async matchers (#1868) ca254546 2023-01-26 Nate Bosch Add a withQueue utility (#1870) 6ae2e5e9 2023-01-26 Nate Bosch Refactor tests to a new isRejectedBy utility (#1867) 5aeba66d 2023-01-26 Nate Bosch Use pubspec_overrides.yaml files (#1869) webdev (https://github.com/dart-lang/webdev/compare/ce9c581..ce9c581): ce9c581 2023-01-29 Anna Gringauze Validate only needed summaries in expression_compiler_service (#1920) Change-Id: I3ddb0ddeb3b989f6f9e78cd8aa6327aba5899018 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280078 Commit-Queue: Devon Carew <devoncarew@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by @financecoding
What steps will reproduce the problem?
What is the expected output? What do you see instead?
Expected to see bars on the x and y axis http://goo.gl/SfIKj .
Dartium throws this error:
Exception: String expected
Stack Trace: 0. Function: 'ElementImplementation._setAttribute@1c3f8015' url: '/b/build/slave/dartium-mac-inc/build/src/xcodebuild/DerivedSources/Release/webkit/bindings/dart/generated/dart/ElementImplementation.dart' line:219 col:3
1. Function: 'ElementImplementation.setAttribute' url: '/b/build/slave/dartium-mac-inc/build/src/xcodebuild/DerivedSources/Release/webkit/bindings/dart/generated/dart/ElementImplementation.dart' line:213 col:18
2. Function: 'ElementAttributeMap.[]=' url: 'dart:htmlimpl' line:22509 col:26
3. Function: 'ElementWrappingImplementation.set:attributes' url: 'dart:htmlimpl' line:22771 col:17
4. Function: 'SVGSamples.drawlines' url: 'file:///tmp/gist-1925967/SVGSamples.dart' line:19 col:24
5. Function: 'SVGSamples.run' url: 'file:///tmp/gist-1925967/SVGSamples.dart' line:6 col:14
6. Function: '::main' url: 'file:///tmp/gist-1925967/SVGSamples.dart' line:54 col:23
What version of the product are you using? On what operating system?
Chromium 19.0.1050.0 (Developer Build 123195)
OS Mac OS X
WebKit 535.22 (Source/WebCore/Configurations@189)
JavaScript V8 3.9.8
DartVM r4589
Flash 11.1.102.55
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_3) AppleWebKit/535.22 (KHTML, like Gecko) Chrome/19.0.1050.0 (Dart) Safari/535.22
Command Line /Users/adam/Documents/DartEditor/dart/Chromium.app/Contents/MacOS/Chromium -psn_0_5817740 --flag-switches-begin --flag-switches-end
Executable Path /Users/adam/Documents/DartEditor/dart/Chromium.app/Contents/MacOS/Chromium
Profile Path /Users/adam/Library/Application Support/Chromium/Default
10:29:41-adam@Adams-MacBook-Air:/tmp/gist-1925967
$ uname -a
Darwin Adams-MacBook-Air.local 11.3.0 Darwin Kernel Version 11.3.0: Thu Jan 12 18:47:41 PST 2012; root:xnu-1699.24.23~1/RELEASE_X86_64 x86_64
DartEditor and Dartium downloaded on Feb 26, from the CI servers
wget http://gsdview.appspot.com/dart-editor-archive-continuous/latest/DartBuild-macosx.cocoa.x86_64.zip
wget http://commondatastorage.googleapis.com/dartium-archive/continuous/dartium-mac.zip
Please provide any additional information below.
The gist includes the generated .js file as reference.
The text was updated successfully, but these errors were encountered: