CCE in LibraryUnit

[bwilkerson]

I don't have the steps to reproduce, but ran across the ClassCastException below. The code is assuming that a method name is always an identifier, but that is not true.

---

!SUBENTRY 1 com.google.dart.tools.core 4 0 2011-11-04 09:24:10.602
!MESSAGE Failed to parse file:/Users/brianwilkerson/dart/testing/b337.dart
!STACK 0
java.lang.ClassCastException: com.google.dart.compiler.ast.DartParameterizedNode cannot be cast to com.google.dart.compiler.ast.DartIdentifier
    at com.google.dart.compiler.ast.LibraryUnit$1.visitMethodDefinition(LibraryUnit.java:311)
    at com.google.dart.compiler.ast.LibraryUnit$1.visitMethodDefinition(LibraryUnit.java:1)
    at com.google.dart.compiler.ast.DartMethodDefinition.accept(DartMethodDefinition.java:90)
    at com.google.dart.compiler.ast.DartNodeTraverser.visit(DartNodeTraverser.java:413)
    at com.google.dart.compiler.ast.DartUnit.visitChildren(DartUnit.java:99)
    at com.google.dart.compiler.ast.DartNodeTraverser.visitNode(DartNodeTraverser.java:54)
    at com.google.dart.compiler.ast.DartNodeTraverser.visitUnit(DartNodeTraverser.java:391)
    at com.google.dart.compiler.ast.LibraryUnit.populateTopLevelNodes(LibraryUnit.java:324)
    at com.google.dart.compiler.DartCompiler$Compiler.parseOutOfDateFiles(DartCompiler.java:286)
    at com.google.dart.compiler.DartCompiler$Compiler.updateAndResolve(DartCompiler.java:201)
    at com.google.dart.compiler.DartCompiler$Compiler.access$4(DartCompiler.java:190)
    at com.google.dart.compiler.DartCompiler.analyzeLibrary(DartCompiler.java:1165)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.secureAnalyzeLibrary(DartCompilerUtilities.java:725)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities$ResolverRunnable.run(DartCompilerUtilities.java:421)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities$CompilerRunner.runSafe(DartCompilerUtilities.java:92)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.resolveUnit(DartCompilerUtilities.java:708)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.resolveUnit(DartCompilerUtilities.java:690)
    at com.google.dart.tools.core.internal.operation.ReconcileWorkingCopyOperation.makeConsistent(ReconcileWorkingCopyOperation.java:126)
    at com.google.dart.tools.core.internal.operation.ReconcileWorkingCopyOperation.executeOperation(ReconcileWorkingCopyOperation.java:210)
    at com.google.dart.tools.core.internal.operation.DartModelOperation.run(DartModelOperation.java:374)
    at com.google.dart.tools.core.internal.operation.DartModelOperation.runOperation(DartModelOperation.java:441)
    at com.google.dart.tools.core.internal.model.CompilationUnitImpl.reconcile(CompilationUnitImpl.java:1357)
    at com.google.dart.tools.ui.internal.text.dart.DartReconcilingStrategy$1.run(DartReconcilingStrategy.java:159)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at com.google.dart.tools.ui.internal.text.dart.DartReconcilingStrategy.reconcile(DartReconcilingStrategy.java:134)
    at com.google.dart.tools.ui.internal.text.dart.DartReconcilingStrategy.reconcile(DartReconcilingStrategy.java:102)
    at com.google.dart.tools.ui.internal.text.functions.CompositeReconcilingStrategy.reconcile(CompositeReconcilingStrategy.java:93)
    at com.google.dart.tools.ui.internal.text.functions.DartCompositeReconcilingStrategy.reconcile(DartCompositeReconcilingStrategy.java:120)
    at org.eclipse.jface.text.reconciler.MonoReconciler.process(MonoReconciler.java:77)
    at com.google.dart.tools.ui.internal.text.functions.DartReconciler.process(DartReconciler.java:387)
    at org.eclipse.jface.text.reconciler.AbstractReconciler$BackgroundThread.run(AbstractReconciler.java:206)

[scheglov]

Set owner to @scheglov.
Added Started label.

[scheglov]

It looks that main problem is that we allow parsing factory as library top level declaration.

factory foo<T>() {}

[bwilkerson]

I would expect this to also be a problem if there is a constructor with a qualified name:

  class Point {
    Point.zero() {...}
  }

because the method's name (unless I'm misunderstanding) is "MyClass.factory", which can't be represented by a simple identifier.

[scheglov]

I can not reproduce for constructor qualified name.
Original exception happens in LibraryUnit.populateTopLevelNodes() where it is really not expected to have method with qualified name.

OTOH MemberElementBuilder.buildConstructor() handles Class.name constructor name.

Fixed in trunk.
Now we will report such bad factory method just as normal top level DartMethodDefinition, without factory modifier. We will also mark it with error.

---

Added Fixed label.