IDE tooling (analysis server) implementation for named arguments anywhere

[devoncarew]

This is the analysis server work for the named arguments anywhere feature.

For addition information, see

• main tracking issue (Implement named arguments anywhere feature #47451)
• language issue (Allow named function arguments anywhere in the argument list language#1072)

The following is a list of the individual features that need to be considered.

• Quick Assists
• Closing Labels (brianwilkerson, NA)
• Code Completion (scheglov)
• documentSymbol
• Quick Fixes (support for new features in existing fixes)
• Quick Fixes (new fixes)
• Flutter Outline (scheglov)
• Code Folding (brianwilkerson, NA)
• Hovers (brianwilkerson, NA)
• Implemented Markers (brianwilkerson, NA)
• Navigation (scheglov)
• Occurrences (scheglov)
• Organize Imports (brianwilkerson, NA)
• Outline (brianwilkerson, NA)
• Overrides Markers (brianwilkerson, NA)
• Refactorings (scheglov)
• Search - Find References (scheglov)
• Search - Member Declarations (brianwilkerson, NA)
• Search - Member References (brianwilkerson, NA)
• Search - Top-level Declarations (brianwilkerson, NA)
• selectionRange
• Semantic Highlights (scheglov)
• signatureHelp
• Sort Members (brianwilkerson, NA)
• Type Hierarchy (brianwilkerson, NA)

[jacob314]

Fyi @jwren for impact on the Dart IntelliJ plugin.
Fyi @bwilkerson for integration with the analysis server.

[jwren]

@devoncarew From the tooling and completion standpoint this is an unfortunate change, previously we could be smart enough to know the types of each required parameter before recommending the named arguments, now they'll be conflated.

[bwilkerson]

I don't think it will be that bad. If the user is trying to enter a new argument then it can either be a positional argument or a named argument. We won't know which one, but if it's a positional argument we can still know the context type and if it's a named argument then we can still suggest all of the names that have not already been used for positional arguments. We just have to suggest both sets of possible completions when both are valid. Not ideal, but hopefully not too bad.

…

On Fri, Oct 29, 2021, 7:06 PM Jaime Wren ***@***.***> wrote: @devoncarew <https://github.com/devoncarew> From the tooling and completion standpoint this is an unfortunate change, previously we could be smart enough to know the types of each required parameter before recommending the named arguments, now they'll be conflated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47578 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMR5K7OEZKCROUUNXSFRETUJNHITANCNFSM5HAEWTLA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[devoncarew]

FYI, the IntelliJ specific pieces are tracked here: #47592.

[jacob314]

Currently we are not very aggressive at showing completions that match the type so I don't expect much of a regression.
For Flutter I don't expect this change will have any impact at least initially as Widget Flutter APIs with named arguments tend not have any positional arguments.
We could think about how we can use our autocomplete quality metrics to verify there will be minimal regression for existing code and revisit in a few months to make sure that is still the case after APIs and usage evolves due to this change.

[itsjustkevin]

@jacob314 are we complete with this work?

[itsjustkevin]

@bwilkerson do we need to move some of this work to 2.18?

[bwilkerson]

@scheglov

[scheglov]

I did all pieces that I wanted to do, or have knowledge about.
The rest looks as LSP specific, about which I don't know much.

[bwilkerson]

@DanTup

[DanTup]

I had a look through selectionRange and signatureHelp but I can't see anything that should need changing. Was the list above compiled from use of some specific APIs, or was it just a general list of features to check?

[bwilkerson]

It's just a general list of features to check.