Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE tooling (analysis server) implementation for super-initializer parameters #48067

Closed
20 of 25 tasks
Tracked by #48055
devoncarew opened this issue Jan 4, 2022 · 4 comments
Closed
20 of 25 tasks
Tracked by #48055

IDE tooling (analysis server) implementation for super-initializer parameters #48067

devoncarew opened this issue Jan 4, 2022 · 4 comments
Assignees
@bwilkerson
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@devoncarew
Copy link
Member

devoncarew commented Jan 4, 2022 •
edited by srawlins
Loading

This is the analysis server work for the super initializing parameters feature.

For addition information, see

The following is a list of the individual features that need to be considered.

  • Quick Assists
  • Closing Labels (brianwilkerson, NA)
  • Code Completion (scheglov)
  • documentSymbol (brianwilkerson, NA)
  • Quick Fixes (support for new features in existing fixes)
  • Quick Fixes (new fixes)
  • Flutter Outline (brianwilkerson, NA)
  • Code Folding (brianwilkerson, NA)
  • Hovers (scheglov)
  • Implemented Markers (brianwilkerson, NA)
  • Navigation (scheglov)
  • Occurrences
  • Organize Imports (brianwilkerson, NA)
  • Outline (brianwilkerson, NA)
  • Overrides Markers (brianwilkerson, NA)
  • Refactorings (scheglov)
  • Search - Find References (scheglov)
  • Search - Member Declarations (scheglov, NA)
  • Search - Member References (scheglov, NA)
  • Search - Top-level Declarations (scheglov, NA)
  • selectionRange
  • Semantic Highlights (scheglov)
  • signatureHelp
  • Sort Members (brianwilkerson, NA)
  • Type Hierarchy (brianwilkerson, NA)
@devoncarew devoncarew mentioned this issue Jan 4, 2022
Closed
23 tasks
@devoncarew devoncarew changed the title IDE tooling (analysis server) implementation for super-initializer parameters (todo:) IDE tooling (analysis server) implementation for super-initializer parameters Jan 4, 2022
@devoncarew devoncarew added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-server labels Jan 4, 2022
@stereotype441
Copy link
Member

Note: in our planning meeting on Dec 13, it was suggested that when the user hovers over an optional super parameter that inherits a default value from the corresponding parameter on the base class, the IDE should show the default value that's being inherited from the base class constructor. Doing so requires work in the analysis server, and possibly in some of the IDE integration logic.

@jacob314
Copy link
Member

Fyi @pq this is another language feature where I think having a lint and quick fix to show users how to use this pattern would be great.

@pq
Copy link
Member

pq commented Jan 24, 2022

Tracking lint work in: dart-lang/linter#3174

@devoncarew devoncarew assigned bwilkerson and unassigned jacob314 Jan 27, 2022
copybara-service bot pushed a commit that referenced this issue Feb 2, 2022
@srawlins
For existing fixes, add super-parameter and named-args-anywhere tests
b9b1252 
Bug: #48067, #47578
Change-Id: Iaef317459c7e6901296475163959ad92a6c880b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231070
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
@bwilkerson
Copy link
Member

I'm going to close this. If there are specific bugs or enhancements, please open issues for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pq @stereotype441 @jacob314 @devoncarew @bwilkerson