Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate FrontendServerDdcStrategyProvider and FrontendServerRequireStrategyProvider Description #2517

Closed
Tracked by #2516
jyameo opened this issue Nov 4, 2024 · 0 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:dwds triaged

Comments

@jyameo
Copy link
Contributor

jyameo commented Nov 4, 2024

The classes FrontendServerDdcStrategyProvider and FrontendServerRequireStrategyProvider currently share a lot of common logic and fields. To improve maintainability and reduce redundancy, we should refactor these classes to inherit from a single parent class, FrontendServerStrategyProvider, which will contain shared methods and properties. Each class can then implement only the unique parts required for their respective strategies.

@bkonyi bkonyi added P1 A high priority bug; for example, a single project is unusable or has many test failures triaged labels Nov 6, 2024
jyameo added a commit that referenced this issue Nov 12, 2024
…reStrategyProvider under a shared parent class. - [#2517](https://gith… (#2518)

* Consolidate  and  under a shared parent class. - [#2517](#2517)

* clean up lib/src/loaders/frontend_server_strategy_provider.dart

* updated copyright date, make T extend loadstrategy and define strategies as late

* code formatting

* combine load strategies into one file and make fields/methods private

* updated path to load strategy providers and added a throw statement when new module format (ddc library bundle) is requested
@jyameo jyameo closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:dwds triaged
Projects
None yet
Development

No branches or pull requests

2 participants