Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate FrontendServerDdcStrategyProvider and FrontendServerRequireStrategyProvider under a shared parent class. - [#2517](https://gith… #2518

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

jyameo
Copy link
Contributor

@jyameo jyameo commented Nov 4, 2024

Consolidate FrontendServerDdcStrategyProvider and FrontendServerRequireStrategyProvider under a shared parent class. - #2517.

@jyameo
Copy link
Contributor Author

jyameo commented Nov 4, 2024

cc @bkonyi @derekxu16

@jyameo jyameo requested a review from srujzs November 4, 2024 22:15
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less duplicated code, yay! Thanks!

dwds/lib/src/loaders/frontend_server_require.dart Outdated Show resolved Hide resolved
@jyameo jyameo merged commit 18ab1d5 into dart-lang:main Nov 12, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants