Convert to create-react-app #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:external is not supported by the css-loader used by create-react-app
This reverts commit 197cf45.
|
I will add the server in a separate PR. Building static output is fine for now, but the server will be required to set html title/description so link previews (i.e. when linking in discord) can show build information. The server is also necessary to collect some data (upgrade components) used for #6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert everything to create-react-app.
Todo
Stuff that worked in the old version and needs to be added to the create-react-version.
Custom Serviceworker(best done separately after Added options to allow for overrides to workbox-webpack-plugin facebook/create-react-app#5369 lands)Generate favicons/icons and add them to manifest(static is fine for now)