Gear #6
Open
Gear #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/selectors/skills/weapons.js
…of custom build task
# Conflicts: # src/actions/general.js # src/reducers/index.js
This could happen when equipping two identical rings.
# Conflicts: # src/actions/general.js # src/components/StatsOverview/style.css
# Conflicts: # src/components/StatsOverview/StatsOverview.jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP, do not merge yet.
Translations for attribute names (done in masterCritDamage->Ferocity, …)Old PR text, before changing to hardcoded attributes
First implementation for the gear panel, still needs lots of work:
It's always needed anyway, but users will generally look at the above-the-fold content first and we can load it later to reduce the time until the first useful paint. Downside: stat calculation doesn't work until gear is loaded.