Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable gmp if targeting darwin on aarch64 when on 'auto' #52

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Nov 9, 2022

Why?

macOS Ventura causes the GMP test suite to fail, which in turn causes the library to behave erratically. Until such errata are rectified upstream by libgmp, we have automatic backend selection pick the easy backend if targeting macOS on Apple Silicon.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM utACK

Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM utACK

@PastaPastaPasta PastaPastaPasta merged commit 6ff4392 into dashpay:develop Nov 10, 2022
@kwvg kwvg deleted the darwin_aarch64_gmp_excl branch May 28, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants