build: enforce minimum versions of libgmp based on arch and platform #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvg
changed the title
kwvg
force-pushed
the
darwin_gmp
branch
2 times, most recently
from
ab2ea36 to
8d182a8
Compare
5 tasks
`AC_PROG_CC_C99` was deprecated in autoconf 2.70 and is succeeded by `AC_PROG_CC` (which also includes checks made by `AM_PROG_CC_C_O`, also deprecated). Removing deprecated macros should keep autoconf happy.
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
UdjinM6
approved these changes
Oct 4, 2024
5 tasks
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Oct 8, 2024
9dad525 build: set `-march` irrespective of target operating system (Kittywhiskers Van Gogh) 82b4405 build: update gmp to 6.3.0 (Kittywhiskers Van Gogh) Pull request description: ## Additional Information After [bls-signatures#92](dashpay/bls-signatures#92), GMP is re-enabled for Apple Silicon macOS targets so long as GMP 6.3.0 or higher is used. GMP significantly contributes to performance improvements in bls-signatures, generally to the tune of ~50% ([source](dashpay/bls-signatures#93 (comment))). The URL has been changed based on guidance from the Homebrew recipe for `gmp` ([source](https://github.com/Homebrew/homebrew-core/blob/51c899140c84d38dfa4c4fe623c859e6241504a0/Formula/g/gmp.rb#L44-L45)). ## Breaking Changes None expected. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK [9dad525](9dad525) Tree-SHA512: fbab727b9aa331f3eadd0573b925bc222380732782642cd4e12d670162cc0c45bf14edc8f99227960dc894f968f1d3f22496f0da7aca898ecb8db41d3a504f2b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
bls-signatures#52 was merged in due to a bug in libgmp (source) that resulted in erratic behavior certain macOS environments. This has since been resolved with GMP 6.3.0 (source) and is available with Homebrew (source). Ubuntu 20.04 (
focal) distributes GMP 6.2.0 (source) and Debian 11 (bullseye) distributes GMP 6.2.1 (source) and these versions work fine withdashblsin their respective environments.As the bug only affects Apple Silicon Macs running macOS Ventura and above, we need to test against a minimum version differentiated by platform and architecture. This pull request aims to do that.
Additional Information
aarch64) macOS hosts will be 6.3.0 regardless of macOS version and 6.2.0 on all other platforms.