Skip to content

refactor: resolve various warnings during build or by clippy #1505

refactor: resolve various warnings during build or by clippy

refactor: resolve various warnings during build or by clippy #1505

Re-run triggered March 9, 2024 17:16
Status Success
Total duration 6m 5s
Artifacts

tests.yml

on: pull_request
Build JS packages  /  Build JS
2m 43s
Build JS packages / Build JS
Matrix: Build Docker images
Determine changed packages
15s
Determine changed packages
Rust crates security audit
35s
Rust crates security audit
JS dependency versions check
9s
JS dependency versions check
JS NPM security audit
13s
JS NPM security audit
JS code security audit  /  Run Code QL
2m 6s
JS code security audit / Run Code QL
Packages functional tests  /  Run functional tests
4m 7s
Packages functional tests / Run functional tests
Matrix: Test Suite
Matrix: Dashmate E2E tests
Matrix: JS packages
Matrix: Rust packages
Fit to window
Zoom out
Zoom in

Annotations

145 warnings
Determine changed packages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS dependency versions check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust crates security audit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: rustsec/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust crates security audit
4 warnings found!
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
Build JS packages / Build JS
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, actions/setup-node@v3, mozilla-actions/sccache-action@v0.0.3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dapi-grpc) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dapi-grpc) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dapi-grpc) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dapi-grpc) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dapi-grpc) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (dpp) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dpp) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
very complex type used. Consider factoring parts into `type` definitions: packages/rs-dpp/src/document/document_factory/v0/mod.rs#L174
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-dpp/src/document/document_factory/v0/mod.rs:174:24 | 174 | let documents: Vec<( | ________________________^ 175 | | DocumentTransitionActionType, 176 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 177 | | )> = documents_iter.into_iter().collect(); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
very complex type used. Consider factoring parts into `type` definitions: packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs#L183
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs:183:24 | 183 | let documents: Vec<( | ________________________^ 184 | | DocumentTransitionActionType, 185 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 186 | | )> = documents_iter.into_iter().collect(); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
module has the same name as its containing module: packages/rs-dpp/src/identity/mod.rs#L10
warning: module has the same name as its containing module --> packages/rs-dpp/src/identity/mod.rs:10:1 | 10 | mod identity; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
large size difference between variants: packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs#L28
warning: large size difference between variants --> packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs:28:1 | 28 | / pub enum AssetLockProof { 29 | | Instant(#[bincode(with_serde)] InstantAssetLockProof), | | ----------------------------------------------------- the largest variant contains at least 640 bytes 30 | | Chain(#[bincode(with_serde)] ChainAssetLockProof), | | ------------------------------------------------- the second-largest variant contains at least 40 bytes 31 | | } | |_^ the entire enum is at least 640 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 29 | Instant(#[bincode(with_serde)] Box<InstantAssetLockProof>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~
Rust packages (dpp) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
module has the same name as its containing module: packages/rs-dpp/src/util/cbor_value/mod.rs#L11
warning: module has the same name as its containing module --> packages/rs-dpp/src/util/cbor_value/mod.rs:11:1 | 11 | mod cbor_value; | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
module has the same name as its containing module: packages/rs-dpp/src/errors/consensus/basic/json_schema_error/mod.rs#L1
warning: module has the same name as its containing module --> packages/rs-dpp/src/errors/consensus/basic/json_schema_error/mod.rs:1:1 | 1 | pub mod json_schema_error; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
module has the same name as its containing module: packages/rs-dpp/src/tests/utils/mod.rs#L5
warning: module has the same name as its containing module --> packages/rs-dpp/src/tests/utils/mod.rs:5:1 | 5 | mod utils; | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
Rust packages (dpp) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dpp) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (drive) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused import: `UserFeeIncrease`: packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/mod.rs#L9
warning: unused import: `UserFeeIncrease` --> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/mod.rs:9:37 | 9 | use crate::prelude::{IdentityNonce, UserFeeIncrease}; | ^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `UserFeeIncrease`: packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/v0/mod.rs#L10
warning: unused import: `UserFeeIncrease` --> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/v0/mod.rs:10:37 | 10 | use crate::prelude::{IdentityNonce, UserFeeIncrease}; | ^^^^^^^^^^^^^^^
unused import: `UserFeeIncrease`: packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/v0/v0_methods.rs#L11
warning: unused import: `UserFeeIncrease` --> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/v0/v0_methods.rs:11:37 | 11 | use crate::prelude::{IdentityNonce, UserFeeIncrease}; | ^^^^^^^^^^^^^^^
unused import: `UserFeeIncrease`: packages/rs-dpp/src/state_transition/state_transitions/identity/identity_update_transition/v0/v0_methods.rs#L22
warning: unused import: `UserFeeIncrease` --> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_update_transition/v0/v0_methods.rs:22:37 | 22 | use crate::prelude::{IdentityNonce, UserFeeIncrease}; | ^^^^^^^^^^^^^^^
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs#L44
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs:44:10 | 44 | ) -> ( | __________^ 45 | | BTreeMap<String, Vec<(KeyID, Purpose)>>, 46 | | Vec<(KeyID, Purpose)>, 47 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs#L173
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs:173:10 | 173 | ) -> Result<(RootHash, BTreeMap<[u8; 32], Option<DataContract>>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/query/conditions.rs#L465
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/query/conditions.rs:465:10 | 465 | ) -> Result<(BTreeMap<String, Self>, Option<Self>, Option<Self>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Rust packages (drive) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (drive-abci) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused import: `UserFeeIncrease`: packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/mod.rs#L9
warning: unused import: `UserFeeIncrease` --> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/mod.rs:9:37 | 9 | use crate::prelude::{IdentityNonce, UserFeeIncrease}; | ^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `UserFeeIncrease`: packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/v0/mod.rs#L10
warning: unused import: `UserFeeIncrease` --> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/v0/mod.rs:10:37 | 10 | use crate::prelude::{IdentityNonce, UserFeeIncrease}; | ^^^^^^^^^^^^^^^
unused import: `UserFeeIncrease`: packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/v0/v0_methods.rs#L11
warning: unused import: `UserFeeIncrease` --> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/v0/v0_methods.rs:11:37 | 11 | use crate::prelude::{IdentityNonce, UserFeeIncrease}; | ^^^^^^^^^^^^^^^
unused import: `UserFeeIncrease`: packages/rs-dpp/src/state_transition/state_transitions/identity/identity_update_transition/v0/v0_methods.rs#L22
warning: unused import: `UserFeeIncrease` --> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_update_transition/v0/v0_methods.rs:22:37 | 22 | use crate::prelude::{IdentityNonce, UserFeeIncrease}; | ^^^^^^^^^^^^^^^
module has the same name as its containing module: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L11
warning: module has the same name as its containing module --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:11:1 | 11 | mod update_masternode_identities; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
Rust packages (drive-abci) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L58
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:58:56 | 58 | pub previous_height_chain_lock_validating_quorums: Option<( | ________________________________________________________^ 59 | | u32, 60 | | u32, 61 | | Option<u32>, 62 | | BTreeMap<QuorumHash, ThresholdBlsPublicKey>, 63 | | )>, | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L143
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:143:9 | 143 | Option<(u32, u32, Option<u32>, Vec<(Bytes32, ThresholdBlsPublicKey)>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L438
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:438:10 | 438 | ) -> &mut Option<( | __________^ 439 | | u32, 440 | | u32, 441 | | Option<u32>, 442 | | BTreeMap<QuorumHash, ThresholdBlsPublicKey>, 443 | | )>; | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L459
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:459:10 | 459 | ) -> Option<&( | __________^ 460 | | u32, 461 | | u32, 462 | | Option<u32>, 463 | | BTreeMap<QuorumHash, ThresholdBlsPublicKey>, 464 | | )>; | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Rust packages (drive-abci) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive-abci) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (drive-abci) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (rs-dapi-client) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (rs-dapi-client) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (rs-dapi-client) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (rs-dapi-client) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
use of a fallible conversion when an infallible one could be used: packages/rs-dapi-client/src/mock.rs#L152
warning: use of a fallible conversion when an infallible one could be used --> packages/rs-dapi-client/src/mock.rs:152:32 | 152 | let key = e.finalize().try_into().map_err(|e| { | ^^^^^^^^ help: use: `into` | = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
Rust packages (rs-dapi-client) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (rs-sdk) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (rs-sdk) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (rs-sdk) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused import: `dpp::prelude::Identifier`: packages/rs-drive/src/common/mod.rs#L63
warning: unused import: `dpp::prelude::Identifier` --> packages/rs-drive/src/common/mod.rs:63:5 | 63 | use dpp::prelude::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `dpp::version::PlatformVersion`: packages/rs-drive/src/common/mod.rs#L67
warning: unused import: `dpp::version::PlatformVersion` --> packages/rs-drive/src/common/mod.rs:67:5 | 67 | use dpp::version::PlatformVersion; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `dpp::data_contracts`: packages/rs-drive/src/drive/contract/contract_fetch_info.rs#L3
warning: unused import: `dpp::data_contracts` --> packages/rs-drive/src/drive/contract/contract_fetch_info.rs:3:5 | 3 | use dpp::data_contracts; | ^^^^^^^^^^^^^^^^^^^
unused import: `dpp::system_data_contracts::load_system_data_contract`: packages/rs-drive/src/drive/contract/contract_fetch_info.rs#L5
warning: unused import: `dpp::system_data_contracts::load_system_data_contract` --> packages/rs-drive/src/drive/contract/contract_fetch_info.rs:5:5 | 5 | use dpp::system_data_contracts::load_system_data_contract; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `platform_version::version::PlatformVersion`: packages/rs-drive/src/drive/contract/contract_fetch_info.rs#L13
warning: unused import: `platform_version::version::PlatformVersion` --> packages/rs-drive/src/drive/contract/contract_fetch_info.rs:13:5 | 13 | use platform_version::version::PlatformVersion; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Rust packages (rs-sdk) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused import: `dpp::fee::SignedCredits`: packages/rs-drive/src/drive/credit_pools/mod.rs#L50
warning: unused import: `dpp::fee::SignedCredits` --> packages/rs-drive/src/drive/credit_pools/mod.rs:50:5 | 50 | use dpp::fee::SignedCredits; | ^^^^^^^^^^^^^^^^^^^^^^^
Rust packages (rs-sdk) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
unused import: `crate::drive::defaults::DEFAULT_HASH_SIZE_U8`: packages/rs-drive/src/drive/document/mod.rs#L37
warning: unused import: `crate::drive::defaults::DEFAULT_HASH_SIZE_U8` --> packages/rs-drive/src/drive/document/mod.rs:37:5 | 37 | use crate::drive::defaults::DEFAULT_HASH_SIZE_U8; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`: packages/rs-drive/src/drive/document/mod.rs#L42
warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters` --> packages/rs-drive/src/drive/document/mod.rs:42:5 | 42 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`: packages/rs-drive/src/drive/document/mod.rs#L43
warning: unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods` --> packages/rs-drive/src/drive/document/mod.rs:43:5 | 43 | use dpp::data_contract::document_type::methods::DocumentTypeV0Methods; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `dpp::data_contract::document_type::DocumentTypeRef`: packages/rs-drive/src/drive/document/mod.rs#L45
warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef` --> packages/rs-drive/src/drive/document/mod.rs:45:5 | 45 | use dpp::data_contract::document_type::DocumentTypeRef; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Rust packages (wasm-dpp) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
module has the same name as its containing module: packages/wasm-dpp/src/data_contract_factory/mod.rs#L1
warning: module has the same name as its containing module --> packages/wasm-dpp/src/data_contract_factory/mod.rs:1:1 | 1 | mod data_contract_factory; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
very complex type used. Consider factoring parts into `type` definitions: packages/wasm-dpp/src/document/factory.rs#L153
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/wasm-dpp/src/document/factory.rs:153:24 | 153 | let documents: Vec<( | ________________________^ 154 | | DocumentTransitionActionType, 155 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 156 | | )> = documents_by_action | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
use of a fallible conversion when an infallible one could be used: packages/wasm-dpp/src/document/factory.rs#L322
warning: use of a fallible conversion when an infallible one could be used --> packages/wasm-dpp/src/document/factory.rs:322:27 | 322 | let documents_array = js_sys::Array::try_from(documents_with_action) | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `JsValue` to `Array` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm`: packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs#L21
warning: you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm` --> packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs:21:5 | 21 | / pub fn new() -> Self { 22 | | Self { 23 | | inner: MissingStateTransitionTypeError::new(), 24 | | } 25 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 19 + impl Default for MissingStateTransitionTypeErrorWasm { 20 + fn default() -> Self { 21 + Self::new() 22 + } 23 + } |
casting to the same type is unnecessary (`u64` -> `u64`): packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs#L35
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs:35:9 | 35 | *self.inner.setting_identity_contract_nonce() as u64 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*self.inner.setting_identity_contract_nonce()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm`: packages/wasm-dpp/src/errors/value_error.rs#L29
warning: implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm` --> packages/wasm-dpp/src/errors/value_error.rs:29:5 | 29 | / pub fn to_string(&self) -> String { 30 | | format!("PlatformValueError: {}", self.message) 31 | | } | |_____^ | = help: implement trait `Display` for type `errors::value_error::PlatformValueErrorWasm` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string = note: `#[warn(clippy::inherent_to_string)]` on by default
module has the same name as its containing module: packages/wasm-dpp/src/identity/mod.rs#L30
warning: module has the same name as its containing module --> packages/wasm-dpp/src/identity/mod.rs:30:1 | 30 | mod identity; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
module has the same name as its containing module: packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs#L4
warning: module has the same name as its containing module --> packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs:4:1 | 4 | pub mod identity_create_transition; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
module has the same name as its containing module: packages/wasm-dpp/src/identity/state_transition/identity_topup_transition/mod.rs#L4
warning: module has the same name as its containing module --> packages/wasm-dpp/src/identity/state_transition/identity_topup_transition/mod.rs:4:1 | 4 | pub mod identity_topup_transition; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
module has the same name as its containing module: packages/wasm-dpp/src/identity/state_transition/identity_update_transition/mod.rs#L5
warning: module has the same name as its containing module --> packages/wasm-dpp/src/identity/state_transition/identity_update_transition/mod.rs:5:1 | 5 | pub mod identity_update_transition; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
Rust packages (wasm-dpp) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (wasm-dpp) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/sccache-action@v0.0.3, strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (wasm-dpp) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
JS code security audit / Run Code QL
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS code security audit / Run Code QL
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
JS packages (@dashevo/dapi) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi-grpc) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi-client) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi-client) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/platform-test-suite) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi-grpc) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/wallet-lib) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/wallet-lib) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/wasm-dpp) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dashmate) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/wasm-dpp) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dash) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Client.ts#L10
Dependency cycle via ./Platform:1
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Client.ts#L166
Assignment to function parameter 'options'
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Fetcher/Fetcher.ts#L143
Returning an awaited value that is not a promise is not allowed
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.spec.ts#L5
Using exported name 'Client' as identifier for default export
JS packages (dash) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L5
Using exported name 'Client' as identifier for default export
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L8
Using exported name 'createAssetLockTransaction' as identifier for default export
JS packages (dashmate) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Dashmate E2E tests (Testnet Evonode, test/e2e/testnetEvonode.spec.js, false) / Run Testnet Evonode tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Dashmate E2E tests (Testnet fullnode, test/e2e/testnetFullnode.spec.js, false) / Run Testnet fullnode tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Dashmate E2E tests (Local network, test/e2e/localNetwork.spec.js, true) / Run Local network tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Packages functional tests / Run functional tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.