-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merge into split #15644
Merged
Merged
fix: merge into split #15644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantengsky
force-pushed
the
fix-merge-into-split
branch
3 times, most recently
from
May 28, 2024 02:16
c7dac6c
to
ac48fc6
Compare
xudong963
approved these changes
May 28, 2024
dantengsky
force-pushed
the
fix-merge-into-split
branch
from
May 28, 2024 09:43
ac48fc6
to
dbfa34c
Compare
for merge-into stmt with both matched and not-matched branch, right join is used, after got the joined result-set, a column of the result-set is chosen as the "split" column, i.e. for rows of the split column, those are nulls are recognized as no-matched, and others as matched. before this PR, an arbitrary column of target table is picked as the "split" column, which is unsafe, since the "arbitrary column" may have NULL values originally, which may lead to incorrectly treat a matched row as unmatched, and unexpected result (data duplication).
dantengsky
force-pushed
the
fix-merge-into-split
branch
from
May 28, 2024 09:53
dbfa34c
to
879228f
Compare
xudong963
approved these changes
May 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
for merge-into stmt with both matched and not-matched branch, right join is used,
after got the joined result-set, a column of the result-set is chosen as the "split" column,
i.e. for rows of the split column, those are nulls are recognized as no-matched, and others as matched.
before this PR, an arbitrary column of target table is picked as the "split" column, which is unsafe, since
the "arbitrary column" may have NULL values originally, which may lead to incorrectly treat a matched row
as unmatched, and unexpected result (data duplication).
in this PR, we use
row_id
column to split the result-set into matched and not-matched partsMERGE INTO
duplicates rows unexpectedly #15643Tests
Type of change
This change is