Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: merge into split #15644

Merged
merged 5 commits into from
May 28, 2024
Merged

fix: merge into split #15644

merged 5 commits into from
May 28, 2024

Commits on May 28, 2024

  1. fix: merge into split logic 

    for merge-into stmt with both matched and not-matched branch, right join
is used,
after got the joined result-set, a column of the result-set is chosen as
the "split" column,
i.e. for rows of the split column, those are nulls are recognized as
no-matched, and others as matched.

before this PR, an arbitrary column of target table is picked as the
"split" column, which is unsafe, since
the "arbitrary column" may have NULL values originally, which may lead
to incorrectly treat a matched row
as unmatched, and unexpected result (data duplication).
    @dantengsky
    dantengsky committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e320f72 View commit details
    Browse the repository at this point in the history

  2. disable target build

    @dantengsky
    dantengsky committed May 28, 2024
    Configuration menu
    Copy the full SHA
    146af25 View commit details
    Browse the repository at this point in the history

  3. adjust logic tests

    @dantengsky
    dantengsky committed May 28, 2024
    Configuration menu
    Copy the full SHA
    ac3b74b View commit details
    Browse the repository at this point in the history

  4. reabase & fix clippy

    @dantengsky
    dantengsky committed May 28, 2024
    Configuration menu
    Copy the full SHA
    879228f View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into fix-merge-into-split

    @dantengsky
    dantengsky committed May 28, 2024
    Configuration menu
    Copy the full SHA
    81a9c55 View commit details
    Browse the repository at this point in the history