Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce sample possibility to avoid flaky test #16330

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: reduce sample possibility to avoid flaky test #16330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
264dcb8
fix: reduce sample possibility to avoid flaky test
xudong963 Aug 26, 2024
3c3b46d
rule fold cout agg with sample table
xudong963 Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/query/sql/src/planner/plans/scan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ impl Operator for Scan {
};

// If prewhere is not none, we can't get precise cardinality
let precise_cardinality = if self.prewhere.is_none() {
let precise_cardinality = if self.prewhere.is_none() && self.sample.is_none() {
precise_cardinality
} else {
None
Expand Down
6 changes: 3 additions & 3 deletions tests/sqllogictests/suites/mode/standalone/explain/table_sample.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ drop table t;
statement ok
create or replace table t as select number as a from numbers(10000000);

query
query
select count(distinct a) < 10000000 from t sample block(50);
----
1
Expand Down Expand Up @@ -91,8 +91,8 @@ Filter



query
select count(distinct number) < 10000000 from numbers(10000000) sample block(50);
query
select count(number) < 10000000000 from numbers(10000000000) sample block(0.01);
----
1

Expand Down
Loading