Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(function): validate function args before get type #4888

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Apr 16, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix panic caused by wrong arg numbers.

Changelog

  • Bug Fix

Related Issues

Fixes #4776
Fixes #4885

@vercel
Copy link

vercel bot commented Apr 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 16, 2022 at 9:42AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 16, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Apr 16, 2022
@BohuTANG
Copy link
Member

BohuTANG commented Apr 16, 2022

Hmm, this patch will fix #4885?

@b41sh
Copy link
Member Author

b41sh commented Apr 16, 2022

Hmm, this patch will fix #4885?

yes, #4885 will also be fixed

@BohuTANG
Copy link
Member

Add 4885 to the fixes list :D

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BohuTANG BohuTANG merged commit 16fa1c2 into databendlabs:main Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function arguments length check not work select get(parse_json(a, 'aa')) from json_test panic
3 participants