Include acceptance tests in integration tests #2242
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
force-pushed
the
denik/acceptance-integration
branch
from
b6fee09 to
3284091
Compare
This was referenced Jan 27, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
… utf8 (#2244) ## Changes - Do not start replacement / comparison if file is too large or not valid utf-8. - This helps to prevent replacements if there is accidentally a large binary (e.g. terraform). ## Tests Found this problem when working on #2242 -- the tests tried to applied replacements on terraform binary and crashed. With this change, an error is reported instead.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
## Changes - If CLOUD_ENV is set to do not override with dummy value. This allows running acceptance tests as integration tests. - Needed for #2242 ## Tests Manually run the test suite against dogfood. `CLOUD_ENV=aws go test ./acceptance`
denik
force-pushed
the
denik/acceptance-integration
branch
from
53cbbee to
18e71cb
Compare
denik
force-pushed
the
denik/acceptance-integration
branch
from
18e71cb to
d4003d7
Compare
denik
force-pushed
the
denik/acceptance-integration
branch
from
d4003d7 to
6b9be38
Compare
Merged
denik
added a commit
that referenced
this pull request
Jan 28, 2025
It uses workspace.profile, which is used before variables are interpolated, which breaks when this test is run against cloud. Needed for #2242
denik
added a commit
that referenced
this pull request
Jan 28, 2025
This does not work when this test is run against cloud. Needed for #2242
denik
added a commit
that referenced
this pull request
Jan 28, 2025
This does not work when this test is run against cloud. Needed for #2242
denik
force-pushed
the
denik/acceptance-integration
branch
from
6392550 to
8ad39c9
Compare
denik
added a commit
that referenced
this pull request
Jan 28, 2025
This does not work when this test is run against cloud. Needed for #2242
pietern
reviewed
Jan 29, 2025
| @@ -0,0 +1,12 @@ | |||
| [[Repls]] | |||
| Old = '- (user_name|service_principal_name): \$USERNAME' | |||
| New = '- user_name_OR_service_principal_name: $$USERNAME' | |||
There was a problem hiding this comment.
Can you include a comment explaining why these replacements need to happen? Good for posterity.
Call 'make vendor' otherwise it's not building
denik
force-pushed
the
denik/acceptance-integration
branch
from
65c44cc to
9971970
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
This is something terraform provider expects. Related to #2242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.