Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acc: Disable git hooks #2249

Merged
merged 1 commit into from
Jan 28, 2025
Merged

acc: Disable git hooks #2249

merged 1 commit into from
Jan 28, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 28, 2025

Otherwise hooks from universe and custom hooks run in tests.

Needed for running acceptance tests as integration tests: #2242

Otherwise hooks from universe and custom hooks run in tests.
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are system-wide defaults picked up otherwise?

@denik denik added this pull request to the merge queue Jan 28, 2025
@denik
Copy link
Contributor Author

denik commented Jan 28, 2025

Not sure about system-wide but I saw my custom hooks getting picked up. It is only the case if CLOUD_ENV is set because then we leave HOME alone.

Merged via the queue into main with commit 5971bd5 Jan 28, 2025
9 checks passed
@denik denik deleted the denik/acc-disable-git-hooks branch January 28, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants