Improve way of accessing __annotations__
#216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSpece
pushed a commit
to MichaelSpece/databricks-sdk-py
that referenced
this pull request
Jul 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 53.08% 53.08%
=======================================
Files 32 32
Lines 18558 18562 +4
=======================================
+ Hits 9851 9854 +3
- Misses 8707 8708 +1
☔ View full report in Codecov by Sentry. |
MichaelSpece
pushed a commit
to MichaelSpece/databricks-sdk-py
that referenced
this pull request
Jul 11, 2023
nfx
approved these changes
Jul 17, 2023
|
@MichaelSpece please apply code formatting ( |
MichaelSpece
added a commit
to MichaelSpece/databricks-sdk-py
that referenced
this pull request
Jul 17, 2023
MichaelSpece
added a commit
to MichaelSpece/databricks-sdk-py
that referenced
this pull request
Jul 17, 2023
|
@nfx Done. Please let me know what else might be required. |
|
@MichaelSpece let github actions tell the truth! :) |
MichaelSpece
pushed a commit
to MichaelSpece/databricks-sdk-py
that referenced
this pull request
Jul 17, 2023
MichaelSpece
pushed a commit
to MichaelSpece/databricks-sdk-py
that referenced
this pull request
Jul 17, 2023
MichaelSpece
added a commit
to MichaelSpece/databricks-sdk-py
that referenced
this pull request
Jul 17, 2023
MichaelSpece
added a commit
to MichaelSpece/databricks-sdk-py
that referenced
this pull request
Jul 17, 2023
MichaelSpece
force-pushed
the
main
branch
2 times, most recently
from
3f9bfb7
to
6f93548
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use recommended way of accessing
__annotations__while maintaining backward compatibility.Tests
I've added a test that catches the bug.
make testrun locallymake fmtapplied