Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve access of __annotations__ #239

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Improve access of __annotations__ #239

merged 5 commits into from
Jul 26, 2023

Conversation

MichaelSpece
Copy link
Contributor

Changes

This is a continuation of #216, but with signed, verified commits.

Tests

One test was added (in #216). The last run in #216 passed all tests.

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@MichaelSpece
Copy link
Contributor Author

@nfx GitHub was complaining about unsigned commits so I resynced my fork, which closed #216.

nfx
nfx suggested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like too big of a change, can't accept it.

please make sure the PR holds diff only for the relevant changes. most likely the newline characters are changed or something like it.

@nfx nfx changed the title #215 Improve access of __annotations__. Improve access of __annotations__ Jul 18, 2023
@MichaelSpece
Copy link
Contributor Author

@nfx Ok; the line endings had indeed been modified. I have now rebased with auto handling of line endings and the diff is showing a relatively small difference.

nfx
nfx previously requested changes Jul 18, 2023
View reviewed changes
tests/test_core.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e07e0a) 53.23% compared to head (769c5d7) 53.23%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   53.23%   53.23%           
=======================================
  Files          32       32           
  Lines       19224    19227    +3     
=======================================
+ Hits        10233    10236    +3     
  Misses       8991     8991
Files Changed Coverage Δ
databricks/sdk/core.py 66.71% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSpece MichaelSpece requested a review from nfx July 24, 2023 16:01
@mgyucht mgyucht self-requested a review July 26, 2023 09:10
mgyucht
mgyucht approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! I'll approve as @nfx is on PTO.

@mgyucht mgyucht dismissed nfx’s stale review July 26, 2023 09:36

On PTO, unblocking merging this change.

@mgyucht mgyucht merged commit f0a18cc into databricks:main Jul 26, 2023
6 checks passed
tanmay-db added a commit that referenced this pull request Jul 26, 2023
@tanmay-db
Release v0.3.0
a066406 
* Fixed serialization of lists of enum values ([#248](#248)).
* Handled nested query parameters in ApiClient.do()
([#249](#249)).
* Improved access of `__annotations__` ([#239](#239)).

API Changes:

 * Changed `create()` method for [a.account_metastore_assignments](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_metastore_assignments.html) account-level service to no longer return `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItemList` dataclass.
 * Added `connection_name` field for `databricks.sdk.service.catalog.CreateCatalog`.
 * Added `access_point` field for `databricks.sdk.service.catalog.CreateExternalLocation`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.CreateExternalLocation`.
 * Removed `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItem` dataclass.
 * Added `access_point` field for `databricks.sdk.service.catalog.ExternalLocationInfo`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.ExternalLocationInfo`.
 * Added `access_point` field for `databricks.sdk.service.catalog.TableInfo`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.TableInfo`.
 * Added `access_point` field for `databricks.sdk.service.catalog.UpdateExternalLocation`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.UpdateExternalLocation`.
 * Added `access_point` field for `databricks.sdk.service.catalog.VolumeInfo`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.VolumeInfo`.
 * Added `databricks.sdk.service.catalog.EncryptionDetails` dataclass.
 * Added `databricks.sdk.service.catalog.SseEncryptionDetails` dataclass.
 * Added `databricks.sdk.service.catalog.SseEncryptionDetailsAlgorithm` dataclass.
 * Added [a.account_network_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_network_policy.html) account-level service.
 * Added `databricks.sdk.service.settings.AccountNetworkPolicyMessage` dataclass.
 * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyRequest` dataclass.
 * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyResponse` dataclass.
 * Added `databricks.sdk.service.settings.ReadAccountNetworkPolicyRequest` dataclass.
 * Added `databricks.sdk.service.settings.UpdateAccountNetworkPolicyRequest` dataclass.

OpenAPI SHA: fbdd0fa3e83fed2c798a58d376529bdb1285b915, Date: 2023-07-26
@tanmay-db tanmay-db mentioned this pull request Jul 26, 2023
Merged
tanmay-db added a commit that referenced this pull request Jul 27, 2023
@tanmay-db
Release v0.3.0
d00f9a4 
* Fixed serialization of lists of enum values ([#248](#248)).
* Handle nested query parameters in ApiClient.do() ([#249](#249)).
* Improve access of `__annotations__` ([#239](#239)).

API Changes:

 * Changed `create()` method for [a.account_metastore_assignments](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_metastore_assignments.html) account-level service to no longer return `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItemList` dataclass.
 * Added `connection_name` field for `databricks.sdk.service.catalog.CreateCatalog`.
 * Added `access_point` field for `databricks.sdk.service.catalog.CreateExternalLocation`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.CreateExternalLocation`.
 * Removed `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItem` dataclass.
 * Added `access_point` field for `databricks.sdk.service.catalog.ExternalLocationInfo`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.ExternalLocationInfo`.
 * Added `access_point` field for `databricks.sdk.service.catalog.TableInfo`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.TableInfo`.
 * Added `access_point` field for `databricks.sdk.service.catalog.UpdateExternalLocation`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.UpdateExternalLocation`.
 * Added `access_point` field for `databricks.sdk.service.catalog.VolumeInfo`.
 * Added `encryption_details` field for `databricks.sdk.service.catalog.VolumeInfo`.
 * Added `databricks.sdk.service.catalog.EncryptionDetails` dataclass.
 * Added `databricks.sdk.service.catalog.SseEncryptionDetails` dataclass.
 * Added `databricks.sdk.service.catalog.SseEncryptionDetailsAlgorithm` dataclass.
 * Added [a.account_network_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_network_policy.html) account-level service.
 * Added `databricks.sdk.service.settings.AccountNetworkPolicyMessage` dataclass.
 * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyRequest` dataclass.
 * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyResponse` dataclass.
 * Added `databricks.sdk.service.settings.ReadAccountNetworkPolicyRequest` dataclass.
 * Added `databricks.sdk.service.settings.UpdateAccountNetworkPolicyRequest` dataclass.

OpenAPI SHA: a1b6c1ecfaab6635911d3c060a8dd797ac6b2d4d, Date: 2023-07-27
tanmay-db added a commit that referenced this pull request Jul 27, 2023
@tanmay-db
Release v0.3.0 (#250)
519fbe3 
* Fixed serialization of lists of enum values
([#248](#248)).
* Fixed examples that used incorrect keyword argument names.
(databricks/databricks-sdk-go#560)
* Handled nested query parameters in ApiClient.do()
([#249](#249)).
* Improved access of `__annotations__`
([#239](#239)).

API Changes:

* Changed `create()` method for
[a.account_metastore_assignments](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_metastore_assignments.html)
account-level service to no longer return
`databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItemList`
dataclass.
* Added `connection_name` field for
`databricks.sdk.service.catalog.CreateCatalog`.
* Added `access_point` field for
`databricks.sdk.service.catalog.CreateExternalLocation`.
* Added `encryption_details` field for
`databricks.sdk.service.catalog.CreateExternalLocation`.
* Removed
`databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItem`
dataclass.
* Added `access_point` field for
`databricks.sdk.service.catalog.ExternalLocationInfo`.
* Added `encryption_details` field for
`databricks.sdk.service.catalog.ExternalLocationInfo`.
* Added `access_point` field for
`databricks.sdk.service.catalog.TableInfo`.
* Added `encryption_details` field for
`databricks.sdk.service.catalog.TableInfo`.
* Added `access_point` field for
`databricks.sdk.service.catalog.UpdateExternalLocation`.
* Added `encryption_details` field for
`databricks.sdk.service.catalog.UpdateExternalLocation`.
* Added `access_point` field for
`databricks.sdk.service.catalog.VolumeInfo`.
* Added `encryption_details` field for
`databricks.sdk.service.catalog.VolumeInfo`.
 * Added `databricks.sdk.service.catalog.EncryptionDetails` dataclass.
* Added `databricks.sdk.service.catalog.SseEncryptionDetails` dataclass.
* Added `databricks.sdk.service.catalog.SseEncryptionDetailsAlgorithm`
dataclass.
* Added
[a.account_network_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_network_policy.html)
account-level service.
* Added `databricks.sdk.service.settings.AccountNetworkPolicyMessage`
dataclass.
* Added
`databricks.sdk.service.settings.DeleteAccountNetworkPolicyRequest`
dataclass.
* Added
`databricks.sdk.service.settings.DeleteAccountNetworkPolicyResponse`
dataclass.
* Added
`databricks.sdk.service.settings.ReadAccountNetworkPolicyRequest`
dataclass.
* Added
`databricks.sdk.service.settings.UpdateAccountNetworkPolicyRequest`
dataclass.

OpenAPI SHA: a1b6c1ecfaab6635911d3c060a8dd797ac6b2d4d, Date: 2023-07-27

---------

Signed-off-by: Tanmay Rustagi <88379306+tanmay-db@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

@nfx nfx Awaiting requested review from nfx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelSpece @codecov-commenter @nfx @mgyucht