-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle nested query parameters in ApiClient.do() #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
approved these changes
Jul 25, 2023
tanmay-db
added a commit
that referenced
this pull request
Jul 26, 2023
* Fixed serialization of lists of enum values ([#248](#248)). * Handled nested query parameters in ApiClient.do() ([#249](#249)). * Improved access of `__annotations__` ([#239](#239)). API Changes: * Changed `create()` method for [a.account_metastore_assignments](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_metastore_assignments.html) account-level service to no longer return `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItemList` dataclass. * Added `connection_name` field for `databricks.sdk.service.catalog.CreateCatalog`. * Added `access_point` field for `databricks.sdk.service.catalog.CreateExternalLocation`. * Added `encryption_details` field for `databricks.sdk.service.catalog.CreateExternalLocation`. * Removed `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItem` dataclass. * Added `access_point` field for `databricks.sdk.service.catalog.ExternalLocationInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.ExternalLocationInfo`. * Added `access_point` field for `databricks.sdk.service.catalog.TableInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.TableInfo`. * Added `access_point` field for `databricks.sdk.service.catalog.UpdateExternalLocation`. * Added `encryption_details` field for `databricks.sdk.service.catalog.UpdateExternalLocation`. * Added `access_point` field for `databricks.sdk.service.catalog.VolumeInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.VolumeInfo`. * Added `databricks.sdk.service.catalog.EncryptionDetails` dataclass. * Added `databricks.sdk.service.catalog.SseEncryptionDetails` dataclass. * Added `databricks.sdk.service.catalog.SseEncryptionDetailsAlgorithm` dataclass. * Added [a.account_network_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_network_policy.html) account-level service. * Added `databricks.sdk.service.settings.AccountNetworkPolicyMessage` dataclass. * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyRequest` dataclass. * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyResponse` dataclass. * Added `databricks.sdk.service.settings.ReadAccountNetworkPolicyRequest` dataclass. * Added `databricks.sdk.service.settings.UpdateAccountNetworkPolicyRequest` dataclass. OpenAPI SHA: fbdd0fa3e83fed2c798a58d376529bdb1285b915, Date: 2023-07-26
Merged
tanmay-db
added a commit
that referenced
this pull request
Jul 27, 2023
* Fixed serialization of lists of enum values ([#248](#248)). * Handle nested query parameters in ApiClient.do() ([#249](#249)). * Improve access of `__annotations__` ([#239](#239)). API Changes: * Changed `create()` method for [a.account_metastore_assignments](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_metastore_assignments.html) account-level service to no longer return `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItemList` dataclass. * Added `connection_name` field for `databricks.sdk.service.catalog.CreateCatalog`. * Added `access_point` field for `databricks.sdk.service.catalog.CreateExternalLocation`. * Added `encryption_details` field for `databricks.sdk.service.catalog.CreateExternalLocation`. * Removed `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItem` dataclass. * Added `access_point` field for `databricks.sdk.service.catalog.ExternalLocationInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.ExternalLocationInfo`. * Added `access_point` field for `databricks.sdk.service.catalog.TableInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.TableInfo`. * Added `access_point` field for `databricks.sdk.service.catalog.UpdateExternalLocation`. * Added `encryption_details` field for `databricks.sdk.service.catalog.UpdateExternalLocation`. * Added `access_point` field for `databricks.sdk.service.catalog.VolumeInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.VolumeInfo`. * Added `databricks.sdk.service.catalog.EncryptionDetails` dataclass. * Added `databricks.sdk.service.catalog.SseEncryptionDetails` dataclass. * Added `databricks.sdk.service.catalog.SseEncryptionDetailsAlgorithm` dataclass. * Added [a.account_network_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_network_policy.html) account-level service. * Added `databricks.sdk.service.settings.AccountNetworkPolicyMessage` dataclass. * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyRequest` dataclass. * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyResponse` dataclass. * Added `databricks.sdk.service.settings.ReadAccountNetworkPolicyRequest` dataclass. * Added `databricks.sdk.service.settings.UpdateAccountNetworkPolicyRequest` dataclass. OpenAPI SHA: a1b6c1ecfaab6635911d3c060a8dd797ac6b2d4d, Date: 2023-07-27
tanmay-db
added a commit
that referenced
this pull request
Jul 27, 2023
* Fixed serialization of lists of enum values ([#248](#248)). * Fixed examples that used incorrect keyword argument names. (databricks/databricks-sdk-go#560) * Handled nested query parameters in ApiClient.do() ([#249](#249)). * Improved access of `__annotations__` ([#239](#239)). API Changes: * Changed `create()` method for [a.account_metastore_assignments](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_metastore_assignments.html) account-level service to no longer return `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItemList` dataclass. * Added `connection_name` field for `databricks.sdk.service.catalog.CreateCatalog`. * Added `access_point` field for `databricks.sdk.service.catalog.CreateExternalLocation`. * Added `encryption_details` field for `databricks.sdk.service.catalog.CreateExternalLocation`. * Removed `databricks.sdk.service.catalog.CreateMetastoreAssignmentsResponseItem` dataclass. * Added `access_point` field for `databricks.sdk.service.catalog.ExternalLocationInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.ExternalLocationInfo`. * Added `access_point` field for `databricks.sdk.service.catalog.TableInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.TableInfo`. * Added `access_point` field for `databricks.sdk.service.catalog.UpdateExternalLocation`. * Added `encryption_details` field for `databricks.sdk.service.catalog.UpdateExternalLocation`. * Added `access_point` field for `databricks.sdk.service.catalog.VolumeInfo`. * Added `encryption_details` field for `databricks.sdk.service.catalog.VolumeInfo`. * Added `databricks.sdk.service.catalog.EncryptionDetails` dataclass. * Added `databricks.sdk.service.catalog.SseEncryptionDetails` dataclass. * Added `databricks.sdk.service.catalog.SseEncryptionDetailsAlgorithm` dataclass. * Added [a.account_network_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_network_policy.html) account-level service. * Added `databricks.sdk.service.settings.AccountNetworkPolicyMessage` dataclass. * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyRequest` dataclass. * Added `databricks.sdk.service.settings.DeleteAccountNetworkPolicyResponse` dataclass. * Added `databricks.sdk.service.settings.ReadAccountNetworkPolicyRequest` dataclass. * Added `databricks.sdk.service.settings.UpdateAccountNetworkPolicyRequest` dataclass. OpenAPI SHA: a1b6c1ecfaab6635911d3c060a8dd797ac6b2d4d, Date: 2023-07-27 --------- Signed-off-by: Tanmay Rustagi <88379306+tanmay-db@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Query History list API filter_by query parameter is modeled by a dictionary, rather than a primitive type, defining the allowed filters including
query_start_time_range
,statuses
,user_ids
, andwarehouse_ids
. To be compatible with gRPC transcoding, query parameters modeled by message types as opposed to primitives need to be separated into one query parameter per nested field, where the key is the path to that query parameter. For example:becomes
For this to be compatible with the requests library we use today, we need to convert the first dictionary to
This resolves one of the problems from #99. The issue with the conflict between filter_by and next_page_token will be resolved by the backend service.
Tests
Added an integration test that covers query history listing with a filter_by parameter.
make test
run locallymake fmt
applied