Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip filesinrepos to true if false #42

Merged
merged 11 commits into from
Feb 13, 2024
Merged

Conversation

pritishpai
Copy link
Contributor

No description provided.

@pritishpai pritishpai requested a review from nfx as a code owner February 12, 2024 02:38
@CLAassistant
Copy link

CLAassistant commented Feb 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (655fff6) 77.08% compared to head (eb27b59) 77.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   77.08%   77.23%   +0.14%     
==========================================
  Files          13       13              
  Lines        1270     1278       +8     
  Branches      230      232       +2     
==========================================
+ Hits          979      987       +8     
  Misses        201      201              
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't do random in unit testing

tests/unit/test_installation.py Outdated Show resolved Hide resolved
tests/unit/test_installation.py Outdated Show resolved Hide resolved
@nfx nfx merged commit e6a08fb into databrickslabs:main Feb 13, 2024
8 of 9 checks passed
nfx added a commit that referenced this pull request Feb 13, 2024
* Automatically enable workspace filesystem if the feature is disabled ([#42](#42)).
@nfx nfx mentioned this pull request Feb 13, 2024
nfx added a commit that referenced this pull request Feb 13, 2024
* Automatically enable workspace filesystem if the feature is disabled
([#42](#42)).
@pritishpai pritishpai deleted the fix/issue_576 branch February 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants