Installation checks if either configs ("enableProjectTypeInWorkspace", "enableWorkspaceFilesystem") are 'false' and makes them 'true' for valid installation #831
Conversation
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
==========================================
+ Coverage 87.21% 87.23% +0.02%
==========================================
Files 41 41
Lines 5200 5211 +11
Branches 936 938 +2
==========================================
+ Hits 4535 4546 +11
Misses 458 458
Partials 207 207 ☔ View full report in Codecov by Sentry. |
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
|
sdk is fixed - databricks/databricks-sdk-py#525 |
pritishpai
force-pushed
the
fix/issue_576
branch
from
79f8899 to
787a6ad
Compare
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
|
The sdk changes are not released yet, so make changes to the toml file and pulled in latest commit. Can only merge after the next release. There are other changes in sdk that I had to make to update the codebase(e.g. [https://github.com/databricks/databricks-sdk-py/pull/522]). Should I added them as a part of this PR too @nfx ? |
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
pritishpai
force-pushed
the
fix/issue_576
branch
from
013508d to
b4a48d7
Compare
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
There was a problem hiding this comment.
Could you implement it in the blueprint library instead? Eg manually create a new dummy workspace (for isolation), disable settings, then in Installation.load (or deeper), catch the "feature disabled" exception, call this code to set the status, and retry there.
This would be the most impactful implementation, that is the easiest to test in isolation
|
Work now done in the blueprint repo: |
Changes
Installation fails if either of the configs ("enableProjectTypeInWorkspace", "enableWorkspaceFilesystem") are 'false'. Checks the two configs via API and sets them to "true" if they are "false".
Linked issues
Resolves #576
Functionality
databricks labs ucx .........Tests
Using SDK for getting and setting conf values blocked by databricks/databricks-sdk-py#500