Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View config as protos, via a new class #1760

Merged
merged 12 commits into from
Jun 28, 2024
1 change: 1 addition & 0 deletions core/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ ts_library(
srcs = [
"actions/assertion.ts",
"actions/declaration.ts",
"actions/view.ts",
"actions/index.ts",
"actions/operation.ts",
"actions/notebook.ts",
Expand Down
8 changes: 1 addition & 7 deletions core/actions/declaration.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
import { verifyObjectMatchesProto, VerifyProtoErrorBehaviour } from "df/common/protos";
import { ActionBuilder } from "df/core/actions";
import { ColumnDescriptors } from "df/core/column_descriptors";
import {
IColumnsDescriptor,
IDocumentableConfig,
INamedConfig,
ITargetableConfig
} from "df/core/common";
import { Session } from "df/core/session";
import { actionConfigToCompiledGraphTarget, checkExcessProperties } from "df/core/utils";
import { actionConfigToCompiledGraphTarget } from "df/core/utils";
import { dataform } from "df/protos/ts";

interface ILegacyDeclarationConfig extends dataform.ActionConfig.DeclarationConfig {
Expand Down
3 changes: 2 additions & 1 deletion core/actions/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import { Declaration } from "df/core/actions/declaration";
import { Notebook } from "df/core/actions/notebook";
import { Operation } from "df/core/actions/operation";
import { Table } from "df/core/actions/table";
import { View } from "df/core/actions/view";
import { Session } from "df/core/session";
import { dataform } from "df/protos/ts";

export type Action = Table | Operation | Assertion | Declaration | Notebook;
export type Action = Table | View | Operation | Assertion | Declaration | Notebook;

// TODO(ekrekr): In v4, make all method on inheritors of this private, forcing users to use
// constructors in order to populate actions.
Expand Down
Loading