Upgrades Piggy to net7.0, updates all .nupkgs to latest, and removes custom Npgsql to Serilog logging bridge...
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 20, 2023 08:34
- use standard mapping of Microsoft.Extensions.Logging - to Serilog (via SerilogLoggerFactory) from Serilog.Extensions.Logging - tested outputting log messages at INF level ok
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
added 8 commits
April 20, 2023 10:34
- to <TrimMode>full</TrimMode> by default - add <TrimMode>partial</TrimMode> to get old net5.0 / net6.0 behaviour - and <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> - to only suppress IL2104 warnings - e.g. error IL2104: Assembly 'Autofac' produced trim warnings - which otherwise would be treated as errors - as we set <TreatWarningsAsErrors>true</TreatWarningsAsErrors> - see: https://stackoverflow.com/questions/74151256/c-sharp-publishtrimmed-how-to-deal-with-il2104-trim-warnings-in-dependencies - "you can suppress these warnings, but essentially, .. - there's no way for you to solve the problem".
todthomson
changed the title
net7.0, updates all .nupkgs to latest, and removes custom Npgsql to Serilog logging bridge...net7.0, updates all .nupkgs to latest, and removes custom Npgsql to Serilog logging bridge...
todthomson
changed the title
net7.0, updates all .nupkgs to latest, and removes custom Npgsql to Serilog logging bridge...net7.0, updates all .nupkgs to latest, and removes custom Npgsql to Serilog logging bridge...
todthomson
commented
Apr 20, 2023
nblumhardt
approved these changes
Apr 21, 2023
added 2 commits
April 21, 2023 10:43
- handle duplicate keys - by dropping subsequent items with same key
todthomson
deleted the
fix/upgrade-to-net70-and-update-nupkgs-and-remove-custom-serilog-logger
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net7.0..nupkgs to latest.NpgsqltoSeriloglogging bridge.Microsoft.Extensions.Loggingbridge viaNpgsqlLoggingConfiguration.InitializeLogging(new SerilogLoggerFactory());/p:PublishTrimmed=true, we have to setTrimMode=partialandSuppressTrimAnalysisWarnings=trueto get back to thenet5.0andnet6.0behaviour.net7.0now defaults to "trim everything that doesn't explicitly opt-out of trimming" where asnet6.0and earlier defaulted to "trim only things that have explicitly opted-in to trimming.null, which obviously isn't true.