-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 Release #36
Merged
2.0.0 Release #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernization
removed gitter link
- use standard mapping of Microsoft.Extensions.Logging - to Serilog (via SerilogLoggerFactory) from Serilog.Extensions.Logging - tested outputting log messages at INF level ok
- to <TrimMode>full</TrimMode> by default - add <TrimMode>partial</TrimMode> to get old net5.0 / net6.0 behaviour - and <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> - to only suppress IL2104 warnings - e.g. error IL2104: Assembly 'Autofac' produced trim warnings - which otherwise would be treated as errors - as we set <TreatWarningsAsErrors>true</TreatWarningsAsErrors> - see: https://stackoverflow.com/questions/74151256/c-sharp-publishtrimmed-how-to-deal-with-il2104-trim-warnings-in-dependencies - "you can suppress these warnings, but essentially, .. - there's no way for you to solve the problem".
- handle duplicate keys - by dropping subsequent items with same key
…e-nupkgs-and-remove-custom-serilog-logger Upgrades Piggy to `net7.0`, updates all `.nupkg`s to latest, and removes custom Npgsql to Serilog logging bridge... - Upgrades Piggy to net7.0. - Updates all .nupkgs to latest. - Removes custom Npgsql to Serilog logging bridge. - Rather, uses Microsoft.Extensions.Logging bridge via NpgsqlLoggingConfiguration.InitializeLogging(new SerilogLoggerFactory()); - Because we already use /p:PublishTrimmed=true, we have to set TrimMode=partial and SuppressTrimAnalysisWarnings=true to get back to the net5.0 and net6.0 behaviour. - This is because net7.0 now defaults to "trim everything that doesn't explicitly opt-out of trimming" where as net6.0 and earlier defaulted to "trim only things that have explicitly opted-in to trimming. - Also, fixes a bug (applies to datalust.co) where Piggy reports it's connecting to host=null, which obviously isn't true.
…-branches #2 try to get the builds working with updated scripts
Attempts to fix NuGet.org publish. - Updates the encrypted NuGet.org deployment API key. - Removes "dev" deployment of packages to GitHub, as we don't currently (and don't want to) deploy prerelease packages to GitHub. @nblumhardt has reviewed (over my shoulder) and approved this to be merged.
upgrades "npgsql" to version 7.0.4
- dotnet list package --vulnerable --include-transitive - reports on vulnerable packages including deps dependencies recursively - dotnet list package --deprecated --include-transitive - dotnet list package --outdated --include-transitive - adjust exit codes to make them sequential
…rable--include-transitive-etc-reporting-only Add useful `dotnet list package` calls to Build.ps1 to report on NuGet package issues...
- it's not something we can fix - as it's up to our upstream packages to fix these - and we can run this explicitly locally if we care to
…clude-transitive removes --include-transitive as it's noisy and...
Bumps [npgsql](https://github.com/npgsql/npgsql) from 7.0.4 to 8.0.3. - [Release notes](https://github.com/npgsql/npgsql/releases) - [Commits](npgsql/npgsql@v7.0.4...v8.0.3) --- updated-dependencies: - dependency-name: npgsql dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…ggy/npgsql-8.0.3 Bump npgsql from 7.0.4 to 8.0.3 in /src/Datalust.Piggy
…eaks package binary compatibility with varying Npgsql versions
Update to .NET 8 and new Npgsql version
…refix during build
Package and publish as a `dotnet tool` package
Fix dotnet tool publishing
Still no luck getting the tool package working; pulling out some more tricks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet tool
package #35 - package and publish as a .NET tool (@nblumhardt)net7.0
, updates all.nupkg
s to latest, and removes custom Npgsql to Serilog logging bridge... #26 and Update to .NET 8 and new Npgsql version #34 - update to .NET 8 incl dependencies (@todthomson, @nblumhardt)dotnet list package
calls to Build.ps1 to report on NuGet package issues... #31 - build improvements incl vulnerable package check (@todthomson)