Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing brightness slowly ruins the color #30

Closed
Double-A-92 opened this issue Aug 1, 2023 · 1 comment
Closed

Changing brightness slowly ruins the color #30

Double-A-92 opened this issue Aug 1, 2023 · 1 comment

Comments

@Double-A-92
Copy link

Double-A-92 commented Aug 1, 2023 •
edited
Loading

When I change the brightness with the "Light" panel on my home view, the set color slowly degrades towards pure Red, pure Blue or pure Green.

E.g.

  • Set a white-ish color at 100%
  • Change it to 1%
  • Change it back to 100%
  • Color becomes a bit more orange
  • Change it to 1% and back to 100%
  • Color becomes more red
  • Repeat a few times
  • Color is pure Red

image

In real life this color has become Red at 30%

Maybe some rounding or integer division error while calculating the new RGB value?
@ynsgnr
Copy link
Contributor

ynsgnr commented Aug 26, 2023

This should fix it: #41

dave-code-ruiz added a commit that referenced this issue Aug 28, 2023
@dave-code-ruiz
Possible fix for issues #28, #30 and #31
1bd2d44 
Possible fix for issues #28, #30 and #31 , please test it and ask me to reopen it if it doesn't work fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Double-A-92 @ynsgnr @dave-code-ruiz