Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color temperature widget has too high values #31

Closed
Double-A-92 opened this issue Aug 1, 2023 · 5 comments
Closed

Color temperature widget has too high values #31

Double-A-92 opened this issue Aug 1, 2023 · 5 comments

Comments

@Double-A-92
Copy link

Double-A-92 commented Aug 1, 2023

In this view to set the color temperature the values range from 10000K to 999999K, which is too much.

A reasonable range would maybe be 1000K to 9999K. I assume there is maybe some wrong decimal offset..?

image

Also the color for me does not work properly. It's either green-ish at around 10000K, and everywhere else it's a white-blue.
I don't know if it's just my LED strip not supporting it, or if it's because of the high values,

@Jammarman
Copy link

I am also experiencing this

@GormYa
Copy link
Contributor

GormYa commented Aug 23, 2023

I think we should make this range manageable from the settings page. As a result, each user may define their own range that is supported by their LED strip.

@Double-A-92
Copy link
Author

I think the problem is caused by following lines in light.py

@property
    def max_mireds(self):
        return 100

@property
    def min_mireds(self):
        return 1

They overwrite the good defaults (2000 - 6500K) with very high values for some reason.

@dave-code-ruiz
Copy link
Owner

Thanks, you may be right
I review it soon

@Double-A-92
Copy link
Author

Double-A-92 commented Aug 23, 2023

Btw I just saw that the function async def set_color_temp(self, value: int): in elkbledom.py also depends on those values (1 - 100). If you change the values, don't forget it :)

dave-code-ruiz added a commit that referenced this issue Aug 28, 2023
Possible fix for issues #28, #30 and #31 , please test it and ask me to reopen it if it doesn't work fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants