Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update opentelemetry dependencies to the latest version #20

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

dbofmmbt
Copy link

@dbofmmbt dbofmmbt commented Sep 24, 2022

I also had to use a str instead of SpanKind because its Display impl was removed. I checked on tracing-opentelemetry and they did the same.

I suppose we need to go to 0.5 to release it?

I also had to use a `str` instead of SpanKind because its Display impl was removed. I checked on tracing-opentelemetry and they did the same.
@davidB
Copy link
Owner

davidB commented Sep 25, 2022

Thanks for the PR, yes after merge + some update (ci), I'll release as 0.5

@dbofmmbt
Copy link
Author

dbofmmbt commented Sep 25, 2022

After running the project with the same clippy arguments present on .mega-linter.yml, I found some problems regarding opentelemetry-jaeger. It looks like PipelineBuilder was split into CollectorPipeline and AgentPipeline here: open-telemetry/opentelemetry-rust#748.

Are you able to update the PipelineBuilder? I'm not familiar with the opentelemetry-jaeger crate. If you're busy I could take a look later

@davidB
Copy link
Owner

davidB commented Sep 25, 2022

Thanks for the investigation, I could take a look during the week

@davidB davidB merged commit 9314d68 into davidB:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants